LBRYCommunity/lbry-redux

tip management on claim #293

Merged

jessopb merged 1 commit from feat-unlockTips into master

2020-04-01 13:57:47 +02:00

jessopb commented

2020-03-25 03:58:35 +01:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) requested changes 2020-03-25 14:47:13 +01:00

neb-b (Migrated from github.com) left a comment

A couple of questions and small comments

A couple of questions and small comments

src/constants/action_types.js

					
				@ -40,2 +40,4 @@

				export const ABANDON_SUPPORT_STARTED = 'ABANDON_SUPPORT_STARTED';

				export const ABANDON_SUPPORT_COMPLETED = 'ABANDON_SUPPORT_COMPLETED';

				export const ABANDON_CLAIM_SUPPORT_STARTED = 'ABANDON_CLAIM_SUPPORT_STARTED';

				export const ABANDON_CLAIM_SUPPORT_COMPLETED = 'ABANDON_CLAIM_SUPPORT_COMPLETED';

neb-b (Migrated from github.com) commented

2020-03-25 14:47:00 +01:00

Please add ABANDON_CLAIM_SUPPORT_FAILED along with a value in the reducer, just to track the error even if we aren't using it at the moment.

Please add `ABANDON_CLAIM_SUPPORT_FAILED` along with a value in the reducer, just to track the error even if we aren't using it at the moment.

src/redux/actions/wallet.js

neb-b (Migrated from github.com) commented

2020-03-25 14:44:53 +01:00

When would someone pass true for preview?

When would someone pass `true` for preview?

src/redux/actions/wallet.js

neb-b (Migrated from github.com) commented

2020-03-25 14:38:27 +01:00

console.log

console.log

neb-b (Migrated from github.com) commented

2020-03-25 14:39:25 +01:00

console.log

console.log

neb-b (Migrated from github.com) commented

2020-03-25 14:40:50 +01:00

Since you are using await here you can also do

const result = await Lbry.transaction_show();
if (result.height > 0) {

Right now it isn't really doing anything

Since you are using `await` here you can also do ``` const result = await Lbry.transaction_show(); if (result.height > 0) { ``` Right now it isn't really doing anything

neb-b (Migrated from github.com) commented

2020-03-25 14:43:29 +01:00

Is it possible to look at something inside the transaction_show call to know if it's a channel or claim? Then we shouldn't need to call both claim_list and channel_list

Is it possible to look at something inside the `transaction_show` call to know if it's a channel or claim? Then we shouldn't need to call both `claim_list` and `channel_list`

src/redux/selectors/wallet.js

neb-b (Migrated from github.com) commented

2020-03-25 14:18:50 +01:00

comment

comment

jessopb (Migrated from github.com) reviewed 2020-03-30 22:35:36 +02:00

src/redux/actions/wallet.js

jessopb (Migrated from github.com) commented

2020-03-30 22:35:36 +02:00

rewrote as Promise.all().then().then()

rewrote as Promise.all().then().then()

jessopb (Migrated from github.com) reviewed 2020-03-30 23:43:57 +02:00

src/redux/actions/wallet.js

jessopb (Migrated from github.com) commented

2020-03-30 23:43:57 +02:00

I stored the value type in pending and only run channel if it has one.

I stored the value type in pending and only run channel if it has one.

jessopb (Migrated from github.com) reviewed 2020-03-31 14:27:22 +02:00

src/redux/actions/wallet.js

jessopb (Migrated from github.com) commented

2020-03-31 14:27:22 +02:00

changed this a bit.I just wanted it safely disabled during testing.

changed this a bit.I just wanted it safely disabled during testing.

jessopb (Migrated from github.com) reviewed 2020-03-31 14:27:48 +02:00

src/redux/actions/wallet.js

jessopb (Migrated from github.com) commented

2020-03-31 14:27:47 +02:00

now storing claim value type in the pending.

now storing claim value type in the pending.

neb-b (Migrated from github.com) approved these changes 2020-03-31 15:41:46 +02:00

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#293

No description provided.