Feat txo paginate #299
Labels
No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-redux#299
Loading…
Reference in a new issue
No description provided.
Delete branch "feat-txo-paginate"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
One main issue about deleting all the old transaction list stuff
@ -35,6 +35,10 @@ export const GET_NEW_ADDRESS_STARTED = 'GET_NEW_ADDRESS_STARTED';
export const GET_NEW_ADDRESS_COMPLETED = 'GET_NEW_ADDRESS_COMPLETED';
export const FETCH_TRANSACTIONS_STARTED = 'FETCH_TRANSACTIONS_STARTED';
export const FETCH_TRANSACTIONS_COMPLETED = 'FETCH_TRANSACTIONS_COMPLETED';
Do you need these old actions still?
and this? Can we nuke it all?
@ -123,0 +179,4 @@
claim_id?: string,
txid?: string,
nout?: number,
} = {
can we call txo_list for page 1 here?
Please add a type for
TXO_LIST_PARAMS
this could be
(state.transactionPage && state.transactionPage.items) || []
same with these too. Since you are doing
|| 1 : 1
, it could just bevalue || 1
@ -35,6 +35,10 @@ export const GET_NEW_ADDRESS_STARTED = 'GET_NEW_ADDRESS_STARTED';
export const GET_NEW_ADDRESS_COMPLETED = 'GET_NEW_ADDRESS_COMPLETED';
export const FETCH_TRANSACTIONS_STARTED = 'FETCH_TRANSACTIONS_STARTED';
export const FETCH_TRANSACTIONS_COMPLETED = 'FETCH_TRANSACTIONS_COMPLETED';
Desktop still has access to the original transaction list.
@ -123,0 +179,4 @@
claim_id?: string,
txid?: string,
nout?: number,
} = {
Considered it.
Currently the component parses the params locally and feeds them to fetchTransactoins(p).
Instead, we would have to parse the params locally and update redux with the params, 'dot then' fetch given the params.
Then we could ask redux to refetch current params at any time...
@ -35,6 +35,10 @@ export const GET_NEW_ADDRESS_STARTED = 'GET_NEW_ADDRESS_STARTED';
export const GET_NEW_ADDRESS_COMPLETED = 'GET_NEW_ADDRESS_COMPLETED';
export const FETCH_TRANSACTIONS_STARTED = 'FETCH_TRANSACTIONS_STARTED';
export const FETCH_TRANSACTIONS_COMPLETED = 'FETCH_TRANSACTIONS_COMPLETED';
The old page brings only the file export of the list. EVentually I figure that would be a modal.
resolved to not enable @flow for this file at this time.
@ -123,0 +179,4 @@
claim_id?: string,
txid?: string,
nout?: number,
} = {
Changed to updating params which calls fetchTxos on success.
Not if we're reimplementing the exporter.
please fix up the strings
i18n