Feat txo paginate #299

Merged
jessopb merged 3 commits from feat-txo-paginate into master 2020-04-15 16:21:38 +02:00
jessopb commented 2020-04-10 19:32:17 +02:00 (Migrated from github.com)
No description provided.
kauffj (Migrated from github.com) reviewed 2020-04-10 19:32:17 +02:00
neb-b (Migrated from github.com) requested changes 2020-04-10 20:50:57 +02:00
neb-b (Migrated from github.com) left a comment

One main issue about deleting all the old transaction list stuff

One main issue about deleting all the old transaction list stuff
@ -35,6 +35,10 @@ export const GET_NEW_ADDRESS_STARTED = 'GET_NEW_ADDRESS_STARTED';
export const GET_NEW_ADDRESS_COMPLETED = 'GET_NEW_ADDRESS_COMPLETED';
export const FETCH_TRANSACTIONS_STARTED = 'FETCH_TRANSACTIONS_STARTED';
export const FETCH_TRANSACTIONS_COMPLETED = 'FETCH_TRANSACTIONS_COMPLETED';
neb-b (Migrated from github.com) commented 2020-04-10 20:47:11 +02:00

Do you need these old actions still?

Do you need these old actions still?
neb-b (Migrated from github.com) commented 2020-04-10 20:47:28 +02:00

and this? Can we nuke it all?

and this? Can we nuke it all?
@ -123,0 +179,4 @@
claim_id?: string,
txid?: string,
nout?: number,
} = {
neb-b (Migrated from github.com) commented 2020-04-10 20:48:15 +02:00

can we call txo_list for page 1 here?

can we call txo_list for page 1 here?
neb-b (Migrated from github.com) commented 2020-04-10 20:48:47 +02:00

Please add a type for TXO_LIST_PARAMS

Please add a type for `TXO_LIST_PARAMS`
neb-b (Migrated from github.com) commented 2020-04-10 20:49:59 +02:00

this could be (state.transactionPage && state.transactionPage.items) || []

this could be `(state.transactionPage && state.transactionPage.items) || []`
neb-b (Migrated from github.com) commented 2020-04-10 20:50:31 +02:00

same with these too. Since you are doing || 1 : 1, it could just be value || 1

same with these too. Since you are doing `|| 1 : 1`, it could just be `value || 1`
jessopb (Migrated from github.com) reviewed 2020-04-10 21:01:39 +02:00
@ -35,6 +35,10 @@ export const GET_NEW_ADDRESS_STARTED = 'GET_NEW_ADDRESS_STARTED';
export const GET_NEW_ADDRESS_COMPLETED = 'GET_NEW_ADDRESS_COMPLETED';
export const FETCH_TRANSACTIONS_STARTED = 'FETCH_TRANSACTIONS_STARTED';
export const FETCH_TRANSACTIONS_COMPLETED = 'FETCH_TRANSACTIONS_COMPLETED';
jessopb (Migrated from github.com) commented 2020-04-10 21:01:39 +02:00

Desktop still has access to the original transaction list.

Desktop still has access to the original transaction list.
jessopb (Migrated from github.com) reviewed 2020-04-10 21:08:58 +02:00
@ -123,0 +179,4 @@
claim_id?: string,
txid?: string,
nout?: number,
} = {
jessopb (Migrated from github.com) commented 2020-04-10 21:08:58 +02:00

Considered it.
Currently the component parses the params locally and feeds them to fetchTransactoins(p).
Instead, we would have to parse the params locally and update redux with the params, 'dot then' fetch given the params.
Then we could ask redux to refetch current params at any time...

Considered it. Currently the component parses the params locally and feeds them to fetchTransactoins(p). Instead, we would have to parse the params locally and update redux with the params, 'dot then' fetch given the params. Then we could ask redux to refetch current params at any time...
jessopb (Migrated from github.com) reviewed 2020-04-10 21:10:34 +02:00
@ -35,6 +35,10 @@ export const GET_NEW_ADDRESS_STARTED = 'GET_NEW_ADDRESS_STARTED';
export const GET_NEW_ADDRESS_COMPLETED = 'GET_NEW_ADDRESS_COMPLETED';
export const FETCH_TRANSACTIONS_STARTED = 'FETCH_TRANSACTIONS_STARTED';
export const FETCH_TRANSACTIONS_COMPLETED = 'FETCH_TRANSACTIONS_COMPLETED';
jessopb (Migrated from github.com) commented 2020-04-10 21:10:34 +02:00

The old page brings only the file export of the list. EVentually I figure that would be a modal.

The old page brings only the file export of the list. EVentually I figure that would be a modal.
jessopb (Migrated from github.com) reviewed 2020-04-10 21:35:55 +02:00
jessopb (Migrated from github.com) commented 2020-04-10 21:35:55 +02:00

resolved to not enable @flow for this file at this time.

resolved to not enable @flow for this file at this time.
jessopb (Migrated from github.com) reviewed 2020-04-13 19:31:02 +02:00
@ -123,0 +179,4 @@
claim_id?: string,
txid?: string,
nout?: number,
} = {
jessopb (Migrated from github.com) commented 2020-04-13 19:31:02 +02:00

Changed to updating params which calls fetchTxos on success.

Changed to updating params which calls fetchTxos on success.
jessopb (Migrated from github.com) reviewed 2020-04-14 22:41:41 +02:00
jessopb (Migrated from github.com) commented 2020-04-14 22:41:41 +02:00

Not if we're reimplementing the exporter.

Not if we're reimplementing the exporter.
neb-b (Migrated from github.com) approved these changes 2020-04-14 23:27:06 +02:00
neb-b (Migrated from github.com) left a comment

please fix up the strings

please fix up the strings
neb-b (Migrated from github.com) commented 2020-04-14 23:26:02 +02:00

i18n

i18n
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#299
No description provided.