Add error when display type not passed to doNotify #30

New issue

Open

opened 2018-05-23 15:05:41 +02:00 by tzarebczan · 1 comment

tzarebczan commented

2018-05-23 15:05:41 +02:00

(Migrated from github.com)

The Issue

Per comments in https://github.com/lbryio/lbry-app/pull/1493#issuecomment-390298790, we should add an error when the doNotify function does not contain all required parameters. If we don't, the notifications get queued up and other notifications don't show afterwards.

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

## The Issue Per comments in https://github.com/lbryio/lbry-app/pull/1493#issuecomment-390298790, we should add an error when the doNotify function does not contain all required parameters. If we don't, the notifications get queued up and other notifications don't show afterwards. ## System Configuration   - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else  ## Screenshots

jessopb commented

2018-09-07 05:58:46 +02:00

(Migrated from github.com)

Agreed, I think my socialShare modal commit was good, but I cancelled it because my feature branch was behaving very strangely. The wallet

doNotify button (notification object which has no id) was matching to my MODALS.SOCIAL_SHARE constant which was also undefined causing it to run my component without the rest of its props, crashing the app.

Also, modalRouter checks to see if "notification" exists, but doesn't check to see if notification.id exists before the switch statement switches on 'id'.

Agreed, I think my socialShare modal commit was good, but I cancelled it because my feature branch was behaving very strangely. The wallet <Address> doNotify button (notification object which has no id) was matching to my MODALS.SOCIAL_SHARE constant which was also undefined causing it to run my component without the rest of its props, crashing the app. Also, modalRouter checks to see if "notification" exists, but doesn't check to see if notification.id exists before the switch statement switches on 'id'.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#30

No description provided.