Incorporating default tags in spanish #321

Merged
michaelmitnick merged 3 commits from master into master 2020-06-05 17:12:08 +02:00
michaelmitnick commented 2020-06-03 05:53:11 +02:00 (Migrated from github.com)

It is my first fork and pull request, please be kind. I hope the task is correct and helps LBRY. I did not implement a new constant because they told me to only add the labels in the DEFAULT_KNOWN_TAGS constant that was already created.

It is my first fork and pull request, please be kind. I hope the task is correct and helps LBRY. I did not implement a new constant because they told me to only add the labels in the DEFAULT_KNOWN_TAGS constant that was already created.
neb-b (Migrated from github.com) reviewed 2020-06-03 05:53:11 +02:00
kauffj (Migrated from github.com) reviewed 2020-06-04 00:40:54 +02:00
@ -524,0 +535,4 @@
'ciencia',
'deportes',
'latinoamérica',
'latam',
kauffj (Migrated from github.com) commented 2020-06-04 00:40:50 +02:00

@seanyesmunt I told @michaelmitnick to do this but we should probably split the Spanish tags into a separate array for easier future refactoring/cleanup

@seanyesmunt I told @michaelmitnick to do this but we should probably split the Spanish tags into a separate array for easier future refactoring/cleanup
kauffj (Migrated from github.com) reviewed 2020-06-04 00:41:13 +02:00
@ -524,0 +535,4 @@
'ciencia',
'deportes',
'latinoamérica',
'latam',
kauffj (Migrated from github.com) commented 2020-06-04 00:41:12 +02:00

(and call .unique() on resultant merge)

(and call `.unique()` on resultant merge)
neb-b commented 2020-06-05 17:12:04 +02:00 (Migrated from github.com)

@michaelmitnick I made a small change and pushed it up to your branch

@michaelmitnick I made a small change and pushed it up to your branch
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#321
No description provided.