LBRYCommunity/lbry-redux
1
0
Fork 0
Code Issues 5 Pull requests 6 Projects Releases Packages Wiki Activity

Fix unresolved "You sent ${amount} LBC" #329

Merged
infinite-persistence merged 1 commit from 4429-unresolved-string into master 2020-06-29 20:41:54 +02:00
Conversation 3 Commits 1 Files changed 1 +1 -1
infinite-persistence commented 2020-06-24 07:34:04 +02:00 (Migrated from github.com)
Copy link

Fixes:

[lbry-desktop] 4429: Unresolved string: "You sent ${amount} LBC"

Changes:

Corrected error in commit c9492522.

## Fixes: [lbry-desktop] [4429](https://github.com/lbryio/lbry-desktop/issues/4429): `Unresolved string: "You sent ${amount} LBC"` ## Changes: Corrected error in commit c9492522.
TigerxWood commented 2020-06-28 23:32:09 +02:00 (Migrated from github.com)
Copy link

Are you sure that is the problem? I just updated the strings in #323 for translation, but the strings are not yet in the file for translations. Because if the cause is of the problem is using ( ' ) instead of ( ` ) then many strings will have this problem. I will update soon the app-strings.jsx with all the missing strings from lbry-desktop and lbry-redux and I hope this problem will be solved.

Are you sure that is the problem? I just updated the strings in #323 for translation, but the strings are not yet in the file for translations. Because if the cause is of the problem is using ( ' ) instead of ( ` ) then many strings will have this problem. I will update soon the app-strings.jsx with all the missing strings from lbry-desktop and lbry-redux and I hope this problem will be solved.
infinite-persistence commented 2020-06-29 04:54:07 +02:00 (Migrated from github.com)
Copy link

Yes. Totally different scenario.

@sean, FYI for the desktop side

Yes. Totally different scenario. - Read: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals - Backticks are not needed for `%xxx%` type of substitution because the `__( )` macro is doing the substitution instead. @sean, FYI for the desktop side
TigerxWood commented 2020-06-29 08:36:03 +02:00 (Migrated from github.com)
Copy link

Yes, you are right. I introduced that (') by mistake when I changed it for localisation.

Yes, you are right. I introduced that (') by mistake when I changed it for localisation.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#329
No description provided.
Delete branch "4429-unresolved-string"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?