Fix convertToShareLink #38

Merged

tzarebczan merged 2 commits from fix-share-link into master

2018-06-01 17:08:58 +02:00

tzarebczan commented

2018-05-31 15:18:13 +02:00

(Migrated from github.com)

Pass correct values to builduri. Otherwise, you get this when right clicking something:

Uncaught Error: Received a channel content URI, but claim name and channelName do not match. "name" represents the value in the name position of the URI (lbry://name...), which for channel content will be the channel name. In most cases, to construct a channel URI you should just pass channelName and contentName.
    at buildURI (C:\Program Files\LBRY\resources\app.asar\node_modules\lbry-redux\dist\bundle.js:126

@dan1d did you run into this during your testing?

Pass correct values to builduri. Otherwise, you get this when right clicking something: ``` Uncaught Error: Received a channel content URI, but claim name and channelName do not match. "name" represents the value in the name position of the URI (lbry://name...), which for channel content will be the channel name. In most cases, to construct a channel URI you should just pass channelName and contentName. at buildURI (C:\Program Files\LBRY\resources\app.asar\node_modules\lbry-redux\dist\bundle.js:126 ``` @dan1d did you run into this during your testing?

neb-b (Migrated from github.com) reviewed 2018-05-31 15:18:13 +02:00

neb-b commented

2018-06-01 02:48:16 +02:00

(Migrated from github.com)

Is it just that there are more values than that in the parseURI which causes the buildURI to fail?

Is it just that there are more values than that in the `parseURI` which causes the `buildURI` to fail?

tzarebczan commented

2018-06-01 02:51:04 +02:00

(Migrated from github.com)

Believe so. I copied the pattern from another function in the same file. I see builduri being called from lbry app with claim name and claim ID typically.

dan1d commented

2018-06-01 03:40:47 +02:00

(Migrated from github.com)

@tzarebczan It worked for me locally before the requested review change, after that request, I've changed the code, I think that I didn't run the command yarn build to actually test the new changes, so the app still worked for me.

Does your commit fix the issue ?

@tzarebczan It worked for me locally before the requested review change, after that request, I've changed the code, I think that I didn't run the command `yarn build` to actually test the new changes, so the app still worked for me. Does your commit fix the issue ?

tzarebczan commented

2018-06-01 06:24:15 +02:00

(Migrated from github.com)

@dan1d yep, this fixed it for me.

No reviewers

neb-b

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#38

No description provided.

Rows
Columns