LBRYCommunity/lbry-redux
1
0
Fork 0
Code Issues 5 Pull requests 6 Projects Releases Packages Wiki Activity

Drop old txo-fetch results #396

Merged
infinite-persistence merged 1 commit from ip-txo-fetch-id into master 2021-03-24 02:35:10 +01:00
Conversation 2 Commits 1 Files changed 3 +50 -9
infinite-persistence commented 2021-03-18 15:14:50 +01:00 (Migrated from github.com)
Copy link

Issue

Closes lbry-desktop 4317: Transaction list shows previously requested data / pages

Approach

A naive approach of creating a random transaction ID for each fetch. The latest ID, stored in state, will be the expected one -- any other transaction results will be dropped.

The loading spinner will continue to spin until the latest ID's results are fetched.

Sample

Example of 3 fast filter switches:
image

??

This assumes there's no quick, built-in way to abort dispatched tasks (only did a quick Google search for it). The ability to abort would speed up the wait-time.

## Issue Closes lbry-desktop [4317: Transaction list shows previously requested data / pages](https://github.com/lbryio/lbry-desktop/issues/4317) ## Approach A naive approach of creating a random transaction ID for each fetch. The latest ID, stored in `state`, will be the expected one -- any other transaction results will be dropped. The loading spinner will continue to spin until the latest ID's results are fetched. ## Sample Example of 3 fast filter switches: ![image](https://user-images.githubusercontent.com/64950861/111640523-393fe680-8837-11eb-8725-d5afb15b895d.png) ## ?? This assumes there's no quick, built-in way to abort dispatched tasks (only did a quick Google search for it). The ability to abort would speed up the wait-time.
jessopb commented 2021-03-24 02:22:28 +01:00 (Migrated from github.com)
Copy link

currently testing on bob

currently testing on bob
tzarebczan commented 2021-03-24 02:35:07 +01:00 (Migrated from github.com)
Copy link

<3 looks great!

<3 looks great!
jessopb (Migrated from github.com) reviewed 2021-03-24 04:40:49 +01:00
jessopb (Migrated from github.com) left a comment
Copy link

👍

:+1:
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#396
No description provided.
Delete branch "ip-txo-fetch-id"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?