Add encryption flow to redux #59

					
				@ -9,0 +10,4 @@

				// TODO: Split into common success and failure types

				// See details in https://github.com/lbryio/lbry/issues/1307

				type ActionResult = {

				  type: any,

neb-b (Migrated from github.com) commented

2018-07-18 15:31:22 +02:00

There should probably be an error attribute here too. Not sure what the daemon returns but it would be nice to know if there was an error decrypting or some unrelated error.

src/redux/selectors/wallet.js

neb-b (Migrated from github.com) commented

2018-07-18 15:32:07 +02:00

I would use createSelector here like you did below.

I would use `createSelector` here like you did below.

neb-b (Migrated from github.com) reviewed 2018-07-20 15:53:21 +02:00

src/redux/reducers/wallet.js

neb-b (Migrated from github.com) commented

2018-07-20 15:53:20 +02:00

We should add Flow types to this.

neb-b (Migrated from github.com) reviewed 2018-07-25 03:43:10 +02:00

src/redux/reducers/wallet.js

					
				@ -9,0 +14,4 @@

				  result: any,

				};

				type WalletState = {

neb-b (Migrated from github.com) commented

2018-07-25 03:43:10 +02:00

Maybe EncryptActionResult?

Maybe `EncryptActionResult`?

neb-b (Migrated from github.com) approved these changes 2018-07-25 03:43:38 +02:00

neb-b (Migrated from github.com) left a comment

I think we should rename that type to specify it's related to encryption

skhameneh (Migrated from github.com) reviewed 2018-07-25 03:47:02 +02:00

src/redux/reducers/wallet.js

					
				@ -9,0 +14,4 @@

				  result: any,

				};

				type WalletState = {

skhameneh (Migrated from github.com) commented

2018-07-25 03:47:02 +02:00

Likely it'll split into multiple at some point.
We don't have any predictable pattern at the moment and this only contains result and could apply to any other action, I can change it but I still think we'll end up with another common pattern.

Likely it'll split into multiple at some point. We don't have any predictable pattern at the moment and this only contains `result` and could apply to any other action, I can change it but I still think we'll end up with another common pattern.

neb-b (Migrated from github.com) reviewed 2018-07-25 03:47:53 +02:00

src/redux/reducers/wallet.js

					
				@ -9,0 +14,4 @@

				  result: any,

				};

				type WalletState = {

neb-b (Migrated from github.com) commented

2018-07-25 03:47:53 +02:00

👍

Sign in to join this conversation.

No reviewers

akinwale

neb-b

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#59