LBRYCommunity/lbry-redux
1
0
Fork 0
Code Issues 5 Pull requests 6 Projects Releases Packages Wiki Activity

User history #64

Merged
daovist merged 7 commits from user-history into master 2018-09-04 19:26:03 +02:00
Conversation 1 Commits 7 Files changed 7 +73 -352
daovist commented 2018-08-02 16:59:00 +02:00 (Migrated from github.com)
Copy link

See lbryio/lbry-desktop/issue/1009

  • add actions for recording history
  • rename position tracking actions
  • add UserHistoryPage to My LBRY in sidebar
  • fix flow errors
See [lbryio/lbry-desktop/issue/1009](https://github.com/lbryio/lbry-desktop/issues/1009) - [x] add actions for recording history - [x] rename position tracking actions - [x] add `UserHistoryPage` to `My LBRY` in sidebar - [x] fix flow errors
neb-b (Migrated from github.com) approved these changes 2018-08-02 19:52:09 +02:00
neb-b (Migrated from github.com) left a comment
Copy link

One comment

One comment
src/constants/action_types.js
@ -86,2 +85,4 @@
export const FETCH_BLACK_LISTED_CONTENT_FAILED = 'FETCH_BLACK_LISTED_CONTENT_FAILED';
export const BLACK_LISTED_CONTENT_SUBSCRIBE = 'BLACK_LISTED_CONTENT_SUBSCRIBE';
export const SET_PLAYING_URI = 'SET_PLAYING_URI';
export const SET_CONTENT_POSITION = 'SET_CONTENT_POSITION';
neb-b (Migrated from github.com) commented 2018-08-02 19:51:58 +02:00
Copy link

Do we need SET_PLAYING_URI if we have MEDIA_PLAY? Can that be used to set the same values?

Do we need `SET_PLAYING_URI` if we have `MEDIA_PLAY`? Can that be used to set the same values?
daovist (Migrated from github.com) reviewed 2018-08-03 15:21:32 +02:00
src/constants/action_types.js
@ -86,2 +85,4 @@
export const FETCH_BLACK_LISTED_CONTENT_FAILED = 'FETCH_BLACK_LISTED_CONTENT_FAILED';
export const BLACK_LISTED_CONTENT_SUBSCRIBE = 'BLACK_LISTED_CONTENT_SUBSCRIBE';
export const SET_PLAYING_URI = 'SET_PLAYING_URI';
export const SET_CONTENT_POSITION = 'SET_CONTENT_POSITION';
daovist (Migrated from github.com) commented 2018-08-03 15:21:32 +02:00
Copy link

I forgot to remove MEDIA_PLAY from this repo. I'll do so now and push...

I forgot to remove `MEDIA_PLAY` from this repo. I'll do so now and push...
kauffj (Migrated from github.com) reviewed 2018-08-03 16:33:08 +02:00
src/redux/selectors/navigation.js
kauffj (Migrated from github.com) commented 2018-08-03 16:33:08 +02:00
Copy link

Aren't these pages app-specific and thus inappropriate for lbry-redux?

Even if is redux appropriate, this is a dangerous/fragile pattern - how would someone changing the name of a page or route know to update this function?

Aren't these pages app-specific and thus inappropriate for lbry-redux? Even if is redux appropriate, this is a dangerous/fragile pattern - how would someone changing the name of a page or route know to update this function?
neb-b (Migrated from github.com) reviewed 2018-08-03 16:42:26 +02:00
src/redux/selectors/navigation.js
neb-b (Migrated from github.com) commented 2018-08-03 16:42:26 +02:00
Copy link

Yeah... This selector should probably live in the app.

Yeah... This selector should probably live in the app.
daovist (Migrated from github.com) reviewed 2018-08-03 16:49:46 +02:00
src/redux/selectors/navigation.js
daovist (Migrated from github.com) commented 2018-08-03 16:49:45 +02:00
Copy link

Agreed.

Agreed.
skhameneh (Migrated from github.com) approved these changes 2018-08-14 05:44:32 +02:00
skhameneh (Migrated from github.com) left a comment
Copy link

Address the pending comments about moving pieces into the app, that aside looks good

Address the pending comments about moving pieces into the app, that aside looks good
neb-b commented 2018-09-04 19:26:17 +02:00 (Migrated from github.com)
Copy link

Moved selectNavLinks into the app

Moved `selectNavLinks` into the app
Sign in to join this conversation.
Reviewers
No reviewers
neb-b
skhameneh
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#64
No description provided.
Delete branch "user-history"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?