LBRYCommunity/lbry-redux
1
0
Fork 0
Code Issues 5 Pull requests 6 Projects Releases Packages Wiki Activity

Move search suggestion logic to selector #67

Merged
neb-b merged 1 commit from autcomplete into master 2018-08-20 03:34:05 +02:00
Conversation 1 Commits 1 Files changed 5 +247 -217
neb-b commented 2018-08-14 22:49:09 +02:00 (Migrated from github.com)
Copy link

Changes

  • Default first suggestion to be a search
  • Most of the search suggestion logic is now in a selector
  • Just pass in the api results to the search reducer with a query key so previous suggestions are preserved when using the backspace/retyping the same query
### Changes - Default first suggestion to be a search - Most of the search suggestion logic is now in a selector - Just pass in the api results to the search reducer with a `query` key so previous suggestions are preserved when using the backspace/retyping the same query
skhameneh (Migrated from github.com) reviewed 2018-08-14 22:49:09 +02:00
akinwale (Migrated from github.com) approved these changes 2018-08-15 22:07:10 +02:00
akinwale (Migrated from github.com) left a comment
Copy link

Looks good.

Looks good.
src/redux/selectors/search.js
@ -40,0 +58,4 @@
// They are probably typing/pasting in a lbry uri
return [
{
value: query,
akinwale (Migrated from github.com) commented 2018-08-15 22:06:43 +02:00
Copy link

Just an idea I had. I was thinking we should have an additional selector called selectLocalSearchSuggestions which could possibly be used in cases where an API call doesn't necessarily have to be made.

Just an idea I had. I was thinking we should have an additional selector called `selectLocalSearchSuggestions` which could possibly be used in cases where an API call doesn't necessarily have to be made.
neb-b (Migrated from github.com) reviewed 2018-08-20 03:33:52 +02:00
src/redux/selectors/search.js
@ -40,0 +58,4 @@
// They are probably typing/pasting in a lbry uri
return [
{
value: query,
neb-b (Migrated from github.com) commented 2018-08-20 03:33:52 +02:00
Copy link

Maybe based on previous searches?

Maybe based on previous searches?
neb-b commented 2018-08-20 03:34:40 +02:00 (Migrated from github.com)
Copy link

@akinwale I'll create a PR to lbry-android after adding this into the app. The changes should be very minor.

@akinwale I'll create a PR to lbry-android after adding this into the app. The changes should be very minor.
👍 1
akinwale (Migrated from github.com) reviewed 2018-08-20 08:29:29 +02:00
src/redux/selectors/search.js
@ -40,0 +58,4 @@
// They are probably typing/pasting in a lbry uri
return [
{
value: query,
akinwale (Migrated from github.com) commented 2018-08-20 08:29:29 +02:00
Copy link

Yeah, that makes sense.

Yeah, that makes sense.
Sign in to join this conversation.
Reviewers
No reviewers
skhameneh
akinwale
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#67
No description provided.
Delete branch "autcomplete"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?