LBRYCommunity/lbry-redux
1
0
Fork 0
Code Issues 5 Pull requests 6 Projects Releases Packages Wiki Activity

Support for lbrynet daemon v0.30.0 #79

Merged
eukreign merged 2 commits from lbrynet30 into master 2018-10-26 20:09:44 +02:00
Conversation 0 Commits 2 Files changed 9 +292 -206
eukreign commented 2018-09-24 07:16:08 +02:00 (Migrated from github.com)
Copy link

Ready for review

Ready for review
👍 2
neb-b (Migrated from github.com) reviewed 2018-10-25 18:20:04 +02:00
src/redux/reducers/claims.js
@ -170,3 +162,4 @@
Object.keys(claimsByUri).forEach((uri) => {
if (claimsByUri[uri] === claimId) {
delete claimsByUri[uri];
}
neb-b (Migrated from github.com) commented 2018-10-25 18:20:04 +02:00
Copy link

This never worked, not sure how the channel selector worked in the first place ¯_(ツ)_/¯

This never worked, not sure how the channel selector worked in the first place ¯\_(ツ)_/¯
kauffj (Migrated from github.com) reviewed 2018-10-25 18:27:46 +02:00
src/redux/reducers/claims.js
@ -170,3 +162,4 @@
Object.keys(claimsByUri).forEach((uri) => {
if (claimsByUri[uri] === claimId) {
delete claimsByUri[uri];
}
kauffj (Migrated from github.com) commented 2018-10-25 18:27:46 +02:00
Copy link

\ you dropped this

\ you dropped this
neb-b (Migrated from github.com) reviewed 2018-10-25 18:30:22 +02:00
src/redux/reducers/claims.js
@ -170,3 +162,4 @@
Object.keys(claimsByUri).forEach((uri) => {
if (claimsByUri[uri] === claimId) {
delete claimsByUri[uri];
}
neb-b (Migrated from github.com) commented 2018-10-25 18:30:22 +02:00
Copy link

Appreciate it ¯\_(ツ)_/¯

Appreciate it ¯\\\_(ツ)_/¯
neb-b (Migrated from github.com) reviewed 2018-10-25 18:55:08 +02:00
src/redux/actions/wallet.js
neb-b (Migrated from github.com) commented 2018-10-25 18:55:08 +02:00
Copy link

The response used to just be a boolean

The response used to just be a boolean
neb-b (Migrated from github.com) reviewed 2018-10-25 18:57:13 +02:00
src/redux/reducers/claims.js
@ -77,2 +69,3 @@
.forEach(pendingClaim => {
.filter((pendingClaim) => byId[pendingClaim.claim_id])
.forEach((pendingClaim) => {
delete pendingById[pendingClaim.claim_id];
neb-b (Migrated from github.com) commented 2018-10-25 18:57:13 +02:00
Copy link

This is probably the biggest change, now we are only looking at confirmations to see if a claim is pending. Before it wouldn't be returned in claim_list_mine until it was confirmed so we had to keep track of it ourselves.

This is probably the biggest change, now we are only looking at `confirmations` to see if a claim is pending. Before it wouldn't be returned in `claim_list_mine` until it was confirmed so we had to keep track of it ourselves.
skhameneh (Migrated from github.com) approved these changes 2018-10-26 19:55:32 +02:00
skhameneh (Migrated from github.com) left a comment
Copy link

Nothing major, just a few optimizations and formatting comments.

As per formatting, extraneous code gets reduced at build time; we can focus on legibility when writing source. (if you were trying to be minimalistic)

Nothing major, just a few optimizations and formatting comments. As per formatting, extraneous code gets reduced at build time; we can focus on legibility when writing source. (if you were trying to be minimalistic)
src/redux/reducers/claims.js
skhameneh (Migrated from github.com) commented 2018-10-26 19:50:09 +02:00
Copy link

Adjust parens:
claims.filter(claim => claim.type && claim.type.match(/claim|update/))
to claims.filter(claim => ( claim.type && claim.type.match(/claim|update/) ))

Just for legibility

Adjust parens: ```claims.filter(claim => claim.type && claim.type.match(/claim|update/))``` to ```claims.filter(claim => ( claim.type && claim.type.match(/claim|update/) ))``` Just for legibility
skhameneh (Migrated from github.com) commented 2018-10-26 19:50:44 +02:00
Copy link

You can also combine the filter and forEach to prevent lopping twice

You can also combine the filter and forEach to prevent lopping twice
skhameneh (Migrated from github.com) commented 2018-10-26 19:51:34 +02:00
Copy link

Can combine the filter and forEach to prevent looping twice

Can combine the filter and forEach to prevent looping twice
src/redux/selectors/claims.js
@ -31,15 +30,43 @@ export const selectClaimsByUri = createSelector(selectState, selectClaimsById, (
export const selectAllClaimsByChannel = createSelector(
selectState,
skhameneh (Migrated from github.com) commented 2018-10-26 19:53:29 +02:00
Copy link

Would you mind making each arrow fn => have parens since it's multi-line?

export const selectPendingClaims = createSelector(selectState, state => (
  Object.values(state.pendingById || {})
));

Not required and this is subjective to preference, let me know what you think, I find it easier to read.

Would you mind making each arrow fn ` => ` have parens since it's multi-line? ``` export const selectPendingClaims = createSelector(selectState, state => ( Object.values(state.pendingById || {}) )); ``` Not required and this is subjective to preference, let me know what you think, I find it easier to read.
src/redux/selectors/wallet.js
@ -132,3 +132,3 @@
amount,
fee: amount < 0 ? (-1 * tx.fee) / append.length : 0,
fee: amount < 0 ? -1 * tx.fee / append.length : 0,
claim_id: item.claim_id,
skhameneh (Migrated from github.com) commented 2018-10-26 19:54:03 +02:00
Copy link

why remove the parens?

why remove the parens?
neb-b (Migrated from github.com) reviewed 2018-10-26 19:59:05 +02:00
src/redux/selectors/claims.js
@ -31,15 +30,43 @@ export const selectClaimsByUri = createSelector(selectState, selectClaimsById, (
export const selectAllClaimsByChannel = createSelector(
selectState,
neb-b (Migrated from github.com) commented 2018-10-26 19:59:05 +02:00
Copy link

We can add that, I don't really have a preference.

I belive it's a prettier option

We can add that, I don't really have a preference. I belive it's a prettier option
neb-b (Migrated from github.com) reviewed 2018-10-26 20:09:17 +02:00
src/redux/selectors/wallet.js
@ -132,3 +132,3 @@
amount,
fee: amount < 0 ? (-1 * tx.fee) / append.length : 0,
fee: amount < 0 ? -1 * tx.fee / append.length : 0,
claim_id: item.claim_id,
neb-b (Migrated from github.com) commented 2018-10-26 20:09:16 +02:00
Copy link

That's just prettier doing it's thing I belive. Although I'm not sure why that is happening now. It should have been run on that file.

That's just prettier doing it's thing I belive. Although I'm not sure why that is happening now. It should have been run on that file.
Sign in to join this conversation.
Reviewers
No reviewers
skhameneh
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#79
No description provided.
Delete branch "lbrynet30"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?