LBRYCommunity/lbry-redux
1
0
Fork 0
Code Issues 5 Pull requests 6 Projects Releases Packages Wiki Activity

modifications for persisting fileList sort #87

Merged
jessopb merged 1 commit from fileListSort into master 2018-10-23 18:56:32 +02:00
Conversation 1 Commits 1 Files changed 8 +240 -122
jessopb commented 2018-10-22 18:26:14 +02:00 (Migrated from github.com)
Copy link
No description provided.
neb-b (Migrated from github.com) requested changes 2018-10-22 19:56:08 +02:00
neb-b (Migrated from github.com) left a comment
Copy link

This looks good. I think we should be using constants for all of the values though.

This looks good. I think we should be using constants for all of the values though.
src/redux/actions/file_info.js
neb-b (Migrated from github.com) commented 2018-10-22 19:54:46 +02:00
Copy link

This should still be called data

This should still be called `data`
src/redux/reducers/file_info.js
@ -1,9 +1,12 @@
import * as ACTIONS from 'constants/action_types';
neb-b (Migrated from github.com) commented 2018-10-22 19:55:06 +02:00
Copy link

The options for sorting should be constants

The options for sorting should be constants
src/redux/reducers/file_info.js
neb-b (Migrated from github.com) commented 2018-10-22 19:55:34 +02:00
Copy link

The pages should be constants too.

The pages should be constants too.
neb-b (Migrated from github.com) commented 2018-10-22 19:55:43 +02:00
Copy link

That are exported so the app can use them

That are exported so the app can use them
jessopb (Migrated from github.com) reviewed 2018-10-23 03:20:13 +02:00
src/redux/reducers/file_info.js
jessopb (Migrated from github.com) commented 2018-10-23 03:20:13 +02:00
Copy link

Roger. I wouldn't mind centralizing the page -> state dictionary too, but I don't know if it's necessary, or the right place to put it.

Roger. I wouldn't mind centralizing the page -> state dictionary too, but I don't know if it's necessary, or the right place to put it.
neb-b (Migrated from github.com) reviewed 2018-10-23 04:41:22 +02:00
src/constants/pages.js
neb-b (Migrated from github.com) commented 2018-10-23 04:41:21 +02:00
Copy link

This should just be published

This should just be `published`
neb-b commented 2018-10-23 04:42:41 +02:00 (Migrated from github.com)
Copy link

@jessopb Looks good. I would just make sure we are using the same page values as the app is using. Looks like there are a few differences
https://github.com/lbryio/lbry-desktop/blob/master/src/renderer/component/router/view.jsx#L38-L57

@jessopb Looks good. I would just make sure we are using the same page values as the app is using. Looks like there are a few differences https://github.com/lbryio/lbry-desktop/blob/master/src/renderer/component/router/view.jsx#L38-L57
Sign in to join this conversation.
Reviewers
No reviewers
neb-b
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#87
No description provided.
Delete branch "fileListSort"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?