LBRYCommunity/lbry-redux
1
0
Fork 0
Code Issues 5 Pull requests 6 Projects Releases Packages Wiki Activity

Updates comment-related redux code to support sdk version 0.53.0 #259

Merged
osilkin98 merged 18 commits from sdk-update into master 2020-01-23 21:50:02 +01:00
Conversation 0 Commits 18 Files changed 19 +55
3 changed files with 55 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 7c55a9e0f5 - Show all commits

9
dist/bundle.es.js vendored
View file

@ -377,6 +377,15 @@ var action_types = /*#__PURE__*/Object.freeze({
COMMENT_CREATE_STARTED: COMMENT_CREATE_STARTED,
COMMENT_CREATE_COMPLETED: COMMENT_CREATE_COMPLETED,
COMMENT_CREATE_FAILED: COMMENT_CREATE_FAILED,
COMMENT_ABANDON_STARTED: COMMENT_ABANDON_STARTED,
COMMENT_ABANDON_COMPLETED: COMMENT_ABANDON_COMPLETED,
COMMENT_ABANDON_FAILED: COMMENT_ABANDON_FAILED,
COMMENT_HIDE_STARTED: COMMENT_HIDE_STARTED,
COMMENT_HIDE_COMPLETED: COMMENT_HIDE_COMPLETED,
COMMENT_HIDE_FAILED: COMMENT_HIDE_FAILED,
COMMENT_EDIT_STARTED: COMMENT_EDIT_STARTED,
COMMENT_EDIT_COMPLETED: COMMENT_EDIT_COMPLETED,
COMMENT_EDIT_FAILED: COMMENT_EDIT_FAILED,
FILE_LIST_STARTED: FILE_LIST_STARTED,
FILE_LIST_SUCCEEDED: FILE_LIST_SUCCEEDED,
FETCH_FILE_INFO_STARTED: FETCH_FILE_INFO_STARTED,

9
src/constants/action_types.js
View file

@ -111,6 +111,15 @@ export const COMMENT_LIST_FAILED = 'COMMENT_LIST_FAILED';
export const COMMENT_CREATE_STARTED = 'COMMENT_CREATE_STARTED';
export const COMMENT_CREATE_COMPLETED = 'COMMENT_CREATE_COMPLETED';
export const COMMENT_CREATE_FAILED = 'COMMENT_CREATE_FAILED';
export const COMMENT_ABANDON_STARTED = 'COMMENT_ABANDON_STARTED';
export const COMMENT_ABANDON_COMPLETED = 'COMMENT_ABANDON_COMPLETED';
export const COMMENT_ABANDON_FAILED = 'COMMENT_ABANDON_FAILED';
export const COMMENT_EDIT_STARTED = 'COMMENT_EDIT_STARTED';
export const COMMENT_EDIT_COMPLETED = 'COMMENT_EDIT_COMPLETED';
export const COMMENT_EDIT_FAILED = 'COMMENT_EDIT_FAILED';
export const COMMENT_HIDE_STARTED = 'COMMENT_HIDE_STARTED';
export const COMMENT_HIDE_COMPLETED = 'COMMENT_HIDE_COMPLETED';
export const COMMENT_HIDE_FAILED = 'COMMENT_HIDE_FAILED';
// Files
export const FILE_LIST_STARTED = 'FILE_LIST_STARTED';

37
src/redux/reducers/comments.js
View file

@ -6,6 +6,7 @@ const defaultState: CommentsState = {
byId: {},
commentsByUri: {},
isLoading: false,
myComments: undefined,
};
export const commentReducer = handleActions(
@ -58,6 +59,42 @@ export const commentReducer = handleActions(
...state,
isLoading: false,
}),
[ACTIONS.COMMENT_ABANDON_STARTED]: (state: CommentsState, action: any) => ({
...state,
isLoading: true,
}),
[ACTIONS.COMMENT_ABANDON_COMPLETED]: (state: CommentsState, action: any) => ({
...state,
isLoading: false,
}),
[ACTIONS.COMMENT_ABANDON_FAILED]: (state: CommentsState, action: any) => ({
...state,
isLoading: false,
}),
[ACTIONS.COMMENT_EDIT_STARTED]: (state: CommentsState, action: any) => ({
...state,
isLoading: true,
}),
[ACTIONS.COMMENT_EDIT_COMPLETED]: (state: CommentsState, action: any) => ({
...state,
isLoading: false,
neb-b commented 2020-01-16 17:14:52 +01:00 (Migrated from github.com)
Review
Copy link

I think this part can just be replaced with

delete commentById[comment_id]
I think this part can just be replaced with ``` delete commentById[comment_id] ```
neb-b commented 2020-01-16 17:15:03 +01:00 (Migrated from github.com)
Review
Copy link

No need to loop through it.

No need to loop through it.
}),
[ACTIONS.COMMENT_EDIT_FAILED]: (state: CommentsState, action: any) => ({
...state,
isLoading: false,
}),
[ACTIONS.COMMENT_HIDE_STARTED]: (state: CommentsState, action: any) => ({
...state,
isLoading: true,
}),
[ACTIONS.COMMENT_HIDE_COMPLETED]: (state: CommentsState, action: any) => ({
...state,
isLoading: false,
}),
[ACTIONS.COMMENT_HIDE_FAILED]: (state: CommentsState, action: any) => ({
...state,
isLoading: false,
}),
},
defaultState
);