Be nice and mark them as virutal

This commit is contained in:
hofmockel 2014-04-01 21:31:03 +02:00
parent dca6b61bbb
commit 98301a8ccb
4 changed files with 16 additions and 16 deletions

View file

@ -26,7 +26,7 @@ namespace py_rocks {
compare_callback(compare_callback) compare_callback(compare_callback)
{} {}
int Compare(const Slice& a, const Slice& b) const { virtual int Compare(const Slice& a, const Slice& b) const {
string error_msg; string error_msg;
int val; int val;
@ -43,12 +43,12 @@ namespace py_rocks {
return val; return val;
} }
const char* Name() const { virtual const char* Name() const {
return this->name.c_str(); return this->name.c_str();
} }
void FindShortestSeparator(string* start, const Slice& limit) const {} virtual void FindShortestSeparator(string* start, const Slice& limit) const {}
void FindShortSuccessor(string* key) const {} virtual void FindShortSuccessor(string* key) const {}
void set_info_log(std::shared_ptr<Logger> info_log) { void set_info_log(std::shared_ptr<Logger> info_log) {
this->info_log = info_log; this->info_log = info_log;

View file

@ -36,7 +36,7 @@ namespace py_rocks {
key_may_match_callback(key_may_match_callback) key_may_match_callback(key_may_match_callback)
{} {}
void virtual void
CreateFilter(const Slice* keys, int n, std::string* dst) const { CreateFilter(const Slice* keys, int n, std::string* dst) const {
string error_msg; string error_msg;
@ -53,7 +53,7 @@ namespace py_rocks {
} }
} }
bool virtual bool
KeyMayMatch(const Slice& key, const Slice& filter) const { KeyMayMatch(const Slice& key, const Slice& filter) const {
string error_msg; string error_msg;
bool val; bool val;
@ -71,7 +71,7 @@ namespace py_rocks {
return val; return val;
} }
const char* Name() const { virtual const char* Name() const {
return this->name.c_str(); return this->name.c_str();
} }

View file

@ -28,7 +28,7 @@ namespace py_rocks {
merge_callback(merge_callback) merge_callback(merge_callback)
{} {}
bool Merge( virtual bool Merge(
const Slice& key, const Slice& key,
const Slice* existing_value, const Slice* existing_value,
const Slice& value, const Slice& value,
@ -44,7 +44,7 @@ namespace py_rocks {
logger); logger);
} }
const char* Name() const { virtual const char* Name() const {
return this->name.c_str(); return this->name.c_str();
} }
@ -85,7 +85,7 @@ namespace py_rocks {
partial_merge_callback(partial_merge_callback) partial_merge_callback(partial_merge_callback)
{} {}
bool FullMerge( virtual bool FullMerge(
const Slice& key, const Slice& key,
const Slice* existing_value, const Slice* existing_value,
const deque<string>& operand_list, const deque<string>& operand_list,
@ -101,7 +101,7 @@ namespace py_rocks {
logger); logger);
} }
bool PartialMerge ( virtual bool PartialMerge (
const Slice& key, const Slice& key,
const Slice& left_operand, const Slice& left_operand,
const Slice& right_operand, const Slice& right_operand,
@ -117,7 +117,7 @@ namespace py_rocks {
logger); logger);
} }
const char* Name() const { virtual const char* Name() const {
return this->name.c_str(); return this->name.c_str();
} }

View file

@ -42,11 +42,11 @@ namespace py_rocks {
in_range_callback(in_range_callback) in_range_callback(in_range_callback)
{} {}
const char* Name() const { virtual const char* Name() const {
return this->name.c_str(); return this->name.c_str();
} }
Slice Transform(const Slice& src) const { virtual Slice Transform(const Slice& src) const {
string error_msg; string error_msg;
Slice val; Slice val;
@ -62,7 +62,7 @@ namespace py_rocks {
return val; return val;
} }
bool InDomain(const Slice& src) const { virtual bool InDomain(const Slice& src) const {
string error_msg; string error_msg;
bool val; bool val;
@ -78,7 +78,7 @@ namespace py_rocks {
return val; return val;
} }
bool InRange(const Slice& dst) const { virtual bool InRange(const Slice& dst) const {
string error_msg; string error_msg;
bool val; bool val;