Require cython in the build-system #2

Merged

kevinkjt2000 merged 1 commit from build-requires-cython into master

2022-03-09 17:59:39 +01:00

kevinkjt2000 commented

2022-01-19 00:36:46 +01:00

(Migrated from github.com)

I was confused seeing setuptools in a install_requires. Usually, that section is for dependencies that a python project wants available at runtime. I did not see anywhere in the code (other than setup.py) where setuptools is imported, so install_requires is removed entirely.

I'm taking a bit of a leap here in using https://setuptools.pypa.io/en/latest/history.html#v58-3-0 to begin making use of PEP 518, but seeing as how this project is python 3.7+, it should be okay. In fact, it should probably be https://setuptools.pypa.io/en/latest/history.html#v59-7-0 or higher.

The rationale for this change is to be able to pip install a package that depends on this rocksdb package. Failing to install cython first on modern versions of setuptools without this PEP 518 pyproject.toml.

I was confused seeing `setuptools` in a `install_requires`. Usually, that section is for dependencies that a python project wants available at runtime. I did not see anywhere in the code (other than setup.py) where `setuptools` is imported, so install_requires is removed entirely. I'm taking a bit of a leap here in using https://setuptools.pypa.io/en/latest/history.html#v58-3-0 to begin making use of PEP 518, but seeing as how this project is python 3.7+, it should be okay. In fact, it should probably be https://setuptools.pypa.io/en/latest/history.html#v59-7-0 or higher. The rationale for this change is to be able to pip install a package that depends on this rocksdb package. Failing to install cython first on modern versions of setuptools without this PEP 518 pyproject.toml.