Tipbot creating extra accounts for users, which they cannot access. #5

New issue

Closed

opened 2017-12-14 22:49:46 +01:00 by filipnyquist · 3 comments

filipnyquist commented

2017-12-14 22:49:46 +01:00

(Migrated from github.com)

The problem could be caused by this:
5c21d0fd22/bot/modules/tipbot.js (L106)

The problem could be caused by this: https://github.com/lbryio/lbry-tipbot/blob/5c21d0fd22511152a3bace3635b8d3ddadfc46ab/bot/modules/tipbot.js#L106

nikooo777 commented

2017-12-19 02:09:42 +01:00

(Migrated from github.com)

The issue is most likely that we're using members rather than users
https://discord.js.org/#/docs/main/stable/class/GuildMember
https://discord.js.org/#/docs/main/stable/class/User

also we should be using the property .id of said user, this way whatever username they use, it won't matter.

Can you confirm?

The issue is most likely that we're using `members` rather than `users` https://discord.js.org/#/docs/main/stable/class/GuildMember https://discord.js.org/#/docs/main/stable/class/User also we should be using the property .id of said user, this way whatever username they use, it won't matter. Can you confirm?

ProfessorDey commented

2017-12-25 21:50:06 +01:00

(Migrated from github.com)

Right, that's my mistake for not understanding how GuildMembers and Users were different, as the documentation doesn't do the best job of clarifying, so sorry about that.

Also my bad using let, I'm just an idiot in this case, saw the code above where tipper was defined and so used that instead of var.

Have put up pull request on here that should fix it, though it'll still require manually refunding the money from the accidentally created accounts. Link: https://github.com/lbryio/lbry-tipbot/pull/9

Right, that's my mistake for not understanding how GuildMembers and Users were different, as the documentation doesn't do the best job of clarifying, so sorry about that. Also my bad using let, I'm just an idiot in this case, saw the code above where tipper was defined and so used that instead of var. Have put up pull request on here that should fix it, though it'll still require manually refunding the money from the accidentally created accounts. Link: https://github.com/lbryio/lbry-tipbot/pull/9

ProfessorDey commented

2018-01-03 23:04:48 +01:00

(Migrated from github.com)

Have updated PR to match the latest commit of my other PR.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-tipbot#5

No description provided.

Rows
Columns