Fixing Duplicate Tipbot Account Issue #9

Merged
ProfessorDey merged 1 commit from patch-3 into master 2018-01-03 01:23:49 +01:00
ProfessorDey commented 2017-12-25 21:43:44 +01:00 (Migrated from github.com)

Misunderstood the use of GuildMember in Discord.js due to vague documentation, resulting in tipbot accounts being created accidentally due to getting the wrong Snowflake for the user. The function now takes the user.id of the recipient, preformated to match the tipper, with appropriately adjusted references to the user.

Hopefully this should fix the issues being had though manual recovery of the currency in the accidentally created accounts will still be required. Sorry for the trouble.

Misunderstood the use of GuildMember in Discord.js due to vague documentation, resulting in tipbot accounts being created accidentally due to getting the wrong Snowflake for the user. The function now takes the user.id of the recipient, preformated to match the tipper, with appropriately adjusted references to the user. Hopefully this should fix the issues being had though manual recovery of the currency in the accidentally created accounts will still be required. Sorry for the trouble.
nikooo777 (Migrated from github.com) reviewed 2017-12-25 21:43:44 +01:00
filipnyquist (Migrated from github.com) reviewed 2017-12-25 21:43:44 +01:00
ProfessorDey commented 2017-12-26 00:34:55 +01:00 (Migrated from github.com)

Also forgot that I included the code that patches the private tipping mode to actually only message the user once if they tip themselves. Did it without thinking, so sorry for any confusion there

Also forgot that I included the code that patches the private tipping mode to actually only message the user once if they tip themselves. Did it without thinking, so sorry for any confusion there
nikooo777 commented 2018-01-03 01:24:06 +01:00 (Migrated from github.com)

checked and LGTM!
thanks

checked and LGTM! thanks
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-tipbot#9
No description provided.