Rename this repo #17

New issue

Closed

opened 2018-07-03 17:09:55 +02:00 by kauffj · 9 comments

kauffj commented

2018-07-03 17:09:55 +02:00

(Migrated from github.com)

lbry.go is a confusing name for what this does.

Also, should this be public?

`lbry.go` is a confusing name for what this does. Also, should this be public?

tiger5226 commented

2018-07-07 07:28:40 +02:00

(Migrated from github.com)

please let me know if we do this as Chainquery depends on its packages.

kauffj commented

2018-07-09 23:24:22 +02:00

(Migrated from github.com)

@tiger5226 what's in here that Chainquery relies on? Should it be split out?

It's possible I'm not understanding everything this repo does. In my head, this is the "YouTube sync repo"

@tiger5226 what's in here that Chainquery relies on? Should it be split out? It's possible I'm not understanding everything this repo does. In my head, this is the "YouTube sync repo"

tiger5226 commented

2018-07-10 01:13:24 +02:00

(Migrated from github.com)

packages = [
    "api",
    "errors",
    "jsonrpc",
    "lbrycrd",
    "null",
    "querytools",
    "stop",
    "travis",
    "util",
    "validator"
  ]

We use a lot of stuff. So does internal-apis. It is the repo grin has designated as the Go repo for all things LBRY. So if anything is shared between go apps it goes here. Specifically from the gopkg.lock file ``` packages = [ "api", "errors", "jsonrpc", "lbrycrd", "null", "querytools", "stop", "travis", "util", "validator" ] ```

kauffj commented

2018-07-10 21:59:41 +02:00

(Migrated from github.com)

So obviously this repo should be named lbry-libraries.go.

So obviously this repo should be named `lbry-libraries.go`.

tiger5226 commented

2018-07-11 00:12:24 +02:00

(Migrated from github.com)

I strongly believe any lbry.go repo should be reserved for the daemon rewrite as that is what any one would think this repo was.

Additionally, lbryschema.go, and reflector.go use this as well I believe.

how about bookshelf.go? Stays with the LBRY theme and signifies lots of choices. No strong preference, just thought it was a playful name. @lyoshenka remarked "The swiss army knife" previously, although I think he removed that for the same reasons you want to rename the repo. I strongly believe any lbry.go repo should be reserved for the daemon rewrite as that is what any one would think this repo was. Additionally, lbryschema.go, and reflector.go use this as well I believe.

alyssaoc commented

2018-08-20 22:39:57 +02:00

(Migrated from github.com)

@kauffj and @lyoshenka is this something you want to tackle? It won't be easy, but sooner rather than later. Perhaps a better readme?

kauffj commented

2018-08-20 22:45:26 +02:00

(Migrated from github.com)

This is for @lyoshenka only. I noticed he already started splitting some parts of this repo out.

lyoshenka commented

2018-08-27 18:42:41 +02:00

(Migrated from github.com)

ill rename this eventually