Add singular account_list method, account_remove #60

Merged

anbsky merged 8 commits from feature/account_remove into master

2019-05-24 17:06:05 +02:00

anbsky commented

2019-05-21 19:12:53 +02:00

(Migrated from github.com)

Added a few methods required for lbrytv:

account_remove
account_list with account_id argument (the SDK response structure is different when this argument is supplied, hence a separate method)

Added a few methods required for lbrytv: - account_remove - account_list with account_id argument (the SDK response structure is different when this argument is supplied, hence a separate method)

nikooo777 (Migrated from github.com) approved these changes 2019-05-23 13:38:51 +02:00

nikooo777 (Migrated from github.com) left a comment

check comments first, otherwise LGTM

extras/jsonrpc/daemon.go

nikooo777 (Migrated from github.com) commented

2019-05-23 13:35:00 +02:00

this is rather useless because you're going from a struct to a map through a serializer when in fact you can just define the map on the go:

map[string]interface{}{
		"account_name": accountName,
    "single_key": singleKey,
	})

this is rather useless because you're going from a struct to a map through a serializer when in fact you can just define the map on the go: ``` map[string]interface{}{ "account_name": accountName, "single_key": singleKey, }) ```

extras/jsonrpc/daemon_types.go

nikooo777 (Migrated from github.com) commented

2019-05-23 13:37:46 +02:00

why were some fields removed? https://lbry.tech/api/sdk#account_create