LBRYCommunity/lbry.go
1
0
Fork 0
Code Issues 5 Pull requests Projects Releases 46 Packages Wiki Activity

Add updated structure for response api call based on SDK 38 release. #61

Merged
tiger5226 merged 1 commit from go_sdk38_client_updates into master 2019-07-10 03:47:30 +02:00
Conversation 1 Commits 1 Files changed 1 +32 -28
tiger5226 commented 2019-06-24 06:29:50 +02:00 (Migrated from github.com)
Copy link
No description provided.
anbsky (Migrated from github.com) reviewed 2019-06-24 10:57:31 +02:00
extras/jsonrpc/daemon_types.go
anbsky (Migrated from github.com) commented 2019-06-24 10:57:31 +02:00
Copy link

Naming this something like ClaimMeta would be beneficial

Naming this something like `ClaimMeta` would be beneficial
anbsky commented 2019-06-24 11:16:52 +02:00 (Migrated from github.com)
Copy link

My streaming tests using this code seem to be passing well, thanks 👍

My streaming tests using this code seem to be passing well, thanks 👍
tiger5226 (Migrated from github.com) reviewed 2019-06-25 02:02:19 +02:00
extras/jsonrpc/daemon_types.go
tiger5226 (Migrated from github.com) commented 2019-06-25 02:02:19 +02:00
Copy link

I would, but I think it more valuable to align with the response from the SDK which uses meta. All of these fields map to the SDK response. @eukreign why the name meta instead of something like claim_meta? I think @sayplastic has a point. Just curious.

I would, but I think it more valuable to align with the response from the [SDK](https://lbry.tech/api/sdk#resolve) which uses `meta`. All of these fields map to the SDK response. @eukreign why the name `meta` instead of something like `claim_meta`? I think @sayplastic has a point. Just curious.
eukreign (Migrated from github.com) reviewed 2019-06-25 03:06:05 +02:00
extras/jsonrpc/daemon_types.go
eukreign (Migrated from github.com) commented 2019-06-25 03:06:05 +02:00
Copy link

In JSON it's meta because it's already inside of the claim value, so it would be redundant to say claim. Since you're working with a flatter namespace you should definitely call it ClaimMeta here to not be ambiguous.

In JSON it's `meta` because it's already inside of the claim value, so it would be redundant to say `claim`. Since you're working with a flatter namespace you should definitely call it ClaimMeta here to not be ambiguous.
eukreign (Migrated from github.com) reviewed 2019-06-25 03:07:52 +02:00
extras/jsonrpc/daemon_types.go
eukreign (Migrated from github.com) commented 2019-06-25 03:07:52 +02:00
Copy link

@tiger5226 @sayplastic Also, just fyi, the metadata is sent from wallet server to the client via this protobuf, which is called ClaimMeta: https://github.com/lbryio/types/blob/master/v2/proto/result.proto#L22

@tiger5226 @sayplastic Also, just fyi, the metadata is sent from wallet server to the client via this protobuf, which is called `ClaimMeta`: https://github.com/lbryio/types/blob/master/v2/proto/result.proto#L22
nikooo777 (Migrated from github.com) approved these changes 2019-07-02 03:32:19 +02:00
nikooo777 (Migrated from github.com) left a comment
Copy link

LGTM

LGTM
extras/jsonrpc/daemon_types.go
nikooo777 (Migrated from github.com) commented 2019-07-02 03:31:12 +02:00
Copy link

int? are you sure?

int? are you sure?
tiger5226 (Migrated from github.com) reviewed 2019-07-02 03:34:16 +02:00
extras/jsonrpc/daemon_types.go
tiger5226 (Migrated from github.com) commented 2019-07-02 03:34:16 +02:00
Copy link

I based it off of a different timestamp elsewhere. I checked and you had added that timestamp. So the real question is..."are you sure?". #ITrustNiko

I based it off of a different timestamp elsewhere. I checked and you had added that timestamp. So the real question is..."are you sure?". #ITrustNiko
eukreign (Migrated from github.com) reviewed 2019-07-02 03:42:45 +02:00
extras/jsonrpc/daemon_types.go
eukreign (Migrated from github.com) commented 2019-07-02 03:42:45 +02:00
Copy link

that value comes directly from the blockchain header file, it's a 32 bit unsigned integer:
https://en.bitcoin.it/wiki/Protocol_documentation#Block_Headers

that value comes directly from the blockchain header file, it's a 32 bit unsigned integer: https://en.bitcoin.it/wiki/Protocol_documentation#Block_Headers
nikooo777 (Migrated from github.com) reviewed 2019-07-08 13:18:49 +02:00
extras/jsonrpc/daemon_types.go
nikooo777 (Migrated from github.com) commented 2019-07-08 13:18:49 +02:00
Copy link

okay, the default is 32bit in go so we're good. Not unsigned but not a big deal.

okay, the default is 32bit in go so we're good. Not unsigned but not a big deal.
Sign in to join this conversation.
Reviewers
No reviewers
nikooo777
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry.go#61
No description provided.
Delete branch "go_sdk38_client_updates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?