V2 update #75
No reviewers
Labels
No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry.go#75
Loading…
Reference in a new issue
No description provided.
Delete branch "replace-v2"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
lbry.go depends on itself, if imports to itself aren't upgraded to v2 it will use a weird mix of dependencies.
This PR ports every usage to V2.
Additionally, several modules were updated, I updated them all (skipped btcd because it's still broken)
I tested this with ytsync and it still works fine. jsonrpc tests also pass (though the wallet related ones added by Andrey didn't pass, probably due to differences in chains?).
Thanks for doing the work I should've done! I fixed
TestClient_WalletList
which was failing for me, others seem to run fine. All in all looks good to me.