LBRYCommunity/lbry.go
1
0
Fork 0
Code Issues 5 Pull requests Projects Releases 46 Packages Wiki Activity

Add utility functions from hub #89

Merged
jeffreypicard merged 2 commits from add_utility_funcs into master 2021-06-25 16:50:58 +02:00
Conversation 0 Commits 2 Files changed 1 +41 -1
jeffreypicard commented 2021-06-18 06:00:53 +02:00 (Migrated from github.com)
Copy link
No description provided.
lyoshenka (Migrated from github.com) reviewed 2021-06-23 15:52:15 +02:00
extras/util/strings.go
lyoshenka (Migrated from github.com) commented 2021-06-23 15:52:15 +02:00
Copy link

this should be called NormalizeName, since its specific to claim names

this should be called NormalizeName, since its specific to claim names
lyoshenka (Migrated from github.com) requested changes 2021-06-23 15:54:46 +02:00
lyoshenka (Migrated from github.com) left a comment
Copy link

all these functions could use just a bit of documentation about what they're for

all these functions could use just a bit of documentation about what they're for
extras/util/strings.go
lyoshenka (Migrated from github.com) commented 2021-06-23 15:53:07 +02:00
Copy link

name this TxidToHash?

name this TxidToHash?
lyoshenka (Migrated from github.com) commented 2021-06-23 15:53:32 +02:00
Copy link

this should use the ReverseBytes function in this very file :-)

this should use the ReverseBytes function in this very file :-)
lyoshenka (Migrated from github.com) commented 2021-06-23 15:53:41 +02:00
Copy link

ReverseBytes()

ReverseBytes()
lyoshenka (Migrated from github.com) commented 2021-06-23 15:54:23 +02:00
Copy link

maybe call this TxHashToTxid()? since these are in lbry.go now, its a generic location and it's not clear what they're for

maybe call this TxHashToTxid()? since these are in lbry.go now, its a generic location and it's not clear what they're for
jeffreypicard (Migrated from github.com) reviewed 2021-06-23 19:09:49 +02:00
extras/util/strings.go
jeffreypicard (Migrated from github.com) commented 2021-06-23 19:09:48 +02:00
Copy link

Yeah makes sense. I'm also taking a look at this function and it's only used in a print statement, nothing really relies on it, but if I understand the semantic of copy, I'm not sure it works as intended, it's copying the hash to t, then reversing the bytes on the hash, but then encoding and returning t, I think it wants to reverse the bytes on t?

Yeah makes sense. I'm also taking a look at this function and it's only used in a print statement, nothing really relies on it, but if I understand the semantic of copy, I'm not sure it works as intended, it's copying the hash to t, then reversing the bytes on the hash, but then encoding and returning t, I think it wants to reverse the bytes on t?
lyoshenka (Migrated from github.com) reviewed 2021-06-23 20:01:40 +02:00
extras/util/strings.go
lyoshenka (Migrated from github.com) commented 2021-06-23 20:01:40 +02:00
Copy link

yea that's weird. it should reverse t. the whole point is that the reverse does it in-place so we copy to avoid messing with the original

yea that's weird. it should reverse t. the whole point is that the reverse does it in-place so we copy to avoid messing with the original
lyoshenka (Migrated from github.com) reviewed 2021-06-23 20:03:21 +02:00
extras/util/strings.go
lyoshenka (Migrated from github.com) commented 2021-06-23 20:03:21 +02:00
Copy link

here's what should really happen: ReverseBytes should stop reversing in place. it should return a copy. or alternatively, it should be called ReverseInPlace or something. otherwise its very surprising.

here's what should really happen: ReverseBytes should stop reversing in place. it should return a copy. or alternatively, it should be called ReverseInPlace or something. otherwise its very surprising.
Sign in to join this conversation.
Reviewers
No reviewers
lyoshenka
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry.go#89
No description provided.
Delete branch "add_utility_funcs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?