LBRYCommunity/lbry.tech
1
0
Fork 0
Code Issues 13 Pull requests 8 Projects Releases Packages Wiki Activity

HTML tags are now escaped in GitHub issue titles

Browse source
This commit is contained in:
ポール ウェッブ 2019-01-17 15:24:27 -06:00
parent 18c12ddf74
commit c2af87b8b3
1 changed files with 15 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
app/helpers/github.js
View file

@ -15,6 +15,16 @@ const redis = require("redis");
const messageSlack = local("/app/helpers/slack"); const messageSlack = local("/app/helpers/slack");
const relativeDate = local("/app/modules/relative-date"); const relativeDate = local("/app/modules/relative-date");
String.prototype.escape = function() {
const tagsToReplace = {
"&": "&",
"<": "&lt;",
">": "&gt;"
};
return this.replace(/[&<>]/g, tag => tagsToReplace[tag] || tag);
};
// R E D I S // R E D I S
let client; let client;
@ -132,7 +142,7 @@ function generateEvent(event) {
rel="noopener noreferrer" rel="noopener noreferrer"
target="_blank" target="_blank"
title="View this comment on GitHub" title="View this comment on GitHub"
>${event.payload.issue.title}</a></em> in >${event.payload.issue.title.escape()}</a></em> in
`; `;
} else { } else {
return ` return `
@ -143,7 +153,7 @@ function generateEvent(event) {
rel="noopener noreferrer" rel="noopener noreferrer"
target="_blank" target="_blank"
title="View this comment on GitHub" title="View this comment on GitHub"
>${event.payload.issue.title}</a></em> in >${event.payload.issue.title.escape()}</a></em> in
`; `;
} }
@ -161,7 +171,7 @@ function generateEvent(event) {
rel="noopener noreferrer" rel="noopener noreferrer"
target="_blank" target="_blank"
title="View this issue on GitHub" title="View this issue on GitHub"
>${event.payload.issue.title}</a></em> in >${event.payload.issue.title.escape()}</a></em> in
`; `;
case "PullRequestEvent": case "PullRequestEvent":
@ -178,7 +188,7 @@ function generateEvent(event) {
rel="noopener noreferrer" rel="noopener noreferrer"
target="_blank" target="_blank"
title="View this pull request on GitHub" title="View this pull request on GitHub"
>${event.payload.pull_request.title}</a></em> in >${event.payload.pull_request.title.escape()}</a></em> in
`; `;
case "PullRequestReviewCommentEvent": case "PullRequestReviewCommentEvent":
@ -195,7 +205,7 @@ function generateEvent(event) {
rel="noopener noreferrer" rel="noopener noreferrer"
target="_blank" target="_blank"
title="View this comment on GitHub" title="View this comment on GitHub"
>${event.payload.pull_request.title}</a></em> in >${event.payload.pull_request.title.escape()}</a></em> in
`; `;
case "PushEvent": case "PushEvent":