Create daemon-settings.md #136

Merged

tzarebczan merged 3 commits from daemon-settings into master

2018-08-31 04:35:26 +02:00

tzarebczan commented

2018-08-24 21:07:08 +02:00

(Migrated from github.com)

Initial attempt at enumerating and explaining available daemon settings

eukreign (Migrated from github.com) reviewed 2018-08-24 21:07:08 +02:00

kauffj (Migrated from github.com) reviewed 2018-08-24 21:07:08 +02:00

jackrobison (Migrated from github.com) reviewed 2018-08-24 21:07:08 +02:00

lyoshenka (Migrated from github.com) approved these changes 2018-08-24 22:35:00 +02:00

lyoshenka (Migrated from github.com) left a comment

This is good. It would be better if conf.py were more readable so we could just link people to that file instead of copy-pasting all the settings here. Then we don't have to keep the two in sync or worry about discrepancies.

This is good. It would be better if `conf.py` were more readable so we could just link people to that file instead of copy-pasting all the settings here. Then we don't have to keep the two in sync or worry about discrepancies.

shyba (Migrated from github.com) approved these changes 2018-08-26 23:46:38 +02:00

documents/resources/daemon-settings.md

shyba (Migrated from github.com) commented

2018-08-24 21:14:45 +02:00

str -> string

shyba (Migrated from github.com) commented

2018-08-24 21:16:43 +02:00

according to the code comment setting to 0 disables that

[according to the code comment](https://github.com/lbryio/lbry/blob/master/lbrynet/conf.py#L243) setting to 0 disables that

shyba (Migrated from github.com) commented

2018-08-24 21:18:26 +02:00

I'm unsure if it accepts all upper, like FALSE

I'm unsure if it accepts all upper, like `FALSE`

tzarebczan commented

2018-08-27 18:04:44 +02:00

(Migrated from github.com)

@lyoshenka agreed, I thought about that when writing it. I don't think we'll have too many changes/additions that it would be a pain to keep in sync.

Will get Victor's changes in and then merge (unless anyone else has issues).

@lyoshenka agreed, I thought about that when writing it. I don't think we'll have too many changes/additions that it would be a pain to keep in sync. Will get Victor's changes in and then merge (unless anyone else has issues).

tzarebczan (Migrated from github.com) reviewed 2018-08-27 18:07:02 +02:00

documents/resources/daemon-settings.md

tzarebczan (Migrated from github.com) commented

2018-08-27 18:07:01 +02:00

I'll make a comment about that. Hopefully this goes away before anyone actually has to use it.