LBRYCommunity/lbry.tech
1
0
Fork 0
Code Issues 13 Pull requests 8 Packages Projects Releases Wiki Activity

Launch-ish #163

Merged
kauffj merged 14 commits from launch into master 2018-10-01 17:21:11 +02:00
Conversation 1 Commits 14 Files changed 32 +376 -320
kauffj commented 2018-10-01 15:22:50 +02:00 (Migrated from github.com)
Copy link
  • Re-wrote content on homepage, contribute, glossary, and more
  • New components for Resources page
  • Headers for API pages
  • Crude, unimplemented, redirection
  • Link grid as a component
  • Remove sitemap
  • Other cleanup / refactoring as I went
- Re-wrote content on homepage, contribute, glossary, and more - New components for Resources page - Headers for API pages - Crude, unimplemented, redirection - Link grid as a component - Remove sitemap - Other cleanup / refactoring as I went
NetOpWibby (Migrated from github.com) reviewed 2018-10-01 15:22:50 +02:00
NetOpWibby (Migrated from github.com) reviewed 2018-10-01 16:16:48 +02:00
app/sass/pages/_api.scss
NetOpWibby (Migrated from github.com) commented 2018-10-01 16:08:05 +02:00
Copy link

Why remove this?

Why remove this?
app/sass/partials/_feature-links.scss
NetOpWibby (Migrated from github.com) commented 2018-10-01 16:10:43 +02:00
Copy link

It's better to have parameters in alphabetical order for easy searching/glancing, unless there are multiple parameters that go together like margin/padding, width/height, top/left, bottom/right.

It's better to have parameters in alphabetical order for easy searching/glancing, unless there are multiple parameters that go together like margin/padding, width/height, top/left, bottom/right.
app/views/api.js
@ -8,3 +4,2 @@
import dedent from "dedent";
import fs from "graceful-fs";
import raw from "choo/html/raw";
import redirectOr404 from "../modules/redirectOr404";
NetOpWibby (Migrated from github.com) commented 2018-10-01 16:11:20 +02:00
Copy link

Why is this here?

Why is this here?
app/views/api.js
@ -103,2 +108,3 @@
if (urlSlug === "sdk") apiFileLink = process.env.NODE_ENV === "development" ?
"https://rawgit.com/lbryio/lbry/master/docs/api.json" :
"https://cdn.rawgit.com/lbryio/lbry/5b3103e4/docs/api.json"
"https://cdn.rawgit.com/lbryio/lbry/master/docs/api.json"
NetOpWibby (Migrated from github.com) commented 2018-10-01 16:16:33 +02:00
Copy link

In master, lbry.tech/api defaults to displaying one of these pages. In this branch, that page is scrunched. There should be a redirect for this use case if a default API page isn't going to be used.

In master, `lbry.tech/api` defaults to displaying one of these pages. In this branch, that page is scrunched. There should be a redirect for this use case if a default API page isn't going to be used.
app/views/home.js
@ -9,4 +4,2 @@
// V A R I A B L E
import linkGrid from "../components/link-grid";
NetOpWibby (Migrated from github.com) commented 2018-10-01 16:12:56 +02:00
Copy link

Why break convention in a repo? Like I mentioned elsewhere, being able to glance and see where you need to go is super helpful.

Why break convention in a repo? Like I mentioned elsewhere, being able to glance and see where you need to go is super helpful.
app/views/home.js
NetOpWibby (Migrated from github.com) commented 2018-10-01 16:13:18 +02:00
Copy link

This indentation's off.

This indentation's off.
NetOpWibby (Migrated from github.com) reviewed 2018-10-01 16:32:47 +02:00
app/sass/pages/_api.scss
NetOpWibby (Migrated from github.com) commented 2018-10-01 16:32:41 +02:00
Copy link

There needs to be a top border here, preferably using the :before pseudo-selector so that it sits flush with the background of the first .api__content__example.

There needs to be a top border here, preferably using the `:before` pseudo-selector so that it sits flush with the background of the first `.api__content__example`.
kauffj (Migrated from github.com) reviewed 2018-10-01 16:38:54 +02:00
app/sass/pages/_api.scss
kauffj (Migrated from github.com) commented 2018-10-01 16:38:54 +02:00
Copy link

probably not removed with intent and was a result of copying/pasting/editing other CSS

I'm a big fan of deterministic formatting (e.g. Prettier) so that these issues never come up

probably not removed with intent and was a result of copying/pasting/editing other CSS I'm a big fan of deterministic formatting (e.g. Prettier) so that these issues never come up
kauffj (Migrated from github.com) reviewed 2018-10-01 16:39:40 +02:00
app/sass/partials/_feature-links.scss
kauffj (Migrated from github.com) commented 2018-10-01 16:39:40 +02:00
Copy link

top goes with postion: relative

top goes with `postion: relative`
kauffj (Migrated from github.com) reviewed 2018-10-01 16:40:38 +02:00
app/views/api.js
@ -8,3 +4,2 @@
import dedent from "dedent";
import fs from "graceful-fs";
import raw from "choo/html/raw";
import redirectOr404 from "../modules/redirectOr404";
kauffj (Migrated from github.com) commented 2018-10-01 16:40:38 +02:00
Copy link

this was left over from a conflicted rebased, removed

this was left over from a conflicted rebased, removed
kauffj (Migrated from github.com) reviewed 2018-10-01 16:41:48 +02:00
app/views/home.js
@ -9,4 +4,2 @@
// V A R I A B L E
import linkGrid from "../components/link-grid";
kauffj (Migrated from github.com) commented 2018-10-01 16:41:47 +02:00
Copy link

every JS file has import or require statements at the top, it didn't seem necessary to have a comment explaining that that's what they are

every JS file has import or require statements at the top, it didn't seem necessary to have a comment explaining that that's what they are
kauffj (Migrated from github.com) reviewed 2018-10-01 16:42:01 +02:00
app/views/home.js
kauffj (Migrated from github.com) commented 2018-10-01 16:42:01 +02:00
Copy link

fixed

fixed
kauffj (Migrated from github.com) reviewed 2018-10-01 16:43:28 +02:00
app/sass/pages/_api.scss
kauffj (Migrated from github.com) commented 2018-10-01 16:43:28 +02:00
Copy link

good call, I think /api should just send people to /resources. I've updated it as such.

good call, I think `/api` should just send people to `/resources`. I've updated it as such.
kauffj commented 2018-10-01 16:47:11 +02:00 (Migrated from github.com)
Copy link

@NetOperatorWibby addressed above, but snazzy complained about the spacing you desired on home.js. I filed this ticket for deterministic formatting. I think it makes sense to just add that feature rather than spend time debating spacing (I care about consistency, but I care little about the specific choices.)

@NetOperatorWibby addressed above, but `snazzy` complained about the spacing you desired on `home.js`. I filed [this ticket](https://github.com/lbryio/lbry.tech/issues/165) for deterministic formatting. I think it makes sense to just add that feature rather than spend time debating spacing (I care about consistency, but I care little about the specific choices.)
kauffj (Migrated from github.com) reviewed 2018-10-01 16:47:33 +02:00
app/views/api.js
@ -103,2 +108,3 @@
if (urlSlug === "sdk") apiFileLink = process.env.NODE_ENV === "development" ?
"https://rawgit.com/lbryio/lbry/master/docs/api.json" :
"https://cdn.rawgit.com/lbryio/lbry/5b3103e4/docs/api.json"
"https://cdn.rawgit.com/lbryio/lbry/master/docs/api.json"
kauffj (Migrated from github.com) commented 2018-10-01 16:47:33 +02:00
Copy link

/api now goes to /resources

/api now goes to /resources
Sign in to join this conversation.
Reviewers
No reviewers
NetOpWibby
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
campaign-blocker

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
Content

   
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
campaign-blocker
consider soon
Content
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry.tech#163
No description provided.
Delete branch "launch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?