Redirects work now #167

2018-10-01T22:47:49+02:00

NetOpWibby commented

2018-10-01 22:47:49 +02:00

(Migrated from github.com)

No description provided.

kauffj (Migrated from github.com) reviewed 2018-10-01 23:13:22 +02:00

kauffj (Migrated from github.com) left a comment

You can ship this since it's better than not existing but this ought to be changed.

app/modules/redirect-404.js

					
				@ -0,0 +39,4 @@

				      <script>

				        setTimeout(() => {

				          window.location.href = "${redirectUrl}";

kauffj (Migrated from github.com) commented

2018-10-01 23:13:04 +02:00

Aren't I on the server when this is happening? There ought to be a way to send a 301 response rather than require JS to perform a redirect (which also has negative SEO implications in addition to being poor UX and making me feel unclean).

NetOpWibby (Migrated from github.com) reviewed 2018-10-02 00:40:00 +02:00

app/modules/redirect-404.js

					
				@ -0,0 +39,4 @@

				      <script>

				        setTimeout(() => {

				          window.location.href = "${redirectUrl}";

NetOpWibby (Migrated from github.com) commented

2018-10-02 00:40:00 +02:00

I spent some time trying to implement this server-side and wasn't able to figure it out in a decent amount of time. So, I settled on this.

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry.tech#167