Email Signup UX #170

New issue

Closed

opened 2018-10-02 21:00:53 +02:00 by kauffj · 2 comments

kauffj commented

2018-10-02 21:00:53 +02:00

(Migrated from github.com)

The regexp is incorrect and fails valid emails (e.g. jeremy+test@lbry.io). Since we're already validating server-side, client side validation adds basically no value. If you want client-side validation for UX purposes, then just check for the @ symbol or use an extremely generous regexp.
Submit on enter (alternatively, make it a real form)
No feedback on invalid email or failure (no feedback it's working while submitted, either)
JavaScript should be more tightly/obviously coupled with markup

- [x] The regexp is incorrect and fails valid emails (e.g. `jeremy+test@lbry.io`). Since we're already validating server-side, client side validation adds basically no value. If you want client-side validation for UX purposes, then just check for the `@` symbol or use an extremely generous regexp. - [x] Submit on enter (alternatively, make it a real form) - [x] No feedback on invalid email or failure (no feedback it's working while submitted, either) - [ ] JavaScript should be more tightly/obviously coupled with markup

NetOpWibby commented

2018-10-06 00:57:45 +02:00

(Migrated from github.com)

Your first point is interesting because that regex works with my personal projects and using that specific use case. Also, the regex works on https://regexr.com.

I dislike forms because I don't like dealing with ajax and/or whatever forms need to send things. The rest of what you suggested are simple changes.

Your first point is interesting because that regex works with my personal projects and using that specific use case. Also, the regex works on https://regexr.com. I dislike forms because I don't like dealing with ajax and/or whatever forms need to send things. The rest of what you suggested are simple changes.

NetOpWibby commented

2018-10-06 02:23:14 +02:00

(Migrated from github.com)

A thought occurred to me and upon testing my assumptions were correct. You probably had a space before or after inputting your email. A simple whitespace trim upon submission would fix that issue.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry.tech#170

No description provided.