LBRYCommunity/lbry.tech
1
0
Fork 0
Code Issues 13 Pull requests 8 Projects Releases Packages Wiki Activity

overview refactor #219

Merged
kauffj merged 2 commits from overview_refactor into master 2019-01-25 17:18:13 +01:00
Conversation 2 Commits 2 Files changed 20 +100 -192
kauffj commented 2019-01-17 22:51:01 +01:00 (Migrated from github.com)
Copy link

Closes https://github.com/lbryio/lbry.tech/issues/51

Closes https://github.com/lbryio/lbry.tech/issues/51
NetOpWibby (Migrated from github.com) reviewed 2019-01-17 23:56:37 +01:00
.idea/codeStyles/Project.xml
NetOpWibby (Migrated from github.com) commented 2019-01-17 23:56:19 +01:00
Copy link

Do we want this .idea folder in the repo?

Do we want this `.idea` folder in the repo?
app/components/ecosystem/module-applications.js
NetOpWibby (Migrated from github.com) commented 2019-01-17 23:53:51 +01:00
Copy link

Were you not able to do import markdown from "../markdown";? That way of importing should work now.

Were you not able to do `import markdown from "../markdown";`? That way of importing should work now.
documents/overview.md
@ -18,2 +15,3 @@
<sub>^2(#footnote-2)^ Accessible anywhere in the world on any internet-connected device.</sub>
^3(#footnote-3)^ Not controlled by any one person, party or authority.
<sub>^3(#footnote-3)^ Not controlled by any one person, party or authority.</sub>
NetOpWibby (Migrated from github.com) commented 2019-01-17 23:55:13 +01:00
Copy link

Ah, this is where the <sub> issue comes from.

Ah, this is where the `<sub>` issue comes from.
kauffj (Migrated from github.com) reviewed 2019-01-18 19:38:43 +01:00
app/components/ecosystem/module-applications.js
kauffj (Migrated from github.com) commented 2019-01-18 19:38:43 +01:00
Copy link

I just copy and pasted what was done elsewhere.

I just copy and pasted what was done elsewhere.
kauffj (Migrated from github.com) reviewed 2019-01-18 19:39:13 +01:00
.idea/codeStyles/Project.xml
kauffj (Migrated from github.com) commented 2019-01-18 19:39:13 +01:00
Copy link

Absolutely not, my mistake. I thought I had this removed from the commit. I'm on a new computer and lost my global git ignore.

Absolutely not, my mistake. I thought I had this removed from the commit. I'm on a new computer and lost my global git ignore.
tzarebczan commented 2019-01-25 12:39:36 +01:00 (Migrated from github.com)
Copy link

What's the status of this PR?

What's the status of this PR?
kauffj commented 2019-01-25 17:18:29 +01:00 (Migrated from github.com)
Copy link

@NetOperatorWibby I fixed the import statements and removed the unnecessary files, merging.

@NetOperatorWibby I fixed the import statements and removed the unnecessary files, merging.
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
campaign-blocker

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
Content

   
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
campaign-blocker
consider soon
Content
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry.tech#219
No description provided.
Delete branch "overview_refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?