LBRYCommunity/lbry.tech
1
0
Fork 0
Code Issues 13 Pull requests 8 Packages Projects Releases Wiki Activity

Dynamically calculate scrollbar on /spec #250

New issue
Closed
opened 2019-02-07 18:33:40 +01:00 by kauffj · 3 comments
kauffj commented 2019-02-07 18:33:40 +01:00 (Migrated from github.com)
Copy link

Currently, lbry.tech/spec is showing a double scrollbar: one for the iframe, and one for the site itself.

Currently, lbry.tech/spec is showing a double scrollbar: one for the iframe, and one for the site itself.
NetOpWibby commented 2019-02-07 18:51:46 +01:00 (Migrated from github.com)
Copy link

Closed via 241926c649

Closed via https://github.com/lbryio/lbry.tech/commit/241926c649435223919e84ab720df4bdd53742fb
lyoshenka commented 2019-02-07 22:25:25 +01:00 (Migrated from github.com)
Copy link

@NetOperatorWibby i think the real way to fix this is to fix my hacky css in app/views/spec.js. The iframe size should not be hardcoded as <div style="width: 100%; height: calc(100vh - 4rem)">. It should be styled using sass, with the height calculated based on the size of the nav bar.

@NetOperatorWibby i think the real way to fix this is to fix my hacky css in app/views/spec.js. The iframe size should not be hardcoded as `<div style="width: 100%; height: calc(100vh - 4rem)">`. It should be styled using sass, with the height calculated based on the size of the nav bar.
NetOpWibby commented 2019-02-07 22:44:55 +01:00 (Migrated from github.com)
Copy link

Okay. The issue is fixed though.

EDIT: I'll fix the styling soon.

Okay. The issue _is_ fixed though. EDIT: I'll fix the styling soon.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/npm_and_yarn/cacheable-request-and-got-10.2.7
dependabot/npm_and_yarn/http-cache-semantics-and-updates-4.1.1
dependabot/npm_and_yarn/json5-2.2.3
dependabot/npm_and_yarn/qs-6.5.3
dependabot/npm_and_yarn/decode-uri-component-0.2.2
trackers
dependabot/npm_and_yarn/undefsafe-2.0.5
dependabot/npm_and_yarn/node-fetch-2.6.7
dependabot/npm_and_yarn/markdown-it-12.3.2
BryanLunduke-patch-1
lbry_sdk_directory_refactor
seanyesmunt-patch-1
fix-build
lbrytv-api
devprogram-fixes
fix_some_bugs
android-build-steps-update
No results found.
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
campaign-blocker

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
Content

   
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
campaign-blocker
consider soon
Content
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry.tech#250
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?