LBRY Developer Program #255
No reviewers
Labels
No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
campaign-blocker
consider soon
Content
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry.tech#255
Loading…
Reference in a new issue
No description provided.
Delete branch "209-quickstart"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #209
@ -390,2 +414,3 @@selector: "#emailMessage"}));});}Is this copy good?
More copy you may want to change.
There should only be one set of values here, not two differently named ones. The production server receives the production values; local development can use the test values.
@ -0,0 +14,4 @@document.querySelector("developer-program").innerHTML = `<form><input-submit><input id="walletAddress" placeholder="Your LBRY wallet address" type="text"/>Can this look stylistically similar or identical (and use the same classes/elements) to the input + button on the playground?
Can this be a single centered button labeled "Claim Developer LBC" with smaller/meta text below it that says "This will authenticate you with GitHub to prove eligibility as well as mark you as a follower of LBRY".
I was going to change this myself, but we don't have a button style?!
This component should error cleanly if the relevant GitHub values aren't set.
^ what this says
@ -0,0 +14,4 @@document.querySelector("developer-program").innerHTML = `<form><input-submit><input id="walletAddress" placeholder="Your LBRY wallet address" type="text"/>Do you mean having
lbryinside the input? Otherwise, the input/button on Playground is going to match what's on this page (not the other way around). It's the new component.@ -0,0 +14,4 @@document.querySelector("developer-program").innerHTML = `<form><input-submit><input id="walletAddress" placeholder="Your LBRY wallet address" type="text"/>OK, if they're the same, consider this resolved. I thought they looked different when I checked, will confirm when PR is ready for review again.
Done making changes.
I want to get this live, so please just merge and release after next changes and then we can test it in production.
@ -0,0 +13,4 @@if (window.location.search.includes("?code=")) {document.querySelector("developer-program").innerHTML = `<form><input-submit>This is still not styled correctly for me. Sending you a screenshot on Slack.
@ -17,1 +16,4 @@let apiUrl = process.env.REWARD_URL;let githubAppId = process.env.GITHUB_APP_ID;let githubAppSecret = process.env.GITHUB_APP_SECRET;I removed the additional check to use
TESTvariables that was below this.I was never able to get this to work, but I assume it actually does. It would be good to update this to include a link to the transaction on the block explorer.
It requires a test wallet address.
Ah, just realized you must've been trying to do this with the production values. I'm not sure if it's active or not.
I'm not sure how to grab the block explorer transaction since I have only been doing this in testing and I don't recall seeing an address I could use. I may forgetting this though.