LBRYCommunity/lbry.tech

Fork 0

fix: 0.37 SDK support #280

Merged

tzarebczan merged 1 commit from 0.37-changes into master

2019-05-22 00:57:55 +02:00

tzarebczan commented

2019-05-20 14:55:56 +02:00

(Migrated from github.com)

Basic support for the new SDK. Tested locally.

Not sure how rawContentCollection.push(fetchMetadata({ claim: url, method: "resolve", example: 1 })); worked with example = 3...it would not work locally (would show a blank list on tip page). Maybe there's a better fix for it, that's the best I had for now.

Basic support for the new SDK. Tested locally. Not sure how ```rawContentCollection.push(fetchMetadata({ claim: url, method: "resolve", example: 1 }));``` worked with example = 3...it would not work locally (would show a blank list on tip page). Maybe there's a better fix for it, that's the best I had for now.

NetOpWibby (Migrated from github.com) reviewed 2019-05-20 14:55:56 +02:00

tzarebczan commented

2019-05-20 18:50:22 +02:00

(Migrated from github.com)

Requires https://github.com/lbryio/web-daemon/pull/14 + the SDK to be upgraded.

NetOpWibby commented

2019-05-20 18:51:01 +02:00

(Migrated from github.com)

This needs to work with all examples before merging.

tzarebczan commented

2019-05-20 18:51:30 +02:00

(Migrated from github.com)

It does...

NetOpWibby commented

2019-05-20 18:52:13 +02:00

(Migrated from github.com)

I don't understand your initial comment then.

tzarebczan commented

2019-05-20 18:53:26 +02:00

(Migrated from github.com)

See the code. I changed it from using example: 3 to example: 1 which did not work locally for that call (it should be the same as the trending call to resolve the white listed URLs). My comment was more about "how the heck did this work before" :)

👍 1

neb-b (Migrated from github.com) reviewed 2019-05-20 19:28:24 +02:00

app/components/client/playground-scripts.js

neb-b (Migrated from github.com) commented

2019-05-20 19:28:24 +02:00

Should this be ["mature"]?

Should this be `["mature"]`?

tzarebczan (Migrated from github.com) reviewed 2019-05-20 19:46:34 +02:00

app/components/client/playground-scripts.js

tzarebczan (Migrated from github.com) commented

2019-05-20 19:46:34 +02:00

that produces the same result in terms of the output syntax (the result itself is correct). This only affects the suggested syntax on the command line: "tags": mature

The syntax does need to be cleaned up now that we don't pass the metadata tag directly.

that produces the same result in terms of the output syntax (the result itself is correct). This only affects the suggested syntax on the command line: ```"tags": mature``` The syntax does need to be cleaned up now that we don't pass the metadata tag directly.

tzarebczan commented

2019-05-23 02:26:57 +02:00

(Migrated from github.com)

you're welcome
Niko and I updated the SDK on the server
you're welcome :)

1) you're welcome 2) Niko and I updated the SDK on the server 3) you're welcome :)

No reviewers

NetOpWibby

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry.tech#280

No description provided.