Travis [CI] Is Not Happy - Code Style Errors #313

New issue

Open

opened 2020-02-07 04:30:37 +01:00 by misspellted · 4 comments

misspellted commented

2020-02-07 04:30:37 +01:00

(Migrated from github.com)

As a recent new contributor to LBRY (.tech in particular), I was saddened to see, as part of the process for pull requests (#312 for example), that Travis CI failed the build.

I am currently in the software engineering field, more specifically devops-y releated, and seing a failed build makes me sad. So, while it is a little difficult to describe the Expected and Actual Behaviors, I did notice a few entries that appear to be correctable code style errors (without digging into the source right away before creating this issue):

no-multi-spaces
prefer-const
no-useless-return
arrow-spacing

As someone not quite versed in JavaScript, I am not sure I would be sufficient in resolving the few prefer-promise-reject-errors entries, so I am thinking of just tackling the "simple"-looking errors for now, in hopes to at least reduce the errors reported. I don't know if the 25 style errors are the maximum the linter/checker will report - maybe there are additional ones after fixing the ones already reported?

I don't think it would hurt [too much] to at least get started in tackling the bugs, to get Travis to a happy/happier state.

As a recent new contributor to LBRY (.tech in particular), I was saddened to see, as part of the process for pull requests (#312 for example), that [Travis CI failed the build](https://travis-ci.org/lbryio/lbry.tech/builds/646680888?utm_source=github_status&utm_medium=notification). I am currently in the software engineering field, more specifically devops-y releated, and seing a failed build makes me sad. So, while it is a little difficult to describe the Expected and Actual Behaviors, I did notice a few entries that appear to be correctable code style errors (without digging into the source right away before creating this issue): - no-multi-spaces - prefer-const - no-useless-return - arrow-spacing As someone not quite versed in JavaScript, I am not sure I would be sufficient in resolving the few prefer-promise-reject-errors entries, so I am thinking of just tackling the "simple"-looking errors for now, in hopes to at least reduce the errors reported. I don't know if the 25 style errors are the maximum the linter/checker will report - maybe there are additional ones after fixing the ones already reported? I don't think it would hurt [too much] to at least get started in tackling the bugs, to get Travis to a happy/happier state.

cassidypignatello commented

2020-04-11 09:48:59 +02:00

(Migrated from github.com)

Opened a PR for this at #317. All eslint errors have been resolved and Travis looks happy. Please let me know if there's anything else I should do in order to have this accepted.

misspellted commented

2020-04-11 13:20:14 +02:00

(Migrated from github.com)

Travis looks happy! Thanks @cassidypignatello!

Since lbry-bot assigned the PR to @kauffj, it'll just be a quick review of the changes and most likely an approval will be granted to accept the PR.

Travis looks happy! Thanks @cassidypignatello! Since lbry-bot assigned the PR to @kauffj, it'll just be a quick review of the changes and most likely an approval will be granted to accept the PR.

🎉 1

kauffj commented

2020-04-14 23:13:42 +02:00

(Migrated from github.com)

Thanks to both of you! Kind of an ugly code base so your work is extra appreciated @cassidypignatello 😛

If you want to work on some nicer (and deeper) JavaScript, come join us on lbry.tv / lbry-desktop!

https://github.com/lbryio/lbry-desktop

Thanks to both of you! Kind of an ugly code base so your work is extra appreciated @cassidypignatello :stuck_out_tongue: If you want to work on some nicer (and deeper) JavaScript, come join us on lbry.tv / lbry-desktop! https://github.com/lbryio/lbry-desktop

cassidypignatello commented

2020-04-15 11:57:45 +02:00

(Migrated from github.com)

Happy to help! I'm a stickler for code style so this sort of thing is right up my alley. 😉

I'll check out some of other issues on lbry-desktop as well, I'd definitely like to contribute more!

Happy to help! I'm a stickler for code style so this sort of thing is right up my alley. 😉 I'll check out some of other issues on lbry-desktop as well, I'd definitely like to contribute more!

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry.tech#313

No description provided.