LBRY Developer Program #255

Merged
NetOpWibby merged 15 commits from 209-quickstart into master 2019-02-19 23:22:28 +01:00
5 changed files with 9 additions and 15 deletions
Showing only changes of commit 2400b5c465 - Show all commits

View file

@ -6,7 +6,7 @@ DAEMON_URL=
# /developer-program
GITHUB_APP_ID=
GITHUB_APP_SECRET=
REWARD_URL=
REWARD_URL=api.lbry.io
# https://developer.github.com/apps/building-oauth-apps/creating-an-oauth-app
# We use this to show the GitHub feed on the homepage

View file

@ -20,12 +20,13 @@ if (window.location.search.includes("?code=")) {
</input-submit>
</form>
<h4>Need An Address?</h4>
<p>To receive your LBC, you'll need a wallet address. While graphical wallets are available, the recommended path for engineers is to:</p>
<ol>
<li>Download <a href="https://github.com/lbryio/lbry">the LBRY SDK</a>.</li>
<li>Launch the command-line utility.</li>
<li>Run the <a href="https://lbry.tech/api/sdk#address_unused"><code>address_unused</code></a> command.</li>
<li>Download <a href="https://github.com/lbryio/lbry/releases">the LBRY SDK</a>.</li>
<li>Launch the command-line utility (<code>./lbrynet start</code>).</li>
<li>Run <code>./lbrynet address list</code> and copy the <code>id</code> field.</li>
</ol>
`;
@ -40,6 +41,6 @@ if (document.getElementById("creditsAcquire")) {
message: "verify github auth"
});
document.querySelector("developer-program").innerHTML = "<p><em>Awaiting response from internal LBRY API</em></p>";
document.querySelector("developer-program").innerHTML = "<p><em>Awaiting response from LBRY server...</em></p>";
};
}

View file

@ -2,7 +2,7 @@ developer-program {
@extend %markdown;
.button {
margin: 2rem auto 1rem;
margin: 1rem auto;
display: block;
}

View file

@ -17,14 +17,6 @@ let apiUrl = process.env.REWARD_URL;
let githubAppId = process.env.GITHUB_APP_ID;
let githubAppSecret = process.env.GITHUB_APP_SECRET;
kauffj commented 2019-02-19 19:20:25 +01:00 (Migrated from github.com)
Review

I removed the additional check to use TEST variables that was below this.

I removed the additional check to use `TEST` variables that was below this.
if (process.env.NODE_ENV === "development") {
apiUrl = process.env.REWARD_URL_TEST;
githubAppId = process.env.GITHUB_APP_ID_TEST;
githubAppSecret = process.env.GITHUB_APP_SECRET_TEST;
}
// P R O G R A M
export default (socket, action) => {
@ -461,7 +453,7 @@ async function syncWithApi(data, socket) {
console.log(error.body); // eslint-disable-line no-console
return send(socket, {
html: "<p>This reward is limited to <strong>ONE</strong> per person. Your enthusiasm is appreciated.</p>",
html: "<p>You have already claimed this reward. This reward is limited to <strong>ONE</strong> per person. Your enthusiasm is appreciated.</p>",
message: "updated html",
selector: "developer-program"
});

View file

@ -9,4 +9,5 @@ To qualify you must:
NetOpWibby commented 2019-02-14 18:10:42 +01:00 (Migrated from github.com)
Review

More copy you may want to change.

More copy you may want to change.
kauffj commented 2019-02-17 22:15:03 +01:00 (Migrated from github.com)
Review

^ what this says

^ what this says
NetOpWibby commented 2019-02-14 18:10:42 +01:00 (Migrated from github.com)
Review

More copy you may want to change.

More copy you may want to change.
kauffj commented 2019-02-17 22:15:03 +01:00 (Migrated from github.com)
Review

^ what this says

^ what this says
- Have a GitHub account prior to January 1st, 2018.
- Have made a public pull request within the past year.
### Claim LBC
NetOpWibby commented 2019-02-14 18:10:42 +01:00 (Migrated from github.com)
Review

More copy you may want to change.

More copy you may want to change.
kauffj commented 2019-02-17 22:15:03 +01:00 (Migrated from github.com)
Review

^ what this says

^ what this says
<DeveloperProgram/>

NetOpWibby commented 2019-02-14 18:10:42 +01:00 (Migrated from github.com)
Review

More copy you may want to change.

More copy you may want to change.
kauffj commented 2019-02-17 22:15:03 +01:00 (Migrated from github.com)
Review

^ what this says

^ what this says
NetOpWibby commented 2019-02-14 18:10:42 +01:00 (Migrated from github.com)
Review

More copy you may want to change.

More copy you may want to change.
kauffj commented 2019-02-17 22:15:03 +01:00 (Migrated from github.com)
Review

^ what this says

^ what this says