LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity
lbrycrd/src/test/addrman_tests.cpp

691 lines
23 KiB
C++
Raw Normal View History

Increment MIT Licence copyright header year on files modified in 2017
2018-01-02 18:12:05 +01:00
// Copyright (c) 2012-2017 The Bitcoin Core developers
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
scripted-diff: Replace #include "" with #include <> (ryanofsky) -BEGIN VERIFY SCRIPT- for f in \ src/*.cpp \ src/*.h \ src/bench/*.cpp \ src/bench/*.h \ src/compat/*.cpp \ src/compat/*.h \ src/consensus/*.cpp \ src/consensus/*.h \ src/crypto/*.cpp \ src/crypto/*.h \ src/crypto/ctaes/*.h \ src/policy/*.cpp \ src/policy/*.h \ src/primitives/*.cpp \ src/primitives/*.h \ src/qt/*.cpp \ src/qt/*.h \ src/qt/test/*.cpp \ src/qt/test/*.h \ src/rpc/*.cpp \ src/rpc/*.h \ src/script/*.cpp \ src/script/*.h \ src/support/*.cpp \ src/support/*.h \ src/support/allocators/*.h \ src/test/*.cpp \ src/test/*.h \ src/wallet/*.cpp \ src/wallet/*.h \ src/wallet/test/*.cpp \ src/wallet/test/*.h \ src/zmq/*.cpp \ src/zmq/*.h do base=${f%/*}/ relbase=${base#src/} sed -i "s:#include \"\(.*\)\"\(.*\):if test -e \$base'\\1'; then echo \"#include <\"\$relbase\"\\1>\\2\"; else echo \"#include <\\1>\\2\"; fi:e" $f done -END VERIFY SCRIPT-
2017-11-10 01:57:53 +01:00
#include <addrman.h>
#include <test/test_bitcoin.h>
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
#include <string>
#include <boost/test/unit_test.hpp>
scripted-diff: Replace #include "" with #include <> (ryanofsky) -BEGIN VERIFY SCRIPT- for f in \ src/*.cpp \ src/*.h \ src/bench/*.cpp \ src/bench/*.h \ src/compat/*.cpp \ src/compat/*.h \ src/consensus/*.cpp \ src/consensus/*.h \ src/crypto/*.cpp \ src/crypto/*.h \ src/crypto/ctaes/*.h \ src/policy/*.cpp \ src/policy/*.h \ src/primitives/*.cpp \ src/primitives/*.h \ src/qt/*.cpp \ src/qt/*.h \ src/qt/test/*.cpp \ src/qt/test/*.h \ src/rpc/*.cpp \ src/rpc/*.h \ src/script/*.cpp \ src/script/*.h \ src/support/*.cpp \ src/support/*.h \ src/support/allocators/*.h \ src/test/*.cpp \ src/test/*.h \ src/wallet/*.cpp \ src/wallet/*.h \ src/wallet/test/*.cpp \ src/wallet/test/*.h \ src/zmq/*.cpp \ src/zmq/*.h do base=${f%/*}/ relbase=${base#src/} sed -i "s:#include \"\(.*\)\"\(.*\):if test -e \$base'\\1'; then echo \"#include <\"\$relbase\"\\1>\\2\"; else echo \"#include <\\1>\\2\"; fi:e" $f done -END VERIFY SCRIPT-
2017-11-10 01:57:53 +01:00
#include <hash.h>
#include <netbase.h>
#include <random.h>
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
class CAddrManTest : public CAddrMan
{
uint64_t state;
public:
Add recommendation: By default, declare single-argument constructors `explicit`
2017-08-22 22:50:03 +02:00
explicit CAddrManTest(bool makeDeterministic = true)
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
{
state = 1;
Tests: address placement should be deterministic by default
2017-07-13 13:39:27 +02:00
if (makeDeterministic) {
// Set addrman addr placement to be deterministic.
MakeDeterministic();
}
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
}
//! Ensure that bucket placement is always the same for testing purposes.
void MakeDeterministic()
{
nKey.SetNull();
Kill insecure_random and associated global state There are only a few uses of `insecure_random` outside the tests. This PR replaces uses of insecure_random (and its accompanying global state) in the core code with an FastRandomContext that is automatically seeded on creation. This is meant to be used for inner loops. The FastRandomContext can be in the outer scope, or the class itself, then rand32() is used inside the loop. Useful e.g. for pushing addresses in CNode or the fee rounding, or randomization for coin selection. As a context is created per purpose, thus it gets rid of cross-thread unprotected shared usage of a single set of globals, this should also get rid of the potential race conditions. - I'd say TxMempool::check is not called enough to warrant using a special fast random context, this is switched to GetRand() (open for discussion...) - The use of `insecure_rand` in ConnectThroughProxy has been replaced by an atomic integer counter. The only goal here is to have a different credentials pair for each connection to go on a different Tor circuit, it does not need to be random nor unpredictable. - To avoid having a FastRandomContext on every CNode, the context is passed into PushAddress as appropriate. There remains an insecure_random for test usage in `test_random.h`.
2016-10-13 16:19:20 +02:00
insecure_rand = FastRandomContext(true);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
}
Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class
2017-06-20 21:58:56 +02:00
int RandomInt(int nMax) override
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
{
state = (CHashWriter(SER_GETHASH, 0) << state).GetHash().GetCheapHash();
return (unsigned int)(state % nMax);
}
scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL -BEGIN VERIFY SCRIPT- sed -i 's/\<NULL\>/nullptr/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h src/qt/*/*.cpp src/qt/*/*.h src/wallet/*/*.cpp src/wallet/*/*.h src/support/allocators/*.h sed -i 's/Prefer nullptr, otherwise SAFECOOKIE./Prefer NULL, otherwise SAFECOOKIE./g' src/torcontrol.cpp sed -i 's/tor: Using nullptr authentication/tor: Using NULL authentication/g' src/torcontrol.cpp sed -i 's/METHODS=nullptr/METHODS=NULL/g' src/test/torcontrol_tests.cpp src/torcontrol.cpp sed -i 's/nullptr certificates/NULL certificates/g' src/qt/paymentserver.cpp sed -i 's/"nullptr"/"NULL"/g' src/torcontrol.cpp src/test/torcontrol_tests.cpp -END VERIFY SCRIPT-
2017-08-07 07:36:37 +02:00
CAddrInfo* Find(const CNetAddr& addr, int* pnId = nullptr)
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
{
return CAddrMan::Find(addr, pnId);
}
scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL -BEGIN VERIFY SCRIPT- sed -i 's/\<NULL\>/nullptr/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h src/qt/*/*.cpp src/qt/*/*.h src/wallet/*/*.cpp src/wallet/*/*.h src/support/allocators/*.h sed -i 's/Prefer nullptr, otherwise SAFECOOKIE./Prefer NULL, otherwise SAFECOOKIE./g' src/torcontrol.cpp sed -i 's/tor: Using nullptr authentication/tor: Using NULL authentication/g' src/torcontrol.cpp sed -i 's/METHODS=nullptr/METHODS=NULL/g' src/test/torcontrol_tests.cpp src/torcontrol.cpp sed -i 's/nullptr certificates/NULL certificates/g' src/qt/paymentserver.cpp sed -i 's/"nullptr"/"NULL"/g' src/torcontrol.cpp src/test/torcontrol_tests.cpp -END VERIFY SCRIPT-
2017-08-07 07:36:37 +02:00
CAddrInfo* Create(const CAddress& addr, const CNetAddr& addrSource, int* pnId = nullptr)
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
{
return CAddrMan::Create(addr, addrSource, pnId);
}
void Delete(int nId)
{
CAddrMan::Delete(nId);
}
Add test-before-evict discipline to addrman Changes addrman to use the test-before-evict discipline in which an address is to be evicted from the tried table is first tested and if it is still online it is not evicted. Adds tests to provide test coverage for this change. This change was suggested as Countermeasure 3 in Eclipse Attacks on Bitcoin’s Peer-to-Peer Network, Ethan Heilman, Alison Kendler, Aviv Zohar, Sharon Goldberg. ePrint Archive Report 2015/263. March 2015.
2016-10-27 19:55:39 +02:00
// Simulates connection failure so that we can test eviction of offline nodes
void SimConnFail(CService& addr)
{
int64_t nLastSuccess = 1;
Good_(addr, true, nLastSuccess); // Set last good connection in the deep past.
bool count_failure = false;
int64_t nLastTry = GetAdjustedTime()-61;
Attempt(addr, count_failure, nLastTry);
}
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
};
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
net: Split resolving out of CNetAddr
2016-05-31 19:05:52 +02:00
static CNetAddr ResolveIP(const char* ip)
{
CNetAddr addr;
BOOST_CHECK_MESSAGE(LookupHost(ip, addr, false), strprintf("failed to resolve: %s", ip));
return addr;
}
static CNetAddr ResolveIP(std::string ip)
{
return ResolveIP(ip.c_str());
}
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
static CService ResolveService(const char* ip, int port = 0)
{
CService serv;
BOOST_CHECK_MESSAGE(Lookup(ip, serv, port, false), strprintf("failed to resolve: %s:%i", ip, port));
return serv;
}
static CService ResolveService(std::string ip, int port = 0)
{
return ResolveService(ip.c_str(), port);
}
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
BOOST_FIXTURE_TEST_SUITE(addrman_tests, BasicTestingSetup)
BOOST_AUTO_TEST_CASE(addrman_simple)
{
CAddrManTest addrman;
net: Split resolving out of CNetAddr
2016-05-31 19:05:52 +02:00
CNetAddr source = ResolveIP("252.2.2.2");
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: Does Addrman respond correctly when empty.
BOOST_CHECK_EQUAL(addrman.size(), 0);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
CAddrInfo addr_null = addrman.Select();
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addr_null.ToString(), "[::]:0");
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: Does Addrman::Add work as expected.
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CService addr1 = ResolveService("250.1.1.1", 8333);
[tests] Update Unit Test for addrman.h/addrman.cpp Add test for adding multiple addresses to address manager Clean up unnecessary modulo operations Add test for GetNewBucket's alternate method signature
2017-04-27 03:15:07 +02:00
BOOST_CHECK(addrman.Add(CAddress(addr1, NODE_NONE), source));
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 1);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
CAddrInfo addr_ret1 = addrman.Select();
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addr_ret1.ToString(), "250.1.1.1:8333");
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: Does IP address deduplication work correctly.
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
// Expected dup IP should not be added.
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CService addr1_dup = ResolveService("250.1.1.1", 8333);
[tests] Update Unit Test for addrman.h/addrman.cpp Add test for adding multiple addresses to address manager Clean up unnecessary modulo operations Add test for GetNewBucket's alternate method signature
2017-04-27 03:15:07 +02:00
BOOST_CHECK(!addrman.Add(CAddress(addr1_dup, NODE_NONE), source));
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 1);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: New table has one addr and we add a diff addr we should
tests: fix spurious addrman test failure When inserting two addresses of the same class, from the same source, they have a 1/64 chance of colliding.
2017-05-19 06:00:39 +02:00
// have at least one addr.
// Note that addrman's size cannot be tested reliably after insertion, as
// hash collisions may occur. But we can always be sure of at least one
// success.
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CService addr2 = ResolveService("250.1.1.2", 8333);
[tests] Update Unit Test for addrman.h/addrman.cpp Add test for adding multiple addresses to address manager Clean up unnecessary modulo operations Add test for GetNewBucket's alternate method signature
2017-04-27 03:15:07 +02:00
BOOST_CHECK(addrman.Add(CAddress(addr2, NODE_NONE), source));
tests: fix spurious addrman test failure When inserting two addresses of the same class, from the same source, they have a 1/64 chance of colliding.
2017-05-19 06:00:39 +02:00
BOOST_CHECK(addrman.size() >= 1);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: AddrMan::Clear() should empty the new table.
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
addrman.Clear();
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 0);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
CAddrInfo addr_null2 = addrman.Select();
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addr_null2.ToString(), "[::]:0");
[tests] Update Unit Test for addrman.h/addrman.cpp Add test for adding multiple addresses to address manager Clean up unnecessary modulo operations Add test for GetNewBucket's alternate method signature
2017-04-27 03:15:07 +02:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: AddrMan::Add multiple addresses works as expected
[tests] Update Unit Test for addrman.h/addrman.cpp Add test for adding multiple addresses to address manager Clean up unnecessary modulo operations Add test for GetNewBucket's alternate method signature
2017-04-27 03:15:07 +02:00
std::vector<CAddress> vAddr;
vAddr.push_back(CAddress(ResolveService("250.1.1.3", 8333), NODE_NONE));
vAddr.push_back(CAddress(ResolveService("250.1.1.4", 8333), NODE_NONE));
BOOST_CHECK(addrman.Add(vAddr, source));
tests: fix spurious addrman test failure When inserting two addresses of the same class, from the same source, they have a 1/64 chance of colliding.
2017-05-19 06:00:39 +02:00
BOOST_CHECK(addrman.size() >= 1);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
}
BOOST_AUTO_TEST_CASE(addrman_ports)
{
CAddrManTest addrman;
net: Split resolving out of CNetAddr
2016-05-31 19:05:52 +02:00
CNetAddr source = ResolveIP("252.2.2.2");
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 0);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
// Test 7; Addr with same IP but diff port does not replace existing addr.
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CService addr1 = ResolveService("250.1.1.1", 8333);
Introduce enum ServiceFlags for service flags
2016-06-08 19:12:22 +02:00
addrman.Add(CAddress(addr1, NODE_NONE), source);
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 1);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CService addr1_port = ResolveService("250.1.1.1", 8334);
Introduce enum ServiceFlags for service flags
2016-06-08 19:12:22 +02:00
addrman.Add(CAddress(addr1_port, NODE_NONE), source);
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 1);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
CAddrInfo addr_ret2 = addrman.Select();
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addr_ret2.ToString(), "250.1.1.1:8333");
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: Add same IP but diff port to tried table, it doesn't get added.
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
// Perhaps this is not ideal behavior but it is the current behavior.
Introduce enum ServiceFlags for service flags
2016-06-08 19:12:22 +02:00
addrman.Good(CAddress(addr1_port, NODE_NONE));
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 1);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
bool newOnly = true;
CAddrInfo addr_ret3 = addrman.Select(newOnly);
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addr_ret3.ToString(), "250.1.1.1:8333");
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
}
BOOST_AUTO_TEST_CASE(addrman_select)
{
CAddrManTest addrman;
net: Split resolving out of CNetAddr
2016-05-31 19:05:52 +02:00
CNetAddr source = ResolveIP("252.2.2.2");
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: Select from new with 1 addr in new.
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CService addr1 = ResolveService("250.1.1.1", 8333);
Introduce enum ServiceFlags for service flags
2016-06-08 19:12:22 +02:00
addrman.Add(CAddress(addr1, NODE_NONE), source);
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 1);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
bool newOnly = true;
CAddrInfo addr_ret1 = addrman.Select(newOnly);
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addr_ret1.ToString(), "250.1.1.1:8333");
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: move addr to tried, select from new expected nothing returned.
Introduce enum ServiceFlags for service flags
2016-06-08 19:12:22 +02:00
addrman.Good(CAddress(addr1, NODE_NONE));
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 1);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
CAddrInfo addr_ret2 = addrman.Select(newOnly);
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addr_ret2.ToString(), "[::]:0");
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
CAddrInfo addr_ret3 = addrman.Select();
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addr_ret3.ToString(), "250.1.1.1:8333");
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 1);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
// Add three addresses to new table.
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CService addr2 = ResolveService("250.3.1.1", 8333);
CService addr3 = ResolveService("250.3.2.2", 9999);
CService addr4 = ResolveService("250.3.3.3", 9999);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
addrman.Add(CAddress(addr2, NODE_NONE), ResolveService("250.3.1.1", 8333));
addrman.Add(CAddress(addr3, NODE_NONE), ResolveService("250.3.1.1", 8333));
addrman.Add(CAddress(addr4, NODE_NONE), ResolveService("250.4.1.1", 8333));
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
// Add three addresses to tried table.
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CService addr5 = ResolveService("250.4.4.4", 8333);
CService addr6 = ResolveService("250.4.5.5", 7777);
CService addr7 = ResolveService("250.4.6.6", 8333);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
addrman.Add(CAddress(addr5, NODE_NONE), ResolveService("250.3.1.1", 8333));
Introduce enum ServiceFlags for service flags
2016-06-08 19:12:22 +02:00
addrman.Good(CAddress(addr5, NODE_NONE));
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
addrman.Add(CAddress(addr6, NODE_NONE), ResolveService("250.3.1.1", 8333));
Introduce enum ServiceFlags for service flags
2016-06-08 19:12:22 +02:00
addrman.Good(CAddress(addr6, NODE_NONE));
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
addrman.Add(CAddress(addr7, NODE_NONE), ResolveService("250.1.1.3", 8333));
Introduce enum ServiceFlags for service flags
2016-06-08 19:12:22 +02:00
addrman.Good(CAddress(addr7, NODE_NONE));
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: 6 addrs + 1 addr from last test = 7.
BOOST_CHECK_EQUAL(addrman.size(), 7);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: Select pulls from new and tried regardless of port number.
Switch FastRandomContext to ChaCha20
2017-02-16 02:45:22 +01:00
std::set<uint16_t> ports;
for (int i = 0; i < 20; ++i) {
ports.insert(addrman.Select().GetPort());
}
BOOST_CHECK_EQUAL(ports.size(), 3);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
}
BOOST_AUTO_TEST_CASE(addrman_new_collisions)
{
CAddrManTest addrman;
net: Split resolving out of CNetAddr
2016-05-31 19:05:52 +02:00
CNetAddr source = ResolveIP("252.2.2.2");
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 0);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
for (unsigned int i = 1; i < 18; i++) {
Add test-before-evict discipline to addrman Changes addrman to use the test-before-evict discipline in which an address is to be evicted from the tried table is first tested and if it is still online it is not evicted. Adds tests to provide test coverage for this change. This change was suggested as Countermeasure 3 in Eclipse Attacks on Bitcoin’s Peer-to-Peer Network, Ethan Heilman, Alison Kendler, Aviv Zohar, Sharon Goldberg. ePrint Archive Report 2015/263. March 2015.
2016-10-27 19:55:39 +02:00
CService addr = ResolveService("250.1.1." + std::to_string(i));
Introduce enum ServiceFlags for service flags
2016-06-08 19:12:22 +02:00
addrman.Add(CAddress(addr, NODE_NONE), source);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
//Test: No collision in new table yet.
BOOST_CHECK_EQUAL(addrman.size(), i);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
}
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
//Test: new table collision!
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CService addr1 = ResolveService("250.1.1.18");
Introduce enum ServiceFlags for service flags
2016-06-08 19:12:22 +02:00
addrman.Add(CAddress(addr1, NODE_NONE), source);
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 17);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CService addr2 = ResolveService("250.1.1.19");
Introduce enum ServiceFlags for service flags
2016-06-08 19:12:22 +02:00
addrman.Add(CAddress(addr2, NODE_NONE), source);
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 18);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
}
BOOST_AUTO_TEST_CASE(addrman_tried_collisions)
{
CAddrManTest addrman;
net: Split resolving out of CNetAddr
2016-05-31 19:05:52 +02:00
CNetAddr source = ResolveIP("252.2.2.2");
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 0);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
for (unsigned int i = 1; i < 80; i++) {
Add test-before-evict discipline to addrman Changes addrman to use the test-before-evict discipline in which an address is to be evicted from the tried table is first tested and if it is still online it is not evicted. Adds tests to provide test coverage for this change. This change was suggested as Countermeasure 3 in Eclipse Attacks on Bitcoin’s Peer-to-Peer Network, Ethan Heilman, Alison Kendler, Aviv Zohar, Sharon Goldberg. ePrint Archive Report 2015/263. March 2015.
2016-10-27 19:55:39 +02:00
CService addr = ResolveService("250.1.1." + std::to_string(i));
Introduce enum ServiceFlags for service flags
2016-06-08 19:12:22 +02:00
addrman.Add(CAddress(addr, NODE_NONE), source);
addrman.Good(CAddress(addr, NODE_NONE));
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
//Test: No collision in tried table yet.
[test] Remove redundant print in addrman_tests
2016-09-22 12:51:50 +02:00
BOOST_CHECK_EQUAL(addrman.size(), i);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
}
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
//Test: tried table collision!
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CService addr1 = ResolveService("250.1.1.80");
Introduce enum ServiceFlags for service flags
2016-06-08 19:12:22 +02:00
addrman.Add(CAddress(addr1, NODE_NONE), source);
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 79);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CService addr2 = ResolveService("250.1.1.81");
Introduce enum ServiceFlags for service flags
2016-06-08 19:12:22 +02:00
addrman.Add(CAddress(addr2, NODE_NONE), source);
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 80);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
}
BOOST_AUTO_TEST_CASE(addrman_find)
{
CAddrManTest addrman;
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 0);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CAddress addr1 = CAddress(ResolveService("250.1.2.1", 8333), NODE_NONE);
CAddress addr2 = CAddress(ResolveService("250.1.2.1", 9999), NODE_NONE);
CAddress addr3 = CAddress(ResolveService("251.255.2.1", 8333), NODE_NONE);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
net: Split resolving out of CNetAddr
2016-05-31 19:05:52 +02:00
CNetAddr source1 = ResolveIP("250.1.2.1");
CNetAddr source2 = ResolveIP("250.1.2.2");
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
addrman.Add(addr1, source1);
addrman.Add(addr2, source2);
addrman.Add(addr3, source1);
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: ensure Find returns an IP matching what we searched on.
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
CAddrInfo* info1 = addrman.Find(addr1);
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_REQUIRE(info1);
BOOST_CHECK_EQUAL(info1->ToString(), "250.1.2.1:8333");
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
// Test 18; Find does not discriminate by port number.
CAddrInfo* info2 = addrman.Find(addr2);
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_REQUIRE(info2);
BOOST_CHECK_EQUAL(info2->ToString(), info1->ToString());
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: Find returns another IP matching what we searched on.
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
CAddrInfo* info3 = addrman.Find(addr3);
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_REQUIRE(info3);
BOOST_CHECK_EQUAL(info3->ToString(), "251.255.2.1:8333");
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
}
BOOST_AUTO_TEST_CASE(addrman_create)
{
CAddrManTest addrman;
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 0);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CAddress addr1 = CAddress(ResolveService("250.1.2.1", 8333), NODE_NONE);
net: Split resolving out of CNetAddr
2016-05-31 19:05:52 +02:00
CNetAddr source1 = ResolveIP("250.1.2.1");
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
int nId;
CAddrInfo* pinfo = addrman.Create(addr1, source1, &nId);
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: The result should be the same as the input addr.
BOOST_CHECK_EQUAL(pinfo->ToString(), "250.1.2.1:8333");
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
CAddrInfo* info2 = addrman.Find(addr1);
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(info2->ToString(), "250.1.2.1:8333");
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
}
BOOST_AUTO_TEST_CASE(addrman_delete)
{
CAddrManTest addrman;
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 0);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CAddress addr1 = CAddress(ResolveService("250.1.2.1", 8333), NODE_NONE);
net: Split resolving out of CNetAddr
2016-05-31 19:05:52 +02:00
CNetAddr source1 = ResolveIP("250.1.2.1");
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
int nId;
addrman.Create(addr1, source1, &nId);
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: Delete should actually delete the addr.
BOOST_CHECK_EQUAL(addrman.size(), 1);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
addrman.Delete(nId);
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 0);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
CAddrInfo* info2 = addrman.Find(addr1);
scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL -BEGIN VERIFY SCRIPT- sed -i 's/\<NULL\>/nullptr/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h src/qt/*/*.cpp src/qt/*/*.h src/wallet/*/*.cpp src/wallet/*/*.h src/support/allocators/*.h sed -i 's/Prefer nullptr, otherwise SAFECOOKIE./Prefer NULL, otherwise SAFECOOKIE./g' src/torcontrol.cpp sed -i 's/tor: Using nullptr authentication/tor: Using NULL authentication/g' src/torcontrol.cpp sed -i 's/METHODS=nullptr/METHODS=NULL/g' src/test/torcontrol_tests.cpp src/torcontrol.cpp sed -i 's/nullptr certificates/NULL certificates/g' src/qt/paymentserver.cpp sed -i 's/"nullptr"/"NULL"/g' src/torcontrol.cpp src/test/torcontrol_tests.cpp -END VERIFY SCRIPT-
2017-08-07 07:36:37 +02:00
BOOST_CHECK(info2 == nullptr);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
}
BOOST_AUTO_TEST_CASE(addrman_getaddr)
{
CAddrManTest addrman;
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: Sanity check, GetAddr should never return anything if addrman
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
// is empty.
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 0);
Refactoring: Removed using namespace <xxx> from bench/ and test/ source files.
2016-12-05 08:03:53 +01:00
std::vector<CAddress> vAddr1 = addrman.GetAddr();
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(vAddr1.size(), 0);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CAddress addr1 = CAddress(ResolveService("250.250.2.1", 8333), NODE_NONE);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
addr1.nTime = GetAdjustedTime(); // Set time so isTerrible = false
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CAddress addr2 = CAddress(ResolveService("250.251.2.2", 9999), NODE_NONE);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
addr2.nTime = GetAdjustedTime();
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CAddress addr3 = CAddress(ResolveService("251.252.2.3", 8333), NODE_NONE);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
addr3.nTime = GetAdjustedTime();
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CAddress addr4 = CAddress(ResolveService("252.253.3.4", 8333), NODE_NONE);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
addr4.nTime = GetAdjustedTime();
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CAddress addr5 = CAddress(ResolveService("252.254.4.5", 8333), NODE_NONE);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
addr5.nTime = GetAdjustedTime();
net: Split resolving out of CNetAddr
2016-05-31 19:05:52 +02:00
CNetAddr source1 = ResolveIP("250.1.2.1");
CNetAddr source2 = ResolveIP("250.2.3.3");
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: Ensure GetAddr works with new addresses.
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
addrman.Add(addr1, source1);
addrman.Add(addr2, source2);
addrman.Add(addr3, source1);
addrman.Add(addr4, source2);
addrman.Add(addr5, source1);
// GetAddr returns 23% of addresses, 23% of 5 is 1 rounded down.
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.GetAddr().size(), 1);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: Ensure GetAddr works with new and tried addresses.
Introduce enum ServiceFlags for service flags
2016-06-08 19:12:22 +02:00
addrman.Good(CAddress(addr1, NODE_NONE));
addrman.Good(CAddress(addr2, NODE_NONE));
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(addrman.GetAddr().size(), 1);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: Ensure GetAddr still returns 23% when addrman has many addrs.
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
for (unsigned int i = 1; i < (8 * 256); i++) {
int octet1 = i % 256;
[tests] Update Unit Test for addrman.h/addrman.cpp Add test for adding multiple addresses to address manager Clean up unnecessary modulo operations Add test for GetNewBucket's alternate method signature
2017-04-27 03:15:07 +02:00
int octet2 = i >> 8 % 256;
Add test-before-evict discipline to addrman Changes addrman to use the test-before-evict discipline in which an address is to be evicted from the tried table is first tested and if it is still online it is not evicted. Adds tests to provide test coverage for this change. This change was suggested as Countermeasure 3 in Eclipse Attacks on Bitcoin’s Peer-to-Peer Network, Ethan Heilman, Alison Kendler, Aviv Zohar, Sharon Goldberg. ePrint Archive Report 2015/263. March 2015.
2016-10-27 19:55:39 +02:00
std::string strAddr = std::to_string(octet1) + "." + std::to_string(octet2) + ".1.23";
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CAddress addr = CAddress(ResolveService(strAddr), NODE_NONE);
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
// Ensure that for all addrs in addrman, isTerrible == false.
addr.nTime = GetAdjustedTime();
net: Split resolving out of CNetAddr
2016-05-31 19:05:52 +02:00
addrman.Add(addr, ResolveIP(strAddr));
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
if (i % 8 == 0)
addrman.Good(addr);
}
Refactoring: Removed using namespace <xxx> from bench/ and test/ source files.
2016-12-05 08:03:53 +01:00
std::vector<CAddress> vAddr = addrman.GetAddr();
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
size_t percent23 = (addrman.size() * 23) / 100;
[tests] Update Unit Test for addrman.h/addrman.cpp Add test for adding multiple addresses to address manager Clean up unnecessary modulo operations Add test for GetNewBucket's alternate method signature
2017-04-27 03:15:07 +02:00
BOOST_CHECK_EQUAL(vAddr.size(), percent23);
BOOST_CHECK_EQUAL(vAddr.size(), 461);
[trivial] Fix typos in comments
2017-03-21 19:49:08 +01:00
// (Addrman.size() < number of addresses added) due to address collisions.
[tests] Update Unit Test for addrman.h/addrman.cpp Add test for adding multiple addresses to address manager Clean up unnecessary modulo operations Add test for GetNewBucket's alternate method signature
2017-04-27 03:15:07 +02:00
BOOST_CHECK_EQUAL(addrman.size(), 2006);
Creates unittests for addrman, makes addrman testable. Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
2015-09-22 21:24:16 +02:00
}
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
BOOST_AUTO_TEST_CASE(caddrinfo_get_tried_bucket)
{
CAddrManTest addrman;
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CAddress addr1 = CAddress(ResolveService("250.1.1.1", 8333), NODE_NONE);
CAddress addr2 = CAddress(ResolveService("250.1.1.1", 9999), NODE_NONE);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
net: Split resolving out of CNetAddr
2016-05-31 19:05:52 +02:00
CNetAddr source1 = ResolveIP("250.1.1.1");
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
CAddrInfo info1 = CAddrInfo(addr1, source1);
uint256 nKey1 = (uint256)(CHashWriter(SER_GETHASH, 0) << 1).GetHash();
uint256 nKey2 = (uint256)(CHashWriter(SER_GETHASH, 0) << 2).GetHash();
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(info1.GetTriedBucket(nKey1), 40);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: Make sure key actually randomizes bucket placement. A fail on
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
// this test could be a security issue.
BOOST_CHECK(info1.GetTriedBucket(nKey1) != info1.GetTriedBucket(nKey2));
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: Two addresses with same IP but different ports can map to
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
// different buckets because they have different keys.
CAddrInfo info2 = CAddrInfo(addr2, source1);
BOOST_CHECK(info1.GetKey() != info2.GetKey());
BOOST_CHECK(info1.GetTriedBucket(nKey1) != info2.GetTriedBucket(nKey1));
Refactoring: Removed using namespace <xxx> from bench/ and test/ source files.
2016-12-05 08:03:53 +01:00
std::set<int> buckets;
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
for (int i = 0; i < 255; i++) {
CAddrInfo infoi = CAddrInfo(
Add test-before-evict discipline to addrman Changes addrman to use the test-before-evict discipline in which an address is to be evicted from the tried table is first tested and if it is still online it is not evicted. Adds tests to provide test coverage for this change. This change was suggested as Countermeasure 3 in Eclipse Attacks on Bitcoin’s Peer-to-Peer Network, Ethan Heilman, Alison Kendler, Aviv Zohar, Sharon Goldberg. ePrint Archive Report 2015/263. March 2015.
2016-10-27 19:55:39 +02:00
CAddress(ResolveService("250.1.1." + std::to_string(i)), NODE_NONE),
ResolveIP("250.1.1." + std::to_string(i)));
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
int bucket = infoi.GetTriedBucket(nKey1);
buckets.insert(bucket);
}
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: IP addresses in the same group (\16 prefix for IPv4) should
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
// never get more than 8 buckets
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(buckets.size(), 8);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
buckets.clear();
for (int j = 0; j < 255; j++) {
CAddrInfo infoj = CAddrInfo(
Add test-before-evict discipline to addrman Changes addrman to use the test-before-evict discipline in which an address is to be evicted from the tried table is first tested and if it is still online it is not evicted. Adds tests to provide test coverage for this change. This change was suggested as Countermeasure 3 in Eclipse Attacks on Bitcoin’s Peer-to-Peer Network, Ethan Heilman, Alison Kendler, Aviv Zohar, Sharon Goldberg. ePrint Archive Report 2015/263. March 2015.
2016-10-27 19:55:39 +02:00
CAddress(ResolveService("250." + std::to_string(j) + ".1.1"), NODE_NONE),
ResolveIP("250." + std::to_string(j) + ".1.1"));
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
int bucket = infoj.GetTriedBucket(nKey1);
buckets.insert(bucket);
}
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: IP addresses in the different groups should map to more than
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
// 8 buckets.
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(buckets.size(), 160);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
}
BOOST_AUTO_TEST_CASE(caddrinfo_get_new_bucket)
{
CAddrManTest addrman;
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CAddress addr1 = CAddress(ResolveService("250.1.2.1", 8333), NODE_NONE);
CAddress addr2 = CAddress(ResolveService("250.1.2.1", 9999), NODE_NONE);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
net: Split resolving out of CNetAddr
2016-05-31 19:05:52 +02:00
CNetAddr source1 = ResolveIP("250.1.2.1");
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
CAddrInfo info1 = CAddrInfo(addr1, source1);
uint256 nKey1 = (uint256)(CHashWriter(SER_GETHASH, 0) << 1).GetHash();
uint256 nKey2 = (uint256)(CHashWriter(SER_GETHASH, 0) << 2).GetHash();
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: Make sure the buckets are what we expect
BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1), 786);
BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1, source1), 786);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: Make sure key actually randomizes bucket placement. A fail on
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
// this test could be a security issue.
BOOST_CHECK(info1.GetNewBucket(nKey1) != info1.GetNewBucket(nKey2));
Fix typos
2018-03-18 15:26:45 +01:00
// Test: Ports should not affect bucket placement in the addr
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
CAddrInfo info2 = CAddrInfo(addr2, source1);
BOOST_CHECK(info1.GetKey() != info2.GetKey());
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(info1.GetNewBucket(nKey1), info2.GetNewBucket(nKey1));
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
Refactoring: Removed using namespace <xxx> from bench/ and test/ source files.
2016-12-05 08:03:53 +01:00
std::set<int> buckets;
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
for (int i = 0; i < 255; i++) {
CAddrInfo infoi = CAddrInfo(
Add test-before-evict discipline to addrman Changes addrman to use the test-before-evict discipline in which an address is to be evicted from the tried table is first tested and if it is still online it is not evicted. Adds tests to provide test coverage for this change. This change was suggested as Countermeasure 3 in Eclipse Attacks on Bitcoin’s Peer-to-Peer Network, Ethan Heilman, Alison Kendler, Aviv Zohar, Sharon Goldberg. ePrint Archive Report 2015/263. March 2015.
2016-10-27 19:55:39 +02:00
CAddress(ResolveService("250.1.1." + std::to_string(i)), NODE_NONE),
ResolveIP("250.1.1." + std::to_string(i)));
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
int bucket = infoi.GetNewBucket(nKey1);
buckets.insert(bucket);
}
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: IP addresses in the same group (\16 prefix for IPv4) should
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
// always map to the same bucket.
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
BOOST_CHECK_EQUAL(buckets.size(), 1);
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
buckets.clear();
for (int j = 0; j < 4 * 255; j++) {
CAddrInfo infoj = CAddrInfo(CAddress(
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
ResolveService(
Add test-before-evict discipline to addrman Changes addrman to use the test-before-evict discipline in which an address is to be evicted from the tried table is first tested and if it is still online it is not evicted. Adds tests to provide test coverage for this change. This change was suggested as Countermeasure 3 in Eclipse Attacks on Bitcoin’s Peer-to-Peer Network, Ethan Heilman, Alison Kendler, Aviv Zohar, Sharon Goldberg. ePrint Archive Report 2015/263. March 2015.
2016-10-27 19:55:39 +02:00
std::to_string(250 + (j / 255)) + "." + std::to_string(j % 256) + ".1.1"), NODE_NONE),
net: Split resolving out of CNetAddr
2016-05-31 19:05:52 +02:00
ResolveIP("251.4.1.1"));
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
int bucket = infoj.GetNewBucket(nKey1);
buckets.insert(bucket);
}
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: IP addresses in the same source groups should map to no more
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
// than 64 buckets.
BOOST_CHECK(buckets.size() <= 64);
buckets.clear();
for (int p = 0; p < 255; p++) {
CAddrInfo infoj = CAddrInfo(
net: Split resolving out of CService
2016-05-31 19:51:11 +02:00
CAddress(ResolveService("250.1.1.1"), NODE_NONE),
Add test-before-evict discipline to addrman Changes addrman to use the test-before-evict discipline in which an address is to be evicted from the tried table is first tested and if it is still online it is not evicted. Adds tests to provide test coverage for this change. This change was suggested as Countermeasure 3 in Eclipse Attacks on Bitcoin’s Peer-to-Peer Network, Ethan Heilman, Alison Kendler, Aviv Zohar, Sharon Goldberg. ePrint Archive Report 2015/263. March 2015.
2016-10-27 19:55:39 +02:00
ResolveIP("250." + std::to_string(p) + ".1.1"));
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
int bucket = infoj.GetNewBucket(nKey1);
buckets.insert(bucket);
}
[tests] Clean up addrman_tests.cpp Cleanup request from #10287. Change "Test #:" comments to "Test:" Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...) Remove three unnecessary if statements
2017-05-09 18:11:12 +02:00
// Test: IP addresses in the different source groups should map to more
Increase test coverage for addrman and addrinfo Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
2015-12-13 04:34:08 +01:00
// than 64 buckets.
BOOST_CHECK(buckets.size() > 64);
}
Add test-before-evict discipline to addrman Changes addrman to use the test-before-evict discipline in which an address is to be evicted from the tried table is first tested and if it is still online it is not evicted. Adds tests to provide test coverage for this change. This change was suggested as Countermeasure 3 in Eclipse Attacks on Bitcoin’s Peer-to-Peer Network, Ethan Heilman, Alison Kendler, Aviv Zohar, Sharon Goldberg. ePrint Archive Report 2015/263. March 2015.
2016-10-27 19:55:39 +02:00
BOOST_AUTO_TEST_CASE(addrman_selecttriedcollision)
{
CAddrManTest addrman;
// Set addrman addr placement to be deterministic.
addrman.MakeDeterministic();
BOOST_CHECK(addrman.size() == 0);
// Empty addrman should return blank addrman info.
BOOST_CHECK(addrman.SelectTriedCollision().ToString() == "[::]:0");
// Add twenty two addresses.
CNetAddr source = ResolveIP("252.2.2.2");
for (unsigned int i = 1; i < 23; i++) {
CService addr = ResolveService("250.1.1."+std::to_string(i));
addrman.Add(CAddress(addr, NODE_NONE), source);
addrman.Good(addr);
// No collisions yet.
BOOST_CHECK(addrman.size() == i);
BOOST_CHECK(addrman.SelectTriedCollision().ToString() == "[::]:0");
}
// Ensure Good handles duplicates well.
for (unsigned int i = 1; i < 23; i++) {
CService addr = ResolveService("250.1.1."+std::to_string(i));
addrman.Good(addr);
BOOST_CHECK(addrman.size() == 22);
BOOST_CHECK(addrman.SelectTriedCollision().ToString() == "[::]:0");
}
}
BOOST_AUTO_TEST_CASE(addrman_noevict)
{
CAddrManTest addrman;
// Set addrman addr placement to be deterministic.
addrman.MakeDeterministic();
// Add twenty two addresses.
CNetAddr source = ResolveIP("252.2.2.2");
for (unsigned int i = 1; i < 23; i++) {
CService addr = ResolveService("250.1.1."+std::to_string(i));
addrman.Add(CAddress(addr, NODE_NONE), source);
addrman.Good(addr);
// No collision yet.
BOOST_CHECK(addrman.size() == i);
BOOST_CHECK(addrman.SelectTriedCollision().ToString() == "[::]:0");
}
// Collision between 23 and 19.
CService addr23 = ResolveService("250.1.1.23");
addrman.Add(CAddress(addr23, NODE_NONE), source);
addrman.Good(addr23);
BOOST_CHECK(addrman.size() == 23);
BOOST_CHECK(addrman.SelectTriedCollision().ToString() == "250.1.1.19:0");
// 23 should be discarded and 19 not evicted.
addrman.ResolveCollisions();
BOOST_CHECK(addrman.SelectTriedCollision().ToString() == "[::]:0");
// Lets create two collisions.
for (unsigned int i = 24; i < 33; i++) {
CService addr = ResolveService("250.1.1."+std::to_string(i));
addrman.Add(CAddress(addr, NODE_NONE), source);
addrman.Good(addr);
BOOST_CHECK(addrman.size() == i);
BOOST_CHECK(addrman.SelectTriedCollision().ToString() == "[::]:0");
}
// Cause a collision.
CService addr33 = ResolveService("250.1.1.33");
addrman.Add(CAddress(addr33, NODE_NONE), source);
addrman.Good(addr33);
BOOST_CHECK(addrman.size() == 33);
BOOST_CHECK(addrman.SelectTriedCollision().ToString() == "250.1.1.27:0");
// Cause a second collision.
addrman.Add(CAddress(addr23, NODE_NONE), source);
addrman.Good(addr23);
BOOST_CHECK(addrman.size() == 33);
BOOST_CHECK(addrman.SelectTriedCollision().ToString() != "[::]:0");
addrman.ResolveCollisions();
BOOST_CHECK(addrman.SelectTriedCollision().ToString() == "[::]:0");
}
BOOST_AUTO_TEST_CASE(addrman_evictionworks)
{
CAddrManTest addrman;
// Set addrman addr placement to be deterministic.
addrman.MakeDeterministic();
BOOST_CHECK(addrman.size() == 0);
// Empty addrman should return blank addrman info.
BOOST_CHECK(addrman.SelectTriedCollision().ToString() == "[::]:0");
// Add twenty two addresses.
CNetAddr source = ResolveIP("252.2.2.2");
for (unsigned int i = 1; i < 23; i++) {
CService addr = ResolveService("250.1.1."+std::to_string(i));
addrman.Add(CAddress(addr, NODE_NONE), source);
addrman.Good(addr);
// No collision yet.
BOOST_CHECK(addrman.size() == i);
BOOST_CHECK(addrman.SelectTriedCollision().ToString() == "[::]:0");
}
// Collision between 23 and 19.
CService addr = ResolveService("250.1.1.23");
addrman.Add(CAddress(addr, NODE_NONE), source);
addrman.Good(addr);
BOOST_CHECK(addrman.size() == 23);
CAddrInfo info = addrman.SelectTriedCollision();
BOOST_CHECK(info.ToString() == "250.1.1.19:0");
// Ensure test of address fails, so that it is evicted.
addrman.SimConnFail(info);
// Should swap 23 for 19.
addrman.ResolveCollisions();
BOOST_CHECK(addrman.SelectTriedCollision().ToString() == "[::]:0");
// If 23 was swapped for 19, then this should cause no collisions.
addrman.Add(CAddress(addr, NODE_NONE), source);
addrman.Good(addr);
BOOST_CHECK(addrman.SelectTriedCollision().ToString() == "[::]:0");
// If we insert 19 is should collide with 23.
CService addr19 = ResolveService("250.1.1.19");
addrman.Add(CAddress(addr19, NODE_NONE), source);
addrman.Good(addr19);
BOOST_CHECK(addrman.SelectTriedCollision().ToString() == "250.1.1.23:0");
addrman.ResolveCollisions();
BOOST_CHECK(addrman.SelectTriedCollision().ToString() == "[::]:0");
}
[test] Remove redundant print in addrman_tests
2016-09-22 12:51:50 +02:00
BOOST_AUTO_TEST_SUITE_END()
Reference in a new issue Copy permalink