LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity
lbrycrd/src/qt/transactiondesc.cpp

336 lines
13 KiB
C++
Raw Normal View History

Update copyright headers to 2018
2018-07-27 00:36:45 +02:00
// Copyright (c) 2011-2018 The Bitcoin Core developers
Remove references to X11 licence
2014-12-13 05:09:33 +01:00
// Distributed under the MIT software license, see the accompanying
qt: add license header to source files Closes #839
2013-11-04 16:20:43 +01:00
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
build: Add --disable-bip70 configure option This patch adds a --disable-bip70 configure option that disables BIP70 payment request support. When disabled, this removes the dependency of the GUI on OpenSSL and Protobuf.
2017-11-06 19:12:47 +01:00
#ifdef HAVE_CONFIG_H
#include <config/bitcoin-config.h>
#endif
scripted-diff: Replace #include "" with #include <> (ryanofsky) -BEGIN VERIFY SCRIPT- for f in \ src/*.cpp \ src/*.h \ src/bench/*.cpp \ src/bench/*.h \ src/compat/*.cpp \ src/compat/*.h \ src/consensus/*.cpp \ src/consensus/*.h \ src/crypto/*.cpp \ src/crypto/*.h \ src/crypto/ctaes/*.h \ src/policy/*.cpp \ src/policy/*.h \ src/primitives/*.cpp \ src/primitives/*.h \ src/qt/*.cpp \ src/qt/*.h \ src/qt/test/*.cpp \ src/qt/test/*.h \ src/rpc/*.cpp \ src/rpc/*.h \ src/script/*.cpp \ src/script/*.h \ src/support/*.cpp \ src/support/*.h \ src/support/allocators/*.h \ src/test/*.cpp \ src/test/*.h \ src/wallet/*.cpp \ src/wallet/*.h \ src/wallet/test/*.cpp \ src/wallet/test/*.h \ src/zmq/*.cpp \ src/zmq/*.h do base=${f%/*}/ relbase=${base#src/} sed -i "s:#include \"\(.*\)\"\(.*\):if test -e \$base'\\1'; then echo \"#include <\"\$relbase\"\\1>\\2\"; else echo \"#include <\\1>\\2\"; fi:e" $f done -END VERIFY SCRIPT-
2017-11-10 01:57:53 +01:00
#include <qt/transactiondesc.h>
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
scripted-diff: Replace #include "" with #include <> (ryanofsky) -BEGIN VERIFY SCRIPT- for f in \ src/*.cpp \ src/*.h \ src/bench/*.cpp \ src/bench/*.h \ src/compat/*.cpp \ src/compat/*.h \ src/consensus/*.cpp \ src/consensus/*.h \ src/crypto/*.cpp \ src/crypto/*.h \ src/crypto/ctaes/*.h \ src/policy/*.cpp \ src/policy/*.h \ src/primitives/*.cpp \ src/primitives/*.h \ src/qt/*.cpp \ src/qt/*.h \ src/qt/test/*.cpp \ src/qt/test/*.h \ src/rpc/*.cpp \ src/rpc/*.h \ src/script/*.cpp \ src/script/*.h \ src/support/*.cpp \ src/support/*.h \ src/support/allocators/*.h \ src/test/*.cpp \ src/test/*.h \ src/wallet/*.cpp \ src/wallet/*.h \ src/wallet/test/*.cpp \ src/wallet/test/*.h \ src/zmq/*.cpp \ src/zmq/*.h do base=${f%/*}/ relbase=${base#src/} sed -i "s:#include \"\(.*\)\"\(.*\):if test -e \$base'\\1'; then echo \"#include <\"\$relbase\"\\1>\\2\"; else echo \"#include <\\1>\\2\"; fi:e" $f done -END VERIFY SCRIPT-
2017-11-10 01:57:53 +01:00
#include <qt/bitcoinunits.h>
#include <qt/guiutil.h>
#include <qt/paymentserver.h>
#include <qt/transactionrecord.h>
Cleanup code using forward declarations. Use misc methods of avoiding unnecesary header includes. Replace int typedefs with int##_t from stdint.h. Replace PRI64[xdu] with PRI[xdu]64 from inttypes.h. Normalize QT_VERSION ifs where possible. Resolve some indirect dependencies as direct ones. Remove extern declarations from .cpp files.
2013-04-13 07:13:08 +02:00
scripted-diff: Replace #include "" with #include <> (ryanofsky) -BEGIN VERIFY SCRIPT- for f in \ src/*.cpp \ src/*.h \ src/bench/*.cpp \ src/bench/*.h \ src/compat/*.cpp \ src/compat/*.h \ src/consensus/*.cpp \ src/consensus/*.h \ src/crypto/*.cpp \ src/crypto/*.h \ src/crypto/ctaes/*.h \ src/policy/*.cpp \ src/policy/*.h \ src/primitives/*.cpp \ src/primitives/*.h \ src/qt/*.cpp \ src/qt/*.h \ src/qt/test/*.cpp \ src/qt/test/*.h \ src/rpc/*.cpp \ src/rpc/*.h \ src/script/*.cpp \ src/script/*.h \ src/support/*.cpp \ src/support/*.h \ src/support/allocators/*.h \ src/test/*.cpp \ src/test/*.h \ src/wallet/*.cpp \ src/wallet/*.h \ src/wallet/test/*.cpp \ src/wallet/test/*.h \ src/zmq/*.cpp \ src/zmq/*.h do base=${f%/*}/ relbase=${base#src/} sed -i "s:#include \"\(.*\)\"\(.*\):if test -e \$base'\\1'; then echo \"#include <\"\$relbase\"\\1>\\2\"; else echo \"#include <\\1>\\2\"; fi:e" $f done -END VERIFY SCRIPT-
2017-11-10 01:57:53 +01:00
#include <consensus/consensus.h>
scripted-diff: Avoid `interface` keyword to fix windows gitian build Rename `interface` to `interfaces` Build failure reported by Chun Kuan Lee <ken2812221@gmail.com> https://github.com/bitcoin/bitcoin/pull/10244#issuecomment-379434756 -BEGIN VERIFY SCRIPT- git mv src/interface src/interfaces ren() { git grep -l "$1" | xargs sed -i "s,$1,$2,g"; } ren interface/ interfaces/ ren interface:: interfaces:: ren BITCOIN_INTERFACE_ BITCOIN_INTERFACES_ ren "namespace interface" "namespace interfaces" -END VERIFY SCRIPT-
2018-04-07 09:42:02 +02:00
#include <interfaces/node.h>
Split key_io (address/key encodings) off from base58
2017-09-20 03:12:25 +02:00
#include <key_io.h>
scripted-diff: Replace #include "" with #include <> (ryanofsky) -BEGIN VERIFY SCRIPT- for f in \ src/*.cpp \ src/*.h \ src/bench/*.cpp \ src/bench/*.h \ src/compat/*.cpp \ src/compat/*.h \ src/consensus/*.cpp \ src/consensus/*.h \ src/crypto/*.cpp \ src/crypto/*.h \ src/crypto/ctaes/*.h \ src/policy/*.cpp \ src/policy/*.h \ src/primitives/*.cpp \ src/primitives/*.h \ src/qt/*.cpp \ src/qt/*.h \ src/qt/test/*.cpp \ src/qt/test/*.h \ src/rpc/*.cpp \ src/rpc/*.h \ src/script/*.cpp \ src/script/*.h \ src/support/*.cpp \ src/support/*.h \ src/support/allocators/*.h \ src/test/*.cpp \ src/test/*.h \ src/wallet/*.cpp \ src/wallet/*.h \ src/wallet/test/*.cpp \ src/wallet/test/*.h \ src/zmq/*.cpp \ src/zmq/*.h do base=${f%/*}/ relbase=${base#src/} sed -i "s:#include \"\(.*\)\"\(.*\):if test -e \$base'\\1'; then echo \"#include <\"\$relbase\"\\1>\\2\"; else echo \"#include <\\1>\\2\"; fi:e" $f done -END VERIFY SCRIPT-
2017-11-10 01:57:53 +01:00
#include <validation.h>
#include <script/script.h>
#include <timedata.h>
scripted-diff: Move util files to separate directory. -BEGIN VERIFY SCRIPT- mkdir -p src/util git mv src/util.h src/util/system.h git mv src/util.cpp src/util/system.cpp git mv src/utilmemory.h src/util/memory.h git mv src/utilmoneystr.h src/util/moneystr.h git mv src/utilmoneystr.cpp src/util/moneystr.cpp git mv src/utilstrencodings.h src/util/strencodings.h git mv src/utilstrencodings.cpp src/util/strencodings.cpp git mv src/utiltime.h src/util/time.h git mv src/utiltime.cpp src/util/time.cpp sed -i 's/<util\.h>/<util\/system\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmemory\.h>/<util\/memory\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmoneystr\.h>/<util\/moneystr\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilstrencodings\.h>/<util\/strencodings\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utiltime\.h>/<util\/time\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/BITCOIN_UTIL_H/BITCOIN_UTIL_SYSTEM_H/g' src/util/system.h sed -i 's/BITCOIN_UTILMEMORY_H/BITCOIN_UTIL_MEMORY_H/g' src/util/memory.h sed -i 's/BITCOIN_UTILMONEYSTR_H/BITCOIN_UTIL_MONEYSTR_H/g' src/util/moneystr.h sed -i 's/BITCOIN_UTILSTRENCODINGS_H/BITCOIN_UTIL_STRENCODINGS_H/g' src/util/strencodings.h sed -i 's/BITCOIN_UTILTIME_H/BITCOIN_UTIL_TIME_H/g' src/util/time.h sed -i 's/ util\.\(h\|cpp\)/ util\/system\.\1/g' src/Makefile.am sed -i 's/utilmemory\.\(h\|cpp\)/util\/memory\.\1/g' src/Makefile.am sed -i 's/utilmoneystr\.\(h\|cpp\)/util\/moneystr\.\1/g' src/Makefile.am sed -i 's/utilstrencodings\.\(h\|cpp\)/util\/strencodings\.\1/g' src/Makefile.am sed -i 's/utiltime\.\(h\|cpp\)/util\/time\.\1/g' src/Makefile.am sed -i 's/-> util ->/-> util\/system ->/' test/lint/lint-circular-dependencies.sh sed -i 's/src\/util\.cpp/src\/util\/system\.cpp/g' test/lint/lint-format-strings.py test/lint/lint-locale-dependence.sh sed -i 's/src\/utilmoneystr\.cpp/src\/util\/moneystr\.cpp/g' test/lint/lint-locale-dependence.sh sed -i 's/src\/utilstrencodings\.\(h\|cpp\)/src\/util\/strencodings\.\1/g' test/lint/lint-locale-dependence.sh sed -i 's/src\\utilstrencodings\.cpp/src\\util\\strencodings\.cpp/' build_msvc/libbitcoinconsensus/libbitcoinconsensus.vcxproj -END VERIFY SCRIPT-
2018-10-23 00:51:11 +02:00
#include <util/system.h>
scripted-diff: Replace #include "" with #include <> (ryanofsky) -BEGIN VERIFY SCRIPT- for f in \ src/*.cpp \ src/*.h \ src/bench/*.cpp \ src/bench/*.h \ src/compat/*.cpp \ src/compat/*.h \ src/consensus/*.cpp \ src/consensus/*.h \ src/crypto/*.cpp \ src/crypto/*.h \ src/crypto/ctaes/*.h \ src/policy/*.cpp \ src/policy/*.h \ src/primitives/*.cpp \ src/primitives/*.h \ src/qt/*.cpp \ src/qt/*.h \ src/qt/test/*.cpp \ src/qt/test/*.h \ src/rpc/*.cpp \ src/rpc/*.h \ src/script/*.cpp \ src/script/*.h \ src/support/*.cpp \ src/support/*.h \ src/support/allocators/*.h \ src/test/*.cpp \ src/test/*.h \ src/wallet/*.cpp \ src/wallet/*.h \ src/wallet/test/*.cpp \ src/wallet/test/*.h \ src/zmq/*.cpp \ src/zmq/*.h do base=${f%/*}/ relbase=${base#src/} sed -i "s:#include \"\(.*\)\"\(.*\):if test -e \$base'\\1'; then echo \"#include <\"\$relbase\"\\1>\\2\"; else echo \"#include <\\1>\\2\"; fi:e" $f done -END VERIFY SCRIPT-
2017-11-10 01:57:53 +01:00
#include <wallet/db.h>
#include <wallet/wallet.h>
Show a transaction's virtual size in its details dialog.
2018-03-01 21:55:01 +01:00
#include <policy/policy.h>
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
Cleanup code using forward declarations. Use misc methods of avoiding unnecesary header includes. Replace int typedefs with int##_t from stdint.h. Replace PRI64[xdu] with PRI[xdu]64 from inttypes.h. Normalize QT_VERSION ifs where possible. Resolve some indirect dependencies as direct ones. Remove extern declarations from .cpp files.
2013-04-13 07:13:08 +02:00
#include <stdint.h>
Bitcoin-Qt: massive header and cpp cleanup - try to enforce the same style to all Qt related files - remove unneeded includes from the files - add missing Q_OBJECT, QT_BEGIN_NAMESPACE / QT_END_NAMESPACE - prepares for a pull-req to include Qt5 compatibility
2013-01-23 21:51:02 +01:00
#include <string>
Remove unused `adjustedTime` parameter qt: After merging #13622 the `adjustedTime` is not used any more in wallet related functions.
2018-10-23 16:36:46 +02:00
QString TransactionDesc::FormatTxStatus(const interfaces::WalletTx& wtx, const interfaces::WalletTxStatus& status, bool inMempool, int numBlocks)
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
{
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
if (!status.is_final)
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
{
Make CWalletTx store a CTransactionRef instead of inheriting
2016-11-12 01:54:51 +01:00
if (wtx.tx->nLockTime < LOCKTIME_THRESHOLD)
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
return tr("Open for %n more block(s)", "", wtx.tx->nLockTime - numBlocks);
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
else
Make CWalletTx store a CTransactionRef instead of inheriting
2016-11-12 01:54:51 +01:00
return tr("Open until %1").arg(GUIUtil::dateTimeStr(wtx.tx->nLockTime));
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
}
else
{
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
int nDepth = status.depth_in_main_chain;
Handle "conflicted" transactions properly Extend CMerkleTx::GetDepthInMainChain with the concept of a "conflicted" transaction-- a transaction generated by the wallet that is not in the main chain or in the mempool, and, therefore, will likely never be confirmed. GetDepthInMainChain() now returns -1 for conflicted transactions (0 for unconfirmed-but-in-the-mempool, and >1 for confirmed). This makes getbalance, getbalance '*', and listunspent all agree when there are mutated transactions in the wallet. Before: listunspent: one 49BTC output getbalance: 96 BTC (change counted twice) getbalance '*': 46 BTC (spends counted twice) After: all agree, 49 BTC available to spend.
2014-02-12 19:43:07 +01:00
if (nDepth < 0)
[Qt] add InMempool() info to transaction details
2015-11-30 16:15:15 +01:00
return tr("conflicted with a transaction with %1 confirmations").arg(-nDepth);
else if (nDepth == 0)
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
return tr("0/unconfirmed, %1").arg((inMempool ? tr("in memory pool") : tr("not in memory pool"))) + (status.is_abandoned ? ", "+tr("abandoned") : "");
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
else if (nDepth < 6)
QtUI code cleanup / comment improvements
2011-08-08 17:38:17 +02:00
return tr("%1/unconfirmed").arg(nDepth);
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
else
QtUI code cleanup / comment improvements
2011-08-08 17:38:17 +02:00
return tr("%1 confirmations").arg(nDepth);
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
}
}
scripted-diff: Avoid `interface` keyword to fix windows gitian build Rename `interface` to `interfaces` Build failure reported by Chun Kuan Lee <ken2812221@gmail.com> https://github.com/bitcoin/bitcoin/pull/10244#issuecomment-379434756 -BEGIN VERIFY SCRIPT- git mv src/interface src/interfaces ren() { git grep -l "$1" | xargs sed -i "s,$1,$2,g"; } ren interface/ interfaces/ ren interface:: interfaces:: ren BITCOIN_INTERFACE_ BITCOIN_INTERFACES_ ren "namespace interface" "namespace interfaces" -END VERIFY SCRIPT-
2018-04-07 09:42:02 +02:00
QString TransactionDesc::toHTML(interfaces::Node& node, interfaces::Wallet& wallet, TransactionRecord *rec, int unit)
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
{
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
int numBlocks;
scripted-diff: Avoid `interface` keyword to fix windows gitian build Rename `interface` to `interfaces` Build failure reported by Chun Kuan Lee <ken2812221@gmail.com> https://github.com/bitcoin/bitcoin/pull/10244#issuecomment-379434756 -BEGIN VERIFY SCRIPT- git mv src/interface src/interfaces ren() { git grep -l "$1" | xargs sed -i "s,$1,$2,g"; } ren interface/ interfaces/ ren interface:: interfaces:: ren BITCOIN_INTERFACE_ BITCOIN_INTERFACES_ ren "namespace interface" "namespace interfaces" -END VERIFY SCRIPT-
2018-04-07 09:42:02 +02:00
interfaces::WalletTxStatus status;
interfaces::WalletOrderForm orderForm;
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
bool inMempool;
Remove unused `adjustedTime` parameter qt: After merging #13622 the `adjustedTime` is not used any more in wallet related functions.
2018-10-23 16:36:46 +02:00
interfaces::WalletTx wtx = wallet.getWalletTxDetails(rec->hash, status, orderForm, inMempool, numBlocks);
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
QtUI code cleanup / comment improvements
2011-08-08 17:38:17 +02:00
QString strHTML;
Use scoped locks instead of CRITICAL_BLOCK
2012-04-06 18:39:12 +02:00
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
strHTML.reserve(4000);
strHTML += "<html><font face='verdana, arial, helvetica, sans-serif'>";
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
int64_t nTime = wtx.time;
CAmount nCredit = wtx.credit;
CAmount nDebit = wtx.debit;
Use a typedef for monetary values
2014-04-23 00:46:19 +02:00
CAmount nNet = nCredit - nDebit;
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
Remove unused `adjustedTime` parameter qt: After merging #13622 the `adjustedTime` is not used any more in wallet related functions.
2018-10-23 16:36:46 +02:00
strHTML += "<b>" + tr("Status") + ":</b> " + FormatTxStatus(wtx, status, inMempool, numBlocks);
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
strHTML += "<br>";
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
strHTML += "<b>" + tr("Date") + ":</b> " + (nTime ? GUIUtil::dateTimeStr(nTime) : "") + "<br>";
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
//
// From
//
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
if (wtx.is_coinbase)
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
{
strHTML += "<b>" + tr("Source") + ":</b> " + tr("Generated") + "<br>";
}
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
else if (wtx.value_map.count("from") && !wtx.value_map["from"].empty())
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
{
// Online transaction
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
strHTML += "<b>" + tr("From") + ":</b> " + GUIUtil::HtmlEscape(wtx.value_map["from"]) + "<br>";
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
}
else
{
// Offline transaction
if (nNet > 0)
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
{
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
// Credit
Remove duplicate destination decoding
2017-09-06 22:44:33 +02:00
CTxDestination address = DecodeDestination(rec->address);
if (IsValidDestination(address)) {
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
std::string name;
isminetype ismine;
Add purpose arg to Wallet::getAddress Also make all arguments to getAddress required and document args at call sites.
2018-04-10 17:50:10 +02:00
if (wallet.getAddress(address, &name, &ismine, /* purpose= */ nullptr))
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
{
Fixed some stuff in TransactionDesc
2014-06-19 01:42:39 +02:00
strHTML += "<b>" + tr("From") + ":</b> " + tr("unknown") + "<br>";
strHTML += "<b>" + tr("To") + ":</b> ";
strHTML += GUIUtil::HtmlEscape(rec->address);
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
QString addressOwned = ismine == ISMINE_SPENDABLE ? tr("own address") : tr("watch-only");
if (!name.empty())
strHTML += " (" + addressOwned + ", " + tr("label") + ": " + GUIUtil::HtmlEscape(name) + ")";
Fixed some stuff in TransactionDesc
2014-06-19 01:42:39 +02:00
else
strHTML += " (" + addressOwned + ")";
strHTML += "<br>";
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
}
}
}
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
}
//
// To
//
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
if (wtx.value_map.count("to") && !wtx.value_map["to"].empty())
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
{
// Online transaction
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
std::string strAddress = wtx.value_map["to"];
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
strHTML += "<b>" + tr("To") + ":</b> ";
Introduce wrappers around CBitcoinAddress This patch removes the need for the intermediary Base58 type CBitcoinAddress, by providing {Encode,Decode,IsValid}Destination function that directly operate on the conversion between strings and CTxDestination.
2017-08-23 03:02:33 +02:00
CTxDestination dest = DecodeDestination(strAddress);
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
std::string name;
Add purpose arg to Wallet::getAddress Also make all arguments to getAddress required and document args at call sites.
2018-04-10 17:50:10 +02:00
if (wallet.getAddress(
dest, &name, /* is_mine= */ nullptr, /* purpose= */ nullptr) && !name.empty())
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
strHTML += GUIUtil::HtmlEscape(name) + " ";
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
strHTML += GUIUtil::HtmlEscape(strAddress) + "<br>";
}
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
//
// Amount
//
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
if (wtx.is_coinbase && nCredit == 0)
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
{
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
//
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
// Coinbase
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
//
Use a typedef for monetary values
2014-04-23 00:46:19 +02:00
CAmount nUnmatured = 0;
scripted-diff: Fully remove BOOST_FOREACH -BEGIN VERIFY SCRIPT- sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ; -END VERIFY SCRIPT-
2017-06-02 03:18:57 +02:00
for (const CTxOut& txout : wtx.tx->vout)
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
nUnmatured += wallet.getCredit(txout, ISMINE_ALL);
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
strHTML += "<b>" + tr("Credit") + ":</b> ";
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
if (status.is_in_main_chain)
strHTML += BitcoinUnits::formatHtmlWithUnit(unit, nUnmatured)+ " (" + tr("matures in %n more block(s)", "", status.blocks_to_maturity) + ")";
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
else
strHTML += "(" + tr("not accepted") + ")";
strHTML += "<br>";
}
else if (nNet > 0)
{
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
//
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
// Credit
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
//
Implement SI-style (thin space) thoudands separator
2014-05-10 00:50:09 +02:00
strHTML += "<b>" + tr("Credit") + ":</b> " + BitcoinUnits::formatHtmlWithUnit(unit, nNet) + "<br>";
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
}
else
{
replaced MINE_ with ISMINE_
2014-07-01 11:00:22 +02:00
isminetype fAllFromMe = ISMINE_SPENDABLE;
Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations.
2018-06-18 07:58:28 +02:00
for (const isminetype mine : wtx.txin_is_mine)
Watchonly balances are shown separately in gui.
2014-03-29 05:15:28 +01:00
{
if(fAllFromMe > mine) fAllFromMe = mine;
}
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
replaced MINE_ with ISMINE_
2014-07-01 11:00:22 +02:00
isminetype fAllToMe = ISMINE_SPENDABLE;
Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations.
2018-06-18 07:58:28 +02:00
for (const isminetype mine : wtx.txout_is_mine)
Watchonly balances are shown separately in gui.
2014-03-29 05:15:28 +01:00
{
if(fAllToMe > mine) fAllToMe = mine;
}
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
if (fAllFromMe)
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
{
Add have-pubkey distinction to ISMINE flags This indicates that, eg, we have a public key for a key which may be used as a pay-to-pubkey-hash. It generally means that we can create a valid scriptSig except for missing private key(s) with which to create signatures.
2015-06-10 08:36:36 +02:00
if(fAllFromMe & ISMINE_WATCH_ONLY)
Watchonly balances are shown separately in gui.
2014-03-29 05:15:28 +01:00
strHTML += "<b>" + tr("From") + ":</b> " + tr("watch-only") + "<br>";
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
//
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
// Debit
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
//
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
auto mine = wtx.txout_is_mine.begin();
scripted-diff: Fully remove BOOST_FOREACH -BEGIN VERIFY SCRIPT- sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ; -END VERIFY SCRIPT-
2017-06-02 03:18:57 +02:00
for (const CTxOut& txout : wtx.tx->vout)
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
{
Watchonly balances are shown separately in gui.
2014-03-29 05:15:28 +01:00
// Ignore change
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
isminetype toSelf = *(mine++);
replaced MINE_ with ISMINE_
2014-07-01 11:00:22 +02:00
if ((toSelf == ISMINE_SPENDABLE) && (fAllFromMe == ISMINE_SPENDABLE))
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
continue;
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
if (!wtx.value_map.count("to") || wtx.value_map["to"].empty())
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
{
// Offline transaction
CTxDestination address;
if (ExtractDestination(txout.scriptPubKey, address))
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
{
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
strHTML += "<b>" + tr("To") + ":</b> ";
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
std::string name;
Add purpose arg to Wallet::getAddress Also make all arguments to getAddress required and document args at call sites.
2018-04-10 17:50:10 +02:00
if (wallet.getAddress(
address, &name, /* is_mine= */ nullptr, /* purpose= */ nullptr) && !name.empty())
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
strHTML += GUIUtil::HtmlEscape(name) + " ";
Introduce wrappers around CBitcoinAddress This patch removes the need for the intermediary Base58 type CBitcoinAddress, by providing {Encode,Decode,IsValid}Destination function that directly operate on the conversion between strings and CTxDestination.
2017-08-23 03:02:33 +02:00
strHTML += GUIUtil::HtmlEscape(EncodeDestination(address));
replaced MINE_ with ISMINE_
2014-07-01 11:00:22 +02:00
if(toSelf == ISMINE_SPENDABLE)
Watchonly balances are shown separately in gui.
2014-03-29 05:15:28 +01:00
strHTML += " (own address)";
Add have-pubkey distinction to ISMINE flags This indicates that, eg, we have a public key for a key which may be used as a pay-to-pubkey-hash. It generally means that we can create a valid scriptSig except for missing private key(s) with which to create signatures.
2015-06-10 08:36:36 +02:00
else if(toSelf & ISMINE_WATCH_ONLY)
Watchonly balances are shown separately in gui.
2014-03-29 05:15:28 +01:00
strHTML += " (watch-only)";
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
strHTML += "<br>";
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
}
}
Implement SI-style (thin space) thoudands separator
2014-05-10 00:50:09 +02:00
strHTML += "<b>" + tr("Debit") + ":</b> " + BitcoinUnits::formatHtmlWithUnit(unit, -txout.nValue) + "<br>";
Watchonly balances are shown separately in gui.
2014-03-29 05:15:28 +01:00
if(toSelf)
Merge remote-tracking branch 'upstream/master' Conflicts: src/qt/overviewpage.cpp src/qt/transactiondesc.cpp
2014-07-07 23:06:21 +02:00
strHTML += "<b>" + tr("Credit") + ":</b> " + BitcoinUnits::formatHtmlWithUnit(unit, txout.nValue) + "<br>";
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
}
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
if (fAllToMe)
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
{
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
// Payment to self
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
CAmount nChange = wtx.change;
Use a typedef for monetary values
2014-04-23 00:46:19 +02:00
CAmount nValue = nCredit - nChange;
Merge remote-tracking branch 'upstream/master' Conflicts: src/qt/overviewpage.cpp src/qt/transactiondesc.cpp
2014-07-07 23:06:21 +02:00
strHTML += "<b>" + tr("Total debit") + ":</b> " + BitcoinUnits::formatHtmlWithUnit(unit, -nValue) + "<br>";
strHTML += "<b>" + tr("Total credit") + ":</b> " + BitcoinUnits::formatHtmlWithUnit(unit, nValue) + "<br>";
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
}
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
Make CWalletTx store a CTransactionRef instead of inheriting
2016-11-12 01:54:51 +01:00
CAmount nTxFee = nDebit - wtx.tx->GetValueOut();
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
if (nTxFee > 0)
Implement SI-style (thin space) thoudands separator
2014-05-10 00:50:09 +02:00
strHTML += "<b>" + tr("Transaction fee") + ":</b> " + BitcoinUnits::formatHtmlWithUnit(unit, -nTxFee) + "<br>";
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
}
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
else
{
//
// Mixed debit transaction
//
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
auto mine = wtx.txin_is_mine.begin();
for (const CTxIn& txin : wtx.tx->vin) {
if (*(mine++)) {
strHTML += "<b>" + tr("Debit") + ":</b> " + BitcoinUnits::formatHtmlWithUnit(unit, -wallet.getDebit(txin, ISMINE_ALL)) + "<br>";
}
}
mine = wtx.txout_is_mine.begin();
for (const CTxOut& txout : wtx.tx->vout) {
if (*(mine++)) {
strHTML += "<b>" + tr("Credit") + ":</b> " + BitcoinUnits::formatHtmlWithUnit(unit, wallet.getCredit(txout, ISMINE_ALL)) + "<br>";
}
}
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
}
}
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
Implement SI-style (thin space) thoudands separator
2014-05-10 00:50:09 +02:00
strHTML += "<b>" + tr("Net amount") + ":</b> " + BitcoinUnits::formatHtmlWithUnit(unit, nNet, true) + "<br>";
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
//
// Message
//
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
if (wtx.value_map.count("message") && !wtx.value_map["message"].empty())
strHTML += "<br><b>" + tr("Message") + ":</b><br>" + GUIUtil::HtmlEscape(wtx.value_map["message"], true) + "<br>";
if (wtx.value_map.count("comment") && !wtx.value_map["comment"].empty())
strHTML += "<br><b>" + tr("Comment") + ":</b><br>" + GUIUtil::HtmlEscape(wtx.value_map["comment"], true) + "<br>";
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
qt: Remove TransactionTableModel::TxIDRole
2018-03-06 21:22:50 +01:00
strHTML += "<b>" + tr("Transaction ID") + ":</b> " + rec->getTxHash() + "<br>";
Make CWalletTx store a CTransactionRef instead of inheriting
2016-11-12 01:54:51 +01:00
strHTML += "<b>" + tr("Transaction total size") + ":</b> " + QString::number(wtx.tx->GetTotalSize()) + " bytes<br>";
Show a transaction's virtual size in its details dialog.
2018-03-01 21:55:01 +01:00
strHTML += "<b>" + tr("Transaction virtual size") + ":</b> " + QString::number(GetVirtualTransactionSize(*wtx.tx)) + " bytes<br>";
[Qt] remove trailing output-index from transaction-id The trailing output-index leads to cases where the user can't look-up the transaction ID in various systems.
2016-03-29 11:17:47 +02:00
strHTML += "<b>" + tr("Output index") + ":</b> " + QString::number(rec->getOutputIndex()) + "<br>";
Qt: Show transaction ID in details
2012-01-10 19:25:02 +01:00
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
// Message from normal bitcoin:URI (bitcoin:123...?message=example)
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
for (const std::pair<std::string, std::string>& r : orderForm)
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
if (r.first == "Message")
strHTML += "<br><b>" + tr("Message") + ":</b><br>" + GUIUtil::HtmlEscape(r.second, true) + "<br>";
[Qt] Show and store message of normal bitcoin:URI
2014-01-21 23:39:29 +01:00
build: Add --disable-bip70 configure option This patch adds a --disable-bip70 configure option that disables BIP70 payment request support. When disabled, this removes the dependency of the GUI on OpenSSL and Protobuf.
2017-11-06 19:12:47 +01:00
#ifdef ENABLE_BIP70
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
//
// PaymentRequest info:
//
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
for (const std::pair<std::string, std::string>& r : orderForm)
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
{
if (r.first == "PaymentRequest")
Payment Protocol: X509-validated payment requests Add support for a Payment Protocol to Bitcoin-Qt. Payment messages are protocol-buffer encoded and communicated over http(s), so this adds a dependency on the Google protocol buffer library, and requires Qt with OpenSSL support.
2013-07-22 08:50:39 +02:00
{
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
PaymentRequestPlus req;
req.parse(QByteArray::fromRawData(r.second.data(), r.second.size()));
QString merchant;
if (req.getMerchant(PaymentServer::getCertStore(), merchant))
strHTML += "<b>" + tr("Merchant") + ":</b> " + GUIUtil::HtmlEscape(merchant) + "<br>";
Payment Protocol: X509-validated payment requests Add support for a Payment Protocol to Bitcoin-Qt. Payment messages are protocol-buffer encoded and communicated over http(s), so this adds a dependency on the Google protocol buffer library, and requires Qt with OpenSSL support.
2013-07-22 08:50:39 +02:00
}
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
}
build: Add --disable-bip70 configure option This patch adds a --disable-bip70 configure option that disables BIP70 payment request support. When disabled, this removes the dependency of the GUI on OpenSSL and Protobuf.
2017-11-06 19:12:47 +01:00
#endif
Payment Protocol: X509-validated payment requests Add support for a Payment Protocol to Bitcoin-Qt. Payment messages are protocol-buffer encoded and communicated over http(s), so this adds a dependency on the Google protocol buffer library, and requires Qt with OpenSSL support.
2013-07-22 08:50:39 +02:00
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
if (wtx.is_coinbase)
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
{
quint32 numBlocksToMaturity = COINBASE_MATURITY + 1;
strHTML += "<br>" + tr("Generated coins must mature %1 blocks before they can be spent. When you generated this block, it was broadcast to the network to be added to the block chain. If it fails to get into the chain, its state will change to \"not accepted\" and it won't be spendable. This may occasionally happen if another node generates a block within a few seconds of yours.").arg(QString::number(numBlocksToMaturity)) + "<br>";
}
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
//
// Debug view
//
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
if (node.getLogCategories() != BCLog::NONE)
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
{
strHTML += "<hr><br>" + tr("Debug information") + "<br><br>";
scripted-diff: Fully remove BOOST_FOREACH -BEGIN VERIFY SCRIPT- sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ; -END VERIFY SCRIPT-
2017-06-02 03:18:57 +02:00
for (const CTxIn& txin : wtx.tx->vin)
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
if(wallet.txinIsMine(txin))
strHTML += "<b>" + tr("Debit") + ":</b> " + BitcoinUnits::formatHtmlWithUnit(unit, -wallet.getDebit(txin, ISMINE_ALL)) + "<br>";
scripted-diff: Fully remove BOOST_FOREACH -BEGIN VERIFY SCRIPT- sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ; -END VERIFY SCRIPT-
2017-06-02 03:18:57 +02:00
for (const CTxOut& txout : wtx.tx->vout)
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
if(wallet.txoutIsMine(txout))
strHTML += "<b>" + tr("Credit") + ":</b> " + BitcoinUnits::formatHtmlWithUnit(unit, wallet.getCredit(txout, ISMINE_ALL)) + "<br>";
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
strHTML += "<br><b>" + tr("Transaction") + ":</b><br>";
Make CWalletTx store a CTransactionRef instead of inheriting
2016-11-12 01:54:51 +01:00
strHTML += GUIUtil::HtmlEscape(wtx.tx->ToString(), true);
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
strHTML += "<br><b>" + tr("Inputs") + ":</b>";
strHTML += "<ul>";
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
scripted-diff: Fully remove BOOST_FOREACH -BEGIN VERIFY SCRIPT- sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ; -END VERIFY SCRIPT-
2017-06-02 03:18:57 +02:00
for (const CTxIn& txin : wtx.tx->vin)
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
{
COutPoint prevout = txin.prevout;
Use scoped locks instead of CRITICAL_BLOCK
2012-04-06 18:39:12 +02:00
Switch CCoinsView and chainstate db from per-txid to per-txout This patch makes several related changes: * Changes the CCoinsView virtual methods (GetCoins, HaveCoins, ...) to be COutPoint/Coin-based rather than txid/CCoins-based. * Changes the chainstate db to a new incompatible format that is also COutPoint/Coin based. * Implements reconstruction code for hash_serialized_2. * Adapts the coins_tests unit tests (thanks to Russell Yanofsky). A side effect of the new CCoinsView model is that we can no longer use the (unreliable) test for transaction outputs in the UTXO set to determine whether we already have a particular transaction.
2017-04-25 20:29:39 +02:00
Coin prev;
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
if(node.getUnspentOutput(prevout, prev))
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
{
{
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
strHTML += "<li>";
Switch CCoinsView and chainstate db from per-txid to per-txout This patch makes several related changes: * Changes the CCoinsView virtual methods (GetCoins, HaveCoins, ...) to be COutPoint/Coin-based rather than txid/CCoins-based. * Changes the chainstate db to a new incompatible format that is also COutPoint/Coin based. * Implements reconstruction code for hash_serialized_2. * Adapts the coins_tests unit tests (thanks to Russell Yanofsky). A side effect of the new CCoinsView model is that we can no longer use the (unreliable) test for transaction outputs in the UTXO set to determine whether we already have a particular transaction.
2017-04-25 20:29:39 +02:00
const CTxOut &vout = prev.out;
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
CTxDestination address;
if (ExtractDestination(vout.scriptPubKey, address))
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
{
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
std::string name;
Add purpose arg to Wallet::getAddress Also make all arguments to getAddress required and document args at call sites.
2018-04-10 17:50:10 +02:00
if (wallet.getAddress(address, &name, /* is_mine= */ nullptr, /* purpose= */ nullptr) && !name.empty())
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
strHTML += GUIUtil::HtmlEscape(name) + " ";
Introduce wrappers around CBitcoinAddress This patch removes the need for the intermediary Base58 type CBitcoinAddress, by providing {Encode,Decode,IsValid}Destination function that directly operate on the conversion between strings and CTxDestination.
2017-08-23 03:02:33 +02:00
strHTML += QString::fromStdString(EncodeDestination(address));
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
}
Implement SI-style (thin space) thoudands separator
2014-05-10 00:50:09 +02:00
strHTML = strHTML + " " + tr("Amount") + "=" + BitcoinUnits::formatHtmlWithUnit(unit, vout.nValue);
Remove direct bitcoin calls from qt transaction table files
2017-04-18 22:42:30 +02:00
strHTML = strHTML + " IsMine=" + (wallet.txoutIsMine(vout) & ISMINE_SPENDABLE ? tr("true") : tr("false")) + "</li>";
strHTML = strHTML + " IsWatchOnly=" + (wallet.txoutIsMine(vout) & ISMINE_WATCH_ONLY ? tr("true") : tr("false")) + "</li>";
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
}
}
}
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
strHTML += "</ul>";
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
}
Solve chainActive-related locking issues - In wallet and GUI code LOCK cs_main as well as cs_wallet when necessary - In main.cpp SendMessages move the TRY_LOCK(cs_main) up, to encompass the call to IsInitialBlockDownload. - Make ActivateBestChain, AddToBlockIndex, IsInitialBlockDownload, InitBlockIndex acquire the cs_main lock Fixes #3997
2014-04-15 17:38:25 +02:00
strHTML += "</font></html>";
transaction details dialog on doubleclick
2011-06-10 15:05:51 +02:00
return strHTML;
}
Reference in a new issue Copy permalink