LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

Merge #8915: Add copyright/patent issues to possible NACK reasons

Browse source 
36f60a5 Add copyright/patent issues to possible NACK reasons (Peter Todd)
This commit is contained in:
MarcoFalke 2016-10-14 09:52:29 +02:00
commit 03dd707dc0
No known key found for this signature in database
GPG key ID: 2D7F2372E50FE137
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
CONTRIBUTING.md
View file

@ -178,7 +178,9 @@ language is used within pull-request comments:
- ACK means "I have tested the code and I agree it should be merged";
- NACK means "I disagree this should be merged", and must be accompanied by
sound technical justification. NACKs without accompanying reasoning may be disregarded;
sound technical justification (or in certain cases of copyright/patent/licensing
issues, legal justification). NACKs without accompanying reasoning may be
disregarded;
- utACK means "I have not tested the code, but I have reviewed it and it looks
OK, I agree it can be merged";
- Concept ACK means "I agree in the general principle of this pull request";