LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

Better error message for fundrawtransaction w/ empty vout

Browse source 
Previously this case failed deep in Cwallet::CreateTransaction() with
the error message "Transaction amounts must be positive"
This commit is contained in:
Peter Todd 2015-11-13 15:52:07 -05:00
parent 61e1eb2e1c
commit 10953a7d32
No known key found for this signature in database
GPG key ID: C085F21CE7F4B9DC
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/wallet/rpcwallet.cpp
View file

@ -2418,6 +2418,9 @@ UniValue fundrawtransaction(const UniValue& params, bool fHelp)
if (!DecodeHexTx(origTx, params[0].get_str()))
throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed");
if (origTx.vout.size() == 0)
throw JSONRPCError(RPC_INVALID_PARAMETER, "TX must have at least one output");
bool includeWatching = false;
if (params.size() > 1)
includeWatching = params[1].get_bool();