LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

Simplify comparison in rpc_blockchain.py.

Browse source 
The test for gettxoutsetinfo in rpc_blockchain.py verifies that the
result is the same as before after invalidating and reconsidering a
block.  The comparison has to exclude the 'disk_size' field, though, as
it is not deterministic.

Instead of comparing all the other fields for equality, this change
explicitly removes the 'disk_size' field and then compares the full
objects.  This makes the intent more explicit (compare everything except
for disk_size, not compare just a given list of fields) and also the
code simpler.
This commit is contained in:
Daniel Kraft 2018-08-09 16:16:25 +02:00
parent df9f712746
commit 1f87c372b5
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
test/functional/rpc_blockchain.py
View file

@ -194,13 +194,10 @@ class BlockchainTest(BitcoinTestFramework):
node.reconsiderblock(b1hash) node.reconsiderblock(b1hash)
res3 = node.gettxoutsetinfo() res3 = node.gettxoutsetinfo()
assert_equal(res['total_amount'], res3['total_amount']) # The field 'disk_size' is non-deterministic and can thus not be
assert_equal(res['transactions'], res3['transactions']) # compared between res and res3. Everything else should be the same.
assert_equal(res['height'], res3['height']) del res['disk_size'], res3['disk_size']
assert_equal(res['txouts'], res3['txouts']) assert_equal(res, res3)
assert_equal(res['bogosize'], res3['bogosize'])
assert_equal(res['bestblock'], res3['bestblock'])
assert_equal(res['hash_serialized_2'], res3['hash_serialized_2'])
def _test_getblockheader(self): def _test_getblockheader(self):
node = self.nodes[0] node = self.nodes[0]