LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

Remove GetTotalBlocksEstimate and checkpoint tests that test nothing.

Browse source 
GetTotalBlocksEstimate is no longer used and it was the only thing
 the checkpoint tests were testing.

Since checkpoints are on their way out it makes more sense to remove
 the test file than to cook up a new pointless test.
This commit is contained in:
Gregory Maxwell 2016-11-02 01:49:45 +00:00
parent fd46136dfa
commit 2082b5574c
4 changed files with 0 additions and 41 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/Makefile.test.include
View file

@ -50,7 +50,6 @@ BITCOIN_TESTS =\
test/bip32_tests.cpp \ test/bip32_tests.cpp \
test/blockencodings_tests.cpp \ test/blockencodings_tests.cpp \
test/bloom_tests.cpp \ test/bloom_tests.cpp \
test/Checkpoints_tests.cpp \
test/coins_tests.cpp \ test/coins_tests.cpp \
test/compress_tests.cpp \ test/compress_tests.cpp \
test/crypto_tests.cpp \ test/crypto_tests.cpp \

10
src/checkpoints.cpp
View file

@ -55,16 +55,6 @@ namespace Checkpoints {
return fWorkBefore / (fWorkBefore + fWorkAfter); return fWorkBefore / (fWorkBefore + fWorkAfter);
} }
int GetTotalBlocksEstimate(const CCheckpointData& data)
{
const MapCheckpoints& checkpoints = data.mapCheckpoints;
if (checkpoints.empty())
return 0;
return checkpoints.rbegin()->first;
}
CBlockIndex* GetLastCheckpoint(const CCheckpointData& data) CBlockIndex* GetLastCheckpoint(const CCheckpointData& data)
{ {
const MapCheckpoints& checkpoints = data.mapCheckpoints; const MapCheckpoints& checkpoints = data.mapCheckpoints;

3
src/checkpoints.h
View file

@ -19,9 +19,6 @@ struct CCheckpointData;
namespace Checkpoints namespace Checkpoints
{ {
//! Return conservative estimate of total number of blocks, 0 if unknown
int GetTotalBlocksEstimate(const CCheckpointData& data);
//! Returns last CBlockIndex* in mapBlockIndex that is a checkpoint //! Returns last CBlockIndex* in mapBlockIndex that is a checkpoint
CBlockIndex* GetLastCheckpoint(const CCheckpointData& data); CBlockIndex* GetLastCheckpoint(const CCheckpointData& data);

27
src/test/Checkpoints_tests.cpp
View file

@ -1,27 +0,0 @@
// Copyright (c) 2011-2015 The Bitcoin Core developers
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
//
// Unit tests for block-chain checkpoints
//
#include "checkpoints.h"
#include "uint256.h"
#include "test/test_bitcoin.h"
#include "chainparams.h"
#include <boost/test/unit_test.hpp>
using namespace std;
BOOST_FIXTURE_TEST_SUITE(Checkpoints_tests, BasicTestingSetup)
BOOST_AUTO_TEST_CASE(sanity)
{
const CCheckpointData& checkpoints = Params(CBaseChainParams::MAIN).Checkpoints();
BOOST_CHECK(Checkpoints::GetTotalBlocksEstimate(checkpoints) >= 134444);
}
BOOST_AUTO_TEST_SUITE_END()