LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Packages Projects Releases 32 Wiki Activity

Merge #16723: doc: Update labels in CONTRIBUTING.md

Browse source 
a64dbeffe4 doc: Update labels in CONTRIBUTING.md (Hennadii Stepanov)

Pull request description:

  This PR:
  - adds `build` label
  - makes labels lowercase (in accordance to current customs in this repo); also a lowercase label improves readability of PR title itself, e.g.,
  ```
  doc: Update labels in CONTRIBUTING.md
  ```
  reads better than
  ```
  Doc: Update labels in CONTRIBUTING.md
  ```
  - improves label names readability
  - splits long labels (as suggested by **jonatack**)

ACKs for top commit:
  practicalswift:
    ACK a64dbeffe4
  fanquake:
    ACK a64dbeffe4

Tree-SHA512: f82e5e357490978f41035763b86cc005cf4a94099012cd0b246b664e00567ac7fa7a604bbb466b8318d94568084e3c67eecff5df152e0f39997d0a2fd9cfee77
This commit is contained in:
fanquake 2019-08-27 08:41:19 +08:00
parent efe1ee0d8d a64dbeffe4
commit 215eec3bb5
No known key found for this signature in database
GPG key ID: 2EEB9F5CC09526C1
1 changed files with 17 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
CONTRIBUTING.md
View file

@ -79,25 +79,26 @@ about Git.
The title of the pull request should be prefixed by the component or area that The title of the pull request should be prefixed by the component or area that
the pull request affects. Valid areas as: the pull request affects. Valid areas as:
- *Consensus* for changes to consensus critical code - `consensus` for changes to consensus critical code
- *Doc* for changes to the documentation - `doc` for changes to the documentation
- *Qt* for changes to bitcoin-qt - `qt` or `gui` for changes to bitcoin-qt
- *Log* Changes to log messages - `log` for changes to log messages
- *Mining* for changes to the mining code - `mining` for changes to the mining code
- *Net* or *P2P* for changes to the peer-to-peer network code - `net` or `p2p` for changes to the peer-to-peer network code
- *Refactor* for structural changes that do not change behavior - `refactor` for structural changes that do not change behavior
- *RPC/REST/ZMQ* for changes to the RPC, REST or ZMQ APIs - `rpc`, `rest` or `zmq` for changes to the RPC, REST or ZMQ APIs
- *Scripts and tools* for changes to the scripts and tools - `script` for changes to the scripts and tools
- *Test* for changes to the bitcoin unit tests or QA tests - `test` for changes to the bitcoin unit tests or QA tests
- *Utils and libraries* for changes to the utils and libraries - `util` or `lib` for changes to the utils or libraries
- *Wallet* for changes to the wallet code - `wallet` for changes to the wallet code
- `build` for changes to the GNU Autotools, reproducible builds or CI code
Examples: Examples:
Consensus: Add new opcode for BIP-XXXX OP_CHECKAWESOMESIG consensus: Add new opcode for BIP-XXXX OP_CHECKAWESOMESIG
Net: Automatically create hidden service, listen on Tor net: Automatically create hidden service, listen on Tor
Qt: Add feed bump button qt: Add feed bump button
Log: Fix typo in log message log: Fix typo in log message
Note that translations should not be submitted as pull requests, please see Note that translations should not be submitted as pull requests, please see
[Translation Process](https://github.com/bitcoin/bitcoin/blob/master/doc/translation_process.md) [Translation Process](https://github.com/bitcoin/bitcoin/blob/master/doc/translation_process.md)