Merge #14852: 0.17 backport: [tests] Add wallet_balance.py
67225e2fd7
[tests] Add wallet_balance.py (John Newbery)
Pull request description:
Tree-SHA512: 5a8707ddc7e11ac0b7b7dc27a73668acc7ff53f832d94a85930a28329ec5271da2b469e2b51d66746fa6ab54aa0221d49d215ec3434ea619352fcbacbb252883
This commit is contained in:
commit
252844329f
3 changed files with 134 additions and 13 deletions
|
@ -124,6 +124,7 @@ BASE_SCRIPTS = [
|
||||||
'wallet_importprunedfunds.py',
|
'wallet_importprunedfunds.py',
|
||||||
'rpc_zmq.py',
|
'rpc_zmq.py',
|
||||||
'rpc_signmessage.py',
|
'rpc_signmessage.py',
|
||||||
|
'wallet_balance.py',
|
||||||
'feature_nulldummy.py',
|
'feature_nulldummy.py',
|
||||||
'mempool_accept.py',
|
'mempool_accept.py',
|
||||||
'wallet_import_rescan.py',
|
'wallet_import_rescan.py',
|
||||||
|
|
133
test/functional/wallet_balance.py
Executable file
133
test/functional/wallet_balance.py
Executable file
|
@ -0,0 +1,133 @@
|
||||||
|
#!/usr/bin/env python3
|
||||||
|
# Copyright (c) 2018 The Bitcoin Core developers
|
||||||
|
# Distributed under the MIT software license, see the accompanying
|
||||||
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
||||||
|
"""Test the wallet balance RPC methods."""
|
||||||
|
from decimal import Decimal
|
||||||
|
|
||||||
|
from test_framework.test_framework import BitcoinTestFramework
|
||||||
|
from test_framework.util import (
|
||||||
|
assert_equal,
|
||||||
|
assert_raises_rpc_error,
|
||||||
|
)
|
||||||
|
|
||||||
|
RANDOM_COINBASE_ADDRESS = 'mneYUmWYsuk7kySiURxCi3AGxrAqZxLgPZ'
|
||||||
|
|
||||||
|
def create_transactions(node, address, amt, fees):
|
||||||
|
# Create and sign raw transactions from node to address for amt.
|
||||||
|
# Creates a transaction for each fee and returns an array
|
||||||
|
# of the raw transactions.
|
||||||
|
utxos = node.listunspent(0)
|
||||||
|
|
||||||
|
# Create transactions
|
||||||
|
inputs = []
|
||||||
|
ins_total = 0
|
||||||
|
for utxo in utxos:
|
||||||
|
inputs.append({"txid": utxo["txid"], "vout": utxo["vout"]})
|
||||||
|
ins_total += utxo['amount']
|
||||||
|
if ins_total > amt:
|
||||||
|
break
|
||||||
|
|
||||||
|
txs = []
|
||||||
|
for fee in fees:
|
||||||
|
outputs = {address: amt, node.getrawchangeaddress(): ins_total - amt - fee}
|
||||||
|
raw_tx = node.createrawtransaction(inputs, outputs, 0, True)
|
||||||
|
raw_tx = node.signrawtransactionwithwallet(raw_tx)
|
||||||
|
txs.append(raw_tx)
|
||||||
|
|
||||||
|
return txs
|
||||||
|
|
||||||
|
class WalletTest(BitcoinTestFramework):
|
||||||
|
def set_test_params(self):
|
||||||
|
self.num_nodes = 2
|
||||||
|
self.setup_clean_chain = True
|
||||||
|
|
||||||
|
def skip_test_if_missing_module(self):
|
||||||
|
self.skip_if_no_wallet()
|
||||||
|
|
||||||
|
def run_test(self):
|
||||||
|
# Check that nodes don't own any UTXOs
|
||||||
|
assert_equal(len(self.nodes[0].listunspent()), 0)
|
||||||
|
assert_equal(len(self.nodes[1].listunspent()), 0)
|
||||||
|
|
||||||
|
self.log.info("Mining one block for each node")
|
||||||
|
|
||||||
|
self.nodes[0].generate(1)
|
||||||
|
self.sync_all()
|
||||||
|
self.nodes[1].generate(1)
|
||||||
|
self.nodes[1].generatetoaddress(100, RANDOM_COINBASE_ADDRESS)
|
||||||
|
self.sync_all()
|
||||||
|
|
||||||
|
assert_equal(self.nodes[0].getbalance(), 50)
|
||||||
|
assert_equal(self.nodes[1].getbalance(), 50)
|
||||||
|
|
||||||
|
self.log.info("Test getbalance with different arguments")
|
||||||
|
assert_equal(self.nodes[0].getbalance("*"), 50)
|
||||||
|
assert_equal(self.nodes[0].getbalance("*", 1), 50)
|
||||||
|
assert_equal(self.nodes[0].getbalance("*", 1, True), 50)
|
||||||
|
assert_equal(self.nodes[0].getbalance(minconf=1), 50)
|
||||||
|
|
||||||
|
# Send 40 BTC from 0 to 1 and 60 BTC from 1 to 0.
|
||||||
|
txs = create_transactions(self.nodes[0], self.nodes[1].getnewaddress(), 40, [Decimal('0.01')])
|
||||||
|
self.nodes[0].sendrawtransaction(txs[0]['hex'])
|
||||||
|
self.nodes[1].sendrawtransaction(txs[0]['hex']) # sending on both nodes is faster than waiting for propagation
|
||||||
|
|
||||||
|
self.sync_all()
|
||||||
|
txs = create_transactions(self.nodes[1], self.nodes[0].getnewaddress(), 60, [Decimal('0.01'), Decimal('0.02')])
|
||||||
|
self.nodes[1].sendrawtransaction(txs[0]['hex'])
|
||||||
|
self.nodes[0].sendrawtransaction(txs[0]['hex']) # sending on both nodes is faster than waiting for propagation
|
||||||
|
self.sync_all()
|
||||||
|
|
||||||
|
# First argument of getbalance must be set to "*"
|
||||||
|
assert_raises_rpc_error(-32, "dummy first argument must be excluded or set to \"*\"", self.nodes[1].getbalance, "")
|
||||||
|
|
||||||
|
self.log.info("Test getbalance and getunconfirmedbalance with unconfirmed inputs")
|
||||||
|
|
||||||
|
# getbalance without any arguments includes unconfirmed transactions, but not untrusted transactions
|
||||||
|
assert_equal(self.nodes[0].getbalance(), Decimal('9.99')) # change from node 0's send
|
||||||
|
assert_equal(self.nodes[1].getbalance(), Decimal('29.99')) # change from node 1's send
|
||||||
|
# Same with minconf=0
|
||||||
|
assert_equal(self.nodes[0].getbalance(minconf=0), Decimal('9.99'))
|
||||||
|
assert_equal(self.nodes[1].getbalance(minconf=0), Decimal('29.99'))
|
||||||
|
# getbalance with a minconf incorrectly excludes coins that have been spent more recently than the minconf blocks ago
|
||||||
|
# TODO: fix getbalance tracking of coin spentness depth
|
||||||
|
assert_equal(self.nodes[0].getbalance(minconf=1), Decimal('0'))
|
||||||
|
assert_equal(self.nodes[1].getbalance(minconf=1), Decimal('0'))
|
||||||
|
# getunconfirmedbalance
|
||||||
|
assert_equal(self.nodes[0].getunconfirmedbalance(), Decimal('60')) # output of node 1's spend
|
||||||
|
assert_equal(self.nodes[1].getunconfirmedbalance(), Decimal('0')) # Doesn't include output of node 0's send since it was spent
|
||||||
|
|
||||||
|
# Node 1 bumps the transaction fee and resends
|
||||||
|
self.nodes[1].sendrawtransaction(txs[1]['hex'])
|
||||||
|
self.sync_all()
|
||||||
|
|
||||||
|
self.log.info("Test getbalance and getunconfirmedbalance with conflicted unconfirmed inputs")
|
||||||
|
|
||||||
|
assert_equal(self.nodes[0].getwalletinfo()["unconfirmed_balance"], Decimal('60')) # output of node 1's send
|
||||||
|
assert_equal(self.nodes[0].getunconfirmedbalance(), Decimal('60'))
|
||||||
|
assert_equal(self.nodes[1].getwalletinfo()["unconfirmed_balance"], Decimal('0')) # Doesn't include output of node 0's send since it was spent
|
||||||
|
assert_equal(self.nodes[1].getunconfirmedbalance(), Decimal('0'))
|
||||||
|
|
||||||
|
self.nodes[1].generatetoaddress(1, RANDOM_COINBASE_ADDRESS)
|
||||||
|
self.sync_all()
|
||||||
|
|
||||||
|
# balances are correct after the transactions are confirmed
|
||||||
|
assert_equal(self.nodes[0].getbalance(), Decimal('69.99')) # node 1's send plus change from node 0's send
|
||||||
|
assert_equal(self.nodes[1].getbalance(), Decimal('29.98')) # change from node 0's send
|
||||||
|
|
||||||
|
# Send total balance away from node 1
|
||||||
|
txs = create_transactions(self.nodes[1], self.nodes[0].getnewaddress(), Decimal('29.97'), [Decimal('0.01')])
|
||||||
|
self.nodes[1].sendrawtransaction(txs[0]['hex'])
|
||||||
|
self.nodes[1].generatetoaddress(2, RANDOM_COINBASE_ADDRESS)
|
||||||
|
self.sync_all()
|
||||||
|
|
||||||
|
# getbalance with a minconf incorrectly excludes coins that have been spent more recently than the minconf blocks ago
|
||||||
|
# TODO: fix getbalance tracking of coin spentness depth
|
||||||
|
# getbalance with minconf=3 should still show the old balance
|
||||||
|
assert_equal(self.nodes[1].getbalance(minconf=3), Decimal('0'))
|
||||||
|
|
||||||
|
# getbalance with minconf=2 will show the new balance.
|
||||||
|
assert_equal(self.nodes[1].getbalance(minconf=2), Decimal('0'))
|
||||||
|
|
||||||
|
if __name__ == '__main__':
|
||||||
|
WalletTest().main()
|
|
@ -67,15 +67,6 @@ class WalletTest(BitcoinTestFramework):
|
||||||
assert_equal(self.nodes[1].getbalance(), 50)
|
assert_equal(self.nodes[1].getbalance(), 50)
|
||||||
assert_equal(self.nodes[2].getbalance(), 0)
|
assert_equal(self.nodes[2].getbalance(), 0)
|
||||||
|
|
||||||
# Check getbalance with different arguments
|
|
||||||
assert_equal(self.nodes[0].getbalance("*"), 50)
|
|
||||||
assert_equal(self.nodes[0].getbalance("*", 1), 50)
|
|
||||||
assert_equal(self.nodes[0].getbalance("*", 1, True), 50)
|
|
||||||
assert_equal(self.nodes[0].getbalance(minconf=1), 50)
|
|
||||||
|
|
||||||
# first argument of getbalance must be excluded or set to "*"
|
|
||||||
assert_raises_rpc_error(-32, "dummy first argument must be excluded or set to \"*\"", self.nodes[0].getbalance, "")
|
|
||||||
|
|
||||||
# Check that only first and second nodes have UTXOs
|
# Check that only first and second nodes have UTXOs
|
||||||
utxos = self.nodes[0].listunspent()
|
utxos = self.nodes[0].listunspent()
|
||||||
assert_equal(len(utxos), 1)
|
assert_equal(len(utxos), 1)
|
||||||
|
@ -242,10 +233,6 @@ class WalletTest(BitcoinTestFramework):
|
||||||
|
|
||||||
assert(txid1 in self.nodes[3].getrawmempool())
|
assert(txid1 in self.nodes[3].getrawmempool())
|
||||||
|
|
||||||
# Exercise balance rpcs
|
|
||||||
assert_equal(self.nodes[0].getwalletinfo()["unconfirmed_balance"], 1)
|
|
||||||
assert_equal(self.nodes[0].getunconfirmedbalance(), 1)
|
|
||||||
|
|
||||||
# check if we can list zero value tx as available coins
|
# check if we can list zero value tx as available coins
|
||||||
# 1. create raw_tx
|
# 1. create raw_tx
|
||||||
# 2. hex-changed one output to 0.0
|
# 2. hex-changed one output to 0.0
|
||||||
|
|
Loading…
Reference in a new issue