LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

Add copyright/patent issues to possible NACK reasons

Browse source 
Adding in response to a Slack discussion where someone was unclear on the fact
that a NACK may be justified if code can't be accepted due to copyright/patent
issues.  For example, it would be reasonable and prudent to NACK a contribution
of AGPL-licensed consensus code on the basis that the license terms are
incompatible with the MIT license used by the rest of the codebase.
This commit is contained in:
Peter Todd 2016-10-13 19:31:52 +02:00
parent e2b8c394d6
commit 36f60a5d5b
No known key found for this signature in database
GPG key ID: 6399011044E8AFB2
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
CONTRIBUTING.md
View file

@ -178,7 +178,9 @@ language is used within pull-request comments:
- ACK means "I have tested the code and I agree it should be merged"; - ACK means "I have tested the code and I agree it should be merged";
- NACK means "I disagree this should be merged", and must be accompanied by - NACK means "I disagree this should be merged", and must be accompanied by
sound technical justification. NACKs without accompanying reasoning may be disregarded; sound technical justification (or in certain cases of copyright/patent/licensing
issues, legal justification). NACKs without accompanying reasoning may be
disregarded;
- utACK means "I have not tested the code, but I have reviewed it and it looks - utACK means "I have not tested the code, but I have reviewed it and it looks
OK, I agree it can be merged"; OK, I agree it can be merged";
- Concept ACK means "I agree in the general principle of this pull request"; - Concept ACK means "I agree in the general principle of this pull request";