LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

Small stack pushes are not treated as int when converting scripts to asm - treat all as hex.

Browse source
This commit is contained in:
Miroslav Kovar 2018-07-13 13:27:29 +02:00
parent b9a1b60555
commit 3d0b033614
1 changed files with 15 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/core_write.cpp
View file

@ -87,9 +87,6 @@ string ScriptToAsmStr(const CScript& script, const bool fAttemptSighashDecode)
return str; return str;
} }
if (0 <= opcode && opcode <= OP_PUSHDATA4) { if (0 <= opcode && opcode <= OP_PUSHDATA4) {
if (vch.size() <= static_cast<vector<unsigned char>::size_type>(4)) {
str += strprintf("%d", CScriptNum(vch, false).getint());
} else {
// the IsUnspendable check makes sure not to try to decode OP_RETURN data that may match the format of a signature // the IsUnspendable check makes sure not to try to decode OP_RETURN data that may match the format of a signature
if (fAttemptSighashDecode && !script.IsUnspendable()) { if (fAttemptSighashDecode && !script.IsUnspendable()) {
string strSigHashDecode; string strSigHashDecode;
@ -108,7 +105,6 @@ string ScriptToAsmStr(const CScript& script, const bool fAttemptSighashDecode)
} else { } else {
str += HexStr(vch); str += HexStr(vch);
} }
}
} else { } else {
str += GetOpName(opcode); str += GetOpName(opcode);
} }