LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

[tests] Fix flake8 warnings in feature_block.py

Browse source
This commit is contained in:
John Newbery 2017-11-22 12:57:58 -05:00
parent 00d1680498
commit 5cd01d235a
1 changed files with 109 additions and 100 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

105
test/functional/feature_block.py
View file

@ -2,15 +2,48 @@
# Copyright (c) 2015-2017 The Bitcoin Core developers # Copyright (c) 2015-2017 The Bitcoin Core developers
# Distributed under the MIT software license, see the accompanying # Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.php. # file COPYING or http://www.opensource.org/licenses/mit-license.php.
"""Test block processing. """Test block processing."""
import copy
This reimplements tests from the bitcoinj/FullBlockTestGenerator used import struct
by the pull-tester. import time
We use the testing framework in which we expect a particular answer from
each test.
"""
from test_framework.blocktools import create_block, create_coinbase, create_transaction, get_legacy_sigopcount_block
from test_framework.comptool import RejectResult, TestInstance, TestManager
from test_framework.key import CECKey
from test_framework.messages import (
CBlock,
CBlockHeader,
COIN,
COutPoint,
CTransaction,
CTxIn,
CTxOut,
MAX_BLOCK_BASE_SIZE,
uint256_from_compact,
uint256_from_str,
)
from test_framework.mininode import network_thread_start
from test_framework.script import (
CScript,
MAX_SCRIPT_ELEMENT_SIZE,
OP_2DUP,
OP_CHECKMULTISIG,
OP_CHECKMULTISIGVERIFY,
OP_CHECKSIG,
OP_CHECKSIGVERIFY,
OP_ELSE,
OP_ENDIF,
OP_EQUAL,
OP_FALSE,
OP_HASH160,
OP_IF,
OP_INVALIDOPCODE,
OP_RETURN,
OP_TRUE,
SIGHASH_ALL,
SignatureHash,
hash160,
)
from test_framework.test_framework import ComparisonTestFramework from test_framework.test_framework import ComparisonTestFramework
from test_framework.util import * from test_framework.util import *
from test_framework.comptool import TestManager, TestInstance, RejectResult from test_framework.comptool import TestManager, TestInstance, RejectResult
@ -18,7 +51,6 @@ from test_framework.blocktools import *
import time import time
from test_framework.key import CECKey from test_framework.key import CECKey
from test_framework.script import * from test_framework.script import *
from test_framework.mininode import network_thread_start
import struct import struct
class PreviousSpendableOutput(): class PreviousSpendableOutput():
@ -101,7 +133,7 @@ class FullBlockTest(ComparisonTestFramework):
return tx return tx
def next_block(self, number, spend=None, additional_coinbase_value=0, script=CScript([OP_TRUE]), solve=True): def next_block(self, number, spend=None, additional_coinbase_value=0, script=CScript([OP_TRUE]), solve=True):
if self.tip == None: if self.tip is None:
base_block_hash = self.genesis_hash base_block_hash = self.genesis_hash
block_time = int(time.time()) + 1 block_time = int(time.time()) + 1
else: else:
@ -112,7 +144,7 @@ class FullBlockTest(ComparisonTestFramework):
coinbase = create_coinbase(height, self.coinbase_pubkey) coinbase = create_coinbase(height, self.coinbase_pubkey)
coinbase.vout[0].nValue += additional_coinbase_value coinbase.vout[0].nValue += additional_coinbase_value
coinbase.rehash() coinbase.rehash()
if spend == None: if spend is None:
block = create_block(base_block_hash, coinbase, block_time) block = create_block(base_block_hash, coinbase, block_time)
else: else:
coinbase.vout[0].nValue += spend.tx.vout[spend.n].nValue - 1 # all but one satoshi to fees coinbase.vout[0].nValue += spend.tx.vout[spend.n].nValue - 1 # all but one satoshi to fees
@ -181,13 +213,11 @@ class FullBlockTest(ComparisonTestFramework):
# these must be updated if consensus changes # these must be updated if consensus changes
MAX_BLOCK_SIGOPS = 20000 MAX_BLOCK_SIGOPS = 20000
# Create a new block # Create a new block
block(0) block(0)
save_spendable_output() save_spendable_output()
yield accepted() yield accepted()
# Now we need that block to mature so we can spend the coinbase. # Now we need that block to mature so we can spend the coinbase.
test = TestInstance(sync_every_block=False) test = TestInstance(sync_every_block=False)
for i in range(99): for i in range(99):
@ -223,7 +253,6 @@ class FullBlockTest(ComparisonTestFramework):
txout_b3 = PreviousSpendableOutput(b3.vtx[1], 0) txout_b3 = PreviousSpendableOutput(b3.vtx[1], 0)
yield rejected() yield rejected()
# Now we add another block to make the alternative chain longer. # Now we add another block to make the alternative chain longer.
# #
# genesis -> b1 (0) -> b2 (1) # genesis -> b1 (0) -> b2 (1)
@ -231,7 +260,6 @@ class FullBlockTest(ComparisonTestFramework):
block(4, spend=out[2]) block(4, spend=out[2])
yield accepted() yield accepted()
# ... and back to the first chain. # ... and back to the first chain.
# genesis -> b1 (0) -> b2 (1) -> b5 (2) -> b6 (3) # genesis -> b1 (0) -> b2 (1) -> b5 (2) -> b6 (3)
# \-> b3 (1) -> b4 (2) # \-> b3 (1) -> b4 (2)
@ -273,7 +301,6 @@ class FullBlockTest(ComparisonTestFramework):
block(11, spend=out[4], additional_coinbase_value=1) block(11, spend=out[4], additional_coinbase_value=1)
yield rejected(RejectResult(16, b'bad-cb-amount')) yield rejected(RejectResult(16, b'bad-cb-amount'))
# Try again, but with a valid fork first # Try again, but with a valid fork first
# genesis -> b1 (0) -> b2 (1) -> b5 (2) -> b6 (3) # genesis -> b1 (0) -> b2 (1) -> b5 (2) -> b6 (3)
# \-> b12 (3) -> b13 (4) -> b14 (5) # \-> b12 (3) -> b13 (4) -> b14 (5)
@ -307,13 +334,11 @@ class FullBlockTest(ComparisonTestFramework):
yield accepted() yield accepted()
save_spendable_output() save_spendable_output()
# Test that a block with too many checksigs is rejected # Test that a block with too many checksigs is rejected
too_many_checksigs = CScript([OP_CHECKSIG] * (MAX_BLOCK_SIGOPS)) too_many_checksigs = CScript([OP_CHECKSIG] * (MAX_BLOCK_SIGOPS))
block(16, spend=out[6], script=too_many_checksigs) block(16, spend=out[6], script=too_many_checksigs)
yield rejected(RejectResult(16, b'bad-blk-sigops')) yield rejected(RejectResult(16, b'bad-blk-sigops'))
# Attempt to spend a transaction created on a different fork # Attempt to spend a transaction created on a different fork
# genesis -> b1 (0) -> b2 (1) -> b5 (2) -> b6 (3) # genesis -> b1 (0) -> b2 (1) -> b5 (2) -> b6 (3)
# \-> b12 (3) -> b13 (4) -> b15 (5) -> b17 (b3.vtx[1]) # \-> b12 (3) -> b13 (4) -> b15 (5) -> b17 (b3.vtx[1])
@ -445,7 +470,6 @@ class FullBlockTest(ComparisonTestFramework):
assert_equal(get_legacy_sigopcount_block(b32), MAX_BLOCK_SIGOPS + 1) assert_equal(get_legacy_sigopcount_block(b32), MAX_BLOCK_SIGOPS + 1)
yield rejected(RejectResult(16, b'bad-blk-sigops')) yield rejected(RejectResult(16, b'bad-blk-sigops'))
# CHECKMULTISIGVERIFY # CHECKMULTISIGVERIFY
tip(31) tip(31)
lots_of_multisigs = CScript([OP_CHECKMULTISIGVERIFY] * ((MAX_BLOCK_SIGOPS - 1) // 20) + [OP_CHECKSIG] * 19) lots_of_multisigs = CScript([OP_CHECKMULTISIGVERIFY] * ((MAX_BLOCK_SIGOPS - 1) // 20) + [OP_CHECKSIG] * 19)
@ -457,7 +481,6 @@ class FullBlockTest(ComparisonTestFramework):
block(34, spend=out[10], script=too_many_multisigs) block(34, spend=out[10], script=too_many_multisigs)
yield rejected(RejectResult(16, b'bad-blk-sigops')) yield rejected(RejectResult(16, b'bad-blk-sigops'))
# CHECKSIGVERIFY # CHECKSIGVERIFY
tip(33) tip(33)
lots_of_checksigs = CScript([OP_CHECKSIGVERIFY] * (MAX_BLOCK_SIGOPS - 1)) lots_of_checksigs = CScript([OP_CHECKSIGVERIFY] * (MAX_BLOCK_SIGOPS - 1))
@ -469,7 +492,6 @@ class FullBlockTest(ComparisonTestFramework):
block(36, spend=out[11], script=too_many_checksigs) block(36, spend=out[11], script=too_many_checksigs)
yield rejected(RejectResult(16, b'bad-blk-sigops')) yield rejected(RejectResult(16, b'bad-blk-sigops'))
# Check spending of a transaction in a block which failed to connect # Check spending of a transaction in a block which failed to connect
# #
# b6 (3) # b6 (3)
@ -541,7 +563,6 @@ class FullBlockTest(ComparisonTestFramework):
yield accepted() yield accepted()
save_spendable_output() save_spendable_output()
# Test sigops in P2SH redeem scripts # Test sigops in P2SH redeem scripts
# #
# b40 creates 3333 tx's spending the 6-sigop P2SH outputs from b39 for a total of 19998 sigops. # b40 creates 3333 tx's spending the 6-sigop P2SH outputs from b39 for a total of 19998 sigops.
@ -608,7 +629,6 @@ class FullBlockTest(ComparisonTestFramework):
yield accepted() yield accepted()
save_spendable_output() save_spendable_output()
# Test a number of really invalid scenarios # Test a number of really invalid scenarios
# #
# -> b31 (8) -> b33 (9) -> b35 (10) -> b39 (11) -> b42 (12) -> b43 (13) -> b44 (14) # -> b31 (8) -> b33 (9) -> b35 (10) -> b39 (11) -> b42 (12) -> b43 (13) -> b44 (14)
@ -658,7 +678,6 @@ class FullBlockTest(ComparisonTestFramework):
self.tip = b46 self.tip = b46
assert 46 not in self.blocks assert 46 not in self.blocks
self.blocks[46] = b46 self.blocks[46] = b46
s = ser_uint256(b46.hashMerkleRoot)
yield rejected(RejectResult(16, b'bad-blk-length')) yield rejected(RejectResult(16, b'bad-blk-length'))
# A block with invalid work # A block with invalid work
@ -693,9 +712,9 @@ class FullBlockTest(ComparisonTestFramework):
# A block with two coinbase txns # A block with two coinbase txns
tip(44) tip(44)
b51 = block(51) block(51)
cb2 = create_coinbase(51, self.coinbase_pubkey) cb2 = create_coinbase(51, self.coinbase_pubkey)
b51 = update_block(51, [cb2]) update_block(51, [cb2])
yield rejected(RejectResult(16, b'bad-cb-multiple')) yield rejected(RejectResult(16, b'bad-cb-multiple'))
# A block w/ duplicate txns # A block w/ duplicate txns
@ -729,7 +748,6 @@ class FullBlockTest(ComparisonTestFramework):
yield accepted() yield accepted()
save_spendable_output() save_spendable_output()
# Test CVE-2012-2459 # Test CVE-2012-2459
# #
# -> b42 (12) -> b43 (13) -> b53 (14) -> b55 (15) -> b57p2 (16) # -> b42 (12) -> b43 (13) -> b53 (14) -> b55 (15) -> b57p2 (16)
@ -807,20 +825,20 @@ class FullBlockTest(ComparisonTestFramework):
# tx with prevout.n out of range # tx with prevout.n out of range
tip(57) tip(57)
b58 = block(58, spend=out[17]) block(58, spend=out[17])
tx = CTransaction() tx = CTransaction()
assert(len(out[17].tx.vout) < 42) assert(len(out[17].tx.vout) < 42)
tx.vin.append(CTxIn(COutPoint(out[17].tx.sha256, 42), CScript([OP_TRUE]), 0xffffffff)) tx.vin.append(CTxIn(COutPoint(out[17].tx.sha256, 42), CScript([OP_TRUE]), 0xffffffff))
tx.vout.append(CTxOut(0, b"")) tx.vout.append(CTxOut(0, b""))
tx.calc_sha256() tx.calc_sha256()
b58 = update_block(58, [tx]) update_block(58, [tx])
yield rejected(RejectResult(16, b'bad-txns-inputs-missingorspent')) yield rejected(RejectResult(16, b'bad-txns-inputs-missingorspent'))
# tx with output value > input value out of range # tx with output value > input value out of range
tip(57) tip(57)
b59 = block(59) block(59)
tx = create_and_sign_tx(out[17].tx, out[17].n, 51 * COIN) tx = create_and_sign_tx(out[17].tx, out[17].n, 51 * COIN)
b59 = update_block(59, [tx]) update_block(59, [tx])
yield rejected(RejectResult(16, b'bad-txns-in-belowout')) yield rejected(RejectResult(16, b'bad-txns-in-belowout'))
# reset to good chain # reset to good chain
@ -846,14 +864,13 @@ class FullBlockTest(ComparisonTestFramework):
assert_equal(b60.vtx[0].serialize(), b61.vtx[0].serialize()) assert_equal(b60.vtx[0].serialize(), b61.vtx[0].serialize())
yield rejected(RejectResult(16, b'bad-txns-BIP30')) yield rejected(RejectResult(16, b'bad-txns-BIP30'))
# Test tx.isFinal is properly rejected (not an exhaustive tx.isFinal test, that should be in data-driven transaction tests) # Test tx.isFinal is properly rejected (not an exhaustive tx.isFinal test, that should be in data-driven transaction tests)
# #
# -> b39 (11) -> b42 (12) -> b43 (13) -> b53 (14) -> b55 (15) -> b57 (16) -> b60 (17) # -> b39 (11) -> b42 (12) -> b43 (13) -> b53 (14) -> b55 (15) -> b57 (16) -> b60 (17)
# \-> b62 (18) # \-> b62 (18)
# #
tip(60) tip(60)
b62 = block(62) block(62)
tx = CTransaction() tx = CTransaction()
tx.nLockTime = 0xffffffff # this locktime is non-final tx.nLockTime = 0xffffffff # this locktime is non-final
assert(out[18].n < len(out[18].tx.vout)) assert(out[18].n < len(out[18].tx.vout))
@ -861,10 +878,9 @@ class FullBlockTest(ComparisonTestFramework):
tx.vout.append(CTxOut(0, CScript([OP_TRUE]))) tx.vout.append(CTxOut(0, CScript([OP_TRUE])))
assert(tx.vin[0].nSequence < 0xffffffff) assert(tx.vin[0].nSequence < 0xffffffff)
tx.calc_sha256() tx.calc_sha256()
b62 = update_block(62, [tx]) update_block(62, [tx])
yield rejected(RejectResult(16, b'bad-txns-nonfinal')) yield rejected(RejectResult(16, b'bad-txns-nonfinal'))
# Test a non-final coinbase is also rejected # Test a non-final coinbase is also rejected
# #
# -> b39 (11) -> b42 (12) -> b43 (13) -> b53 (14) -> b55 (15) -> b57 (16) -> b60 (17) # -> b39 (11) -> b42 (12) -> b43 (13) -> b53 (14) -> b55 (15) -> b57 (16) -> b60 (17)
@ -878,7 +894,6 @@ class FullBlockTest(ComparisonTestFramework):
b63 = update_block(63, []) b63 = update_block(63, [])
yield rejected(RejectResult(16, b'bad-txns-nonfinal')) yield rejected(RejectResult(16, b'bad-txns-nonfinal'))
# This checks that a block with a bloated VARINT between the block_header and the array of tx such that # This checks that a block with a bloated VARINT between the block_header and the array of tx such that
# the block is > MAX_BLOCK_BASE_SIZE with the bloated varint, but <= MAX_BLOCK_BASE_SIZE without the bloated varint, # the block is > MAX_BLOCK_BASE_SIZE with the bloated varint, but <= MAX_BLOCK_BASE_SIZE without the bloated varint,
# does not cause a subsequent, identical block with canonical encoding to be rejected. The test does not # does not cause a subsequent, identical block with canonical encoding to be rejected. The test does not
@ -1002,7 +1017,6 @@ class FullBlockTest(ComparisonTestFramework):
update_block(70, [tx]) update_block(70, [tx])
yield rejected(RejectResult(16, b'bad-txns-inputs-missingorspent')) yield rejected(RejectResult(16, b'bad-txns-inputs-missingorspent'))
# Test accepting an invalid block which has the same hash as a valid one (via merkle tree tricks) # Test accepting an invalid block which has the same hash as a valid one (via merkle tree tricks)
# #
# -> b53 (14) -> b55 (15) -> b57 (16) -> b60 (17) -> b64 (18) -> b65 (19) -> b69 (20) -> b72 (21) # -> b53 (14) -> b55 (15) -> b57 (16) -> b60 (17) -> b64 (18) -> b65 (19) -> b69 (20) -> b72 (21)
@ -1031,7 +1045,6 @@ class FullBlockTest(ComparisonTestFramework):
yield accepted() yield accepted()
save_spendable_output() save_spendable_output()
# Test some invalid scripts and MAX_BLOCK_SIGOPS # Test some invalid scripts and MAX_BLOCK_SIGOPS
# #
# -> b55 (15) -> b57 (16) -> b60 (17) -> b64 (18) -> b65 (19) -> b69 (20) -> b72 (21) # -> b55 (15) -> b57 (16) -> b60 (17) -> b64 (18) -> b65 (19) -> b69 (20) -> b72 (21)
@ -1079,7 +1092,7 @@ class FullBlockTest(ComparisonTestFramework):
# #
# #
tip(72) tip(72)
b74 = block(74) block(74)
size = MAX_BLOCK_SIGOPS - 1 + MAX_SCRIPT_ELEMENT_SIZE + 42 # total = 20,561 size = MAX_BLOCK_SIGOPS - 1 + MAX_SCRIPT_ELEMENT_SIZE + 42 # total = 20,561
a = bytearray([OP_CHECKSIG] * size) a = bytearray([OP_CHECKSIG] * size)
a[MAX_BLOCK_SIGOPS] = 0x4e a[MAX_BLOCK_SIGOPS] = 0x4e
@ -1088,11 +1101,11 @@ class FullBlockTest(ComparisonTestFramework):
a[MAX_BLOCK_SIGOPS + 3] = 0xff a[MAX_BLOCK_SIGOPS + 3] = 0xff
a[MAX_BLOCK_SIGOPS + 4] = 0xff a[MAX_BLOCK_SIGOPS + 4] = 0xff
tx = create_and_sign_tx(out[22].tx, 0, 1, CScript(a)) tx = create_and_sign_tx(out[22].tx, 0, 1, CScript(a))
b74 = update_block(74, [tx]) update_block(74, [tx])
yield rejected(RejectResult(16, b'bad-blk-sigops')) yield rejected(RejectResult(16, b'bad-blk-sigops'))
tip(72) tip(72)
b75 = block(75) block(75)
size = MAX_BLOCK_SIGOPS - 1 + MAX_SCRIPT_ELEMENT_SIZE + 42 size = MAX_BLOCK_SIGOPS - 1 + MAX_SCRIPT_ELEMENT_SIZE + 42
a = bytearray([OP_CHECKSIG] * size) a = bytearray([OP_CHECKSIG] * size)
a[MAX_BLOCK_SIGOPS - 1] = 0x4e a[MAX_BLOCK_SIGOPS - 1] = 0x4e
@ -1101,18 +1114,18 @@ class FullBlockTest(ComparisonTestFramework):
a[MAX_BLOCK_SIGOPS + 2] = 0xff a[MAX_BLOCK_SIGOPS + 2] = 0xff
a[MAX_BLOCK_SIGOPS + 3] = 0xff a[MAX_BLOCK_SIGOPS + 3] = 0xff
tx = create_and_sign_tx(out[22].tx, 0, 1, CScript(a)) tx = create_and_sign_tx(out[22].tx, 0, 1, CScript(a))
b75 = update_block(75, [tx]) update_block(75, [tx])
yield accepted() yield accepted()
save_spendable_output() save_spendable_output()
# Check that if we push an element filled with CHECKSIGs, they are not counted # Check that if we push an element filled with CHECKSIGs, they are not counted
tip(75) tip(75)
b76 = block(76) block(76)
size = MAX_BLOCK_SIGOPS - 1 + MAX_SCRIPT_ELEMENT_SIZE + 1 + 5 size = MAX_BLOCK_SIGOPS - 1 + MAX_SCRIPT_ELEMENT_SIZE + 1 + 5
a = bytearray([OP_CHECKSIG] * size) a = bytearray([OP_CHECKSIG] * size)
a[MAX_BLOCK_SIGOPS - 1] = 0x4e # PUSHDATA4, but leave the following bytes as just checksigs a[MAX_BLOCK_SIGOPS - 1] = 0x4e # PUSHDATA4, but leave the following bytes as just checksigs
tx = create_and_sign_tx(out[23].tx, 0, 1, CScript(a)) tx = create_and_sign_tx(out[23].tx, 0, 1, CScript(a))
b76 = update_block(76, [tx]) update_block(76, [tx])
yield accepted() yield accepted()
save_spendable_output() save_spendable_output()
@ -1173,7 +1186,6 @@ class FullBlockTest(ComparisonTestFramework):
assert(tx78.hash in mempool) assert(tx78.hash in mempool)
assert(tx79.hash in mempool) assert(tx79.hash in mempool)
# Test invalid opcodes in dead execution paths. # Test invalid opcodes in dead execution paths.
# #
# -> b81 (26) -> b82 (27) -> b83 (28) # -> b81 (26) -> b82 (27) -> b83 (28)
@ -1191,7 +1203,6 @@ class FullBlockTest(ComparisonTestFramework):
yield accepted() yield accepted()
save_spendable_output() save_spendable_output()
# Reorg on/off blocks that have OP_RETURN in them (and try to spend them) # Reorg on/off blocks that have OP_RETURN in them (and try to spend them)
# #
# -> b81 (26) -> b82 (27) -> b83 (28) -> b84 (29) -> b87 (30) -> b88 (31) # -> b81 (26) -> b82 (27) -> b83 (28) -> b84 (29) -> b87 (30) -> b88 (31)
@ -1241,7 +1252,6 @@ class FullBlockTest(ComparisonTestFramework):
update_block("89a", [tx]) update_block("89a", [tx])
yield rejected() yield rejected()
# Test re-org of a week's worth of blocks (1088 blocks) # Test re-org of a week's worth of blocks (1088 blocks)
# This test takes a minute or two and can be accomplished in memory # This test takes a minute or two and can be accomplished in memory
# #
@ -1288,6 +1298,5 @@ class FullBlockTest(ComparisonTestFramework):
chain1_tip += 2 chain1_tip += 2
if __name__ == '__main__': if __name__ == '__main__':
FullBlockTest().main() FullBlockTest().main()