LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

Merge #10964: Pass SendCoinsRecipient (208 bytes) by reference

Browse source 
d3d946a29 Pass SendCoinsRecipient (208 bytes) by const reference (practicalswift)

Pull request description:

  Pass `SendCoinsRecipient` (208 bytes) by reference.

  Avoid passing big parameters by value.

Tree-SHA512: 504791f1b1c73badbc276db13b83e39695298d7d82a9db0e48d54e7ef02f1a8d276b0adfdece1ba1130cc214e2f0fa9a3100b5359d0ca0fe96558d3c9a786e6e
This commit is contained in:
Jonas Schnelli 2017-08-15 20:43:32 +02:00
commit 64e66bb262
No known key found for this signature in database
GPG key ID: 1EB776BB03C7922D
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/qt/paymentserver.cpp
View file

@ -620,7 +620,7 @@ void PaymentServer::fetchRequest(const QUrl& url)
netManager->get(netRequest); netManager->get(netRequest);
} }
void PaymentServer::fetchPaymentACK(CWallet* wallet, SendCoinsRecipient recipient, QByteArray transaction) void PaymentServer::fetchPaymentACK(CWallet* wallet, const SendCoinsRecipient& recipient, QByteArray transaction)
{ {
const payments::PaymentDetails& details = recipient.paymentRequest.getDetails(); const payments::PaymentDetails& details = recipient.paymentRequest.getDetails();
if (!details.has_payment_url()) if (!details.has_payment_url())

2
src/qt/paymentserver.h
View file

@ -113,7 +113,7 @@ public Q_SLOTS:
void uiReady(); void uiReady();
// Submit Payment message to a merchant, get back PaymentACK: // Submit Payment message to a merchant, get back PaymentACK:
void fetchPaymentACK(CWallet* wallet, SendCoinsRecipient recipient, QByteArray transaction); void fetchPaymentACK(CWallet* wallet, const SendCoinsRecipient& recipient, QByteArray transaction);
// Handle an incoming URI, URI with local file scheme or file // Handle an incoming URI, URI with local file scheme or file
void handleURIOrFile(const QString& s); void handleURIOrFile(const QString& s);

2
src/qt/test/paymentservertests.cpp
View file

@ -205,7 +205,7 @@ void PaymentServerTests::paymentServerTests()
delete server; delete server;
} }
void RecipientCatcher::getRecipient(SendCoinsRecipient r) void RecipientCatcher::getRecipient(const SendCoinsRecipient& r)
{ {
recipient = r; recipient = r;
} }

2
src/qt/test/paymentservertests.h
View file

@ -26,7 +26,7 @@ class RecipientCatcher : public QObject
Q_OBJECT Q_OBJECT
public Q_SLOTS: public Q_SLOTS:
void getRecipient(SendCoinsRecipient r); void getRecipient(const SendCoinsRecipient& r);
public: public:
SendCoinsRecipient recipient; SendCoinsRecipient recipient;