Fix signed / unsigned compare

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>
This commit is contained in:
Anthony Fieroni 2019-12-13 18:06:11 +02:00 committed by Brannon King
parent 8a5cc01111
commit 6dfe15ed2e
2 changed files with 4 additions and 3 deletions

View file

@ -42,7 +42,7 @@ namespace sqlite
auto ptr = sqlite3_column_blob(stmt, inx); auto ptr = sqlite3_column_blob(stmt, inx);
if (!ptr) return ret; if (!ptr) return ret;
int bytes = sqlite3_column_bytes(stmt, inx); int bytes = sqlite3_column_bytes(stmt, inx);
assert(bytes <= ret.size()); assert(bytes > 0 && bytes <= int(ret.size()));
std::memcpy(ret.begin(), ptr, bytes); std::memcpy(ret.begin(), ptr, bytes);
return ret; return ret;
} }
@ -52,7 +52,7 @@ namespace sqlite
auto ptr = sqlite3_column_blob(stmt, inx); auto ptr = sqlite3_column_blob(stmt, inx);
if (!ptr) return ret; if (!ptr) return ret;
int bytes = sqlite3_column_bytes(stmt, inx); int bytes = sqlite3_column_bytes(stmt, inx);
assert(bytes <= ret.size()); assert(bytes > 0 && bytes <= int(ret.size()));
std::memcpy(ret.begin(), ptr, bytes); std::memcpy(ret.begin(), ptr, bytes);
return ret; return ret;
} }

View file

@ -44,6 +44,7 @@ namespace sqlite {
auto ptr = (const unsigned char*)sqlite3_column_blob(stmt, inx); auto ptr = (const unsigned char*)sqlite3_column_blob(stmt, inx);
if (!ptr) return {}; if (!ptr) return {};
int bytes = sqlite3_column_bytes(stmt, inx); int bytes = sqlite3_column_bytes(stmt, inx);
assert(bytes >= 0);
return CScript(ptr, ptr + bytes); return CScript(ptr, ptr + bytes);
} }
@ -62,7 +63,7 @@ namespace sqlite {
uint256 ret; uint256 ret;
if (!ptr) return ret; if (!ptr) return ret;
int bytes = sqlite3_column_bytes(stmt, inx); int bytes = sqlite3_column_bytes(stmt, inx);
assert(bytes <= ret.size()); assert(bytes > 0 && bytes <= int(ret.size()));
std::memcpy(ret.begin(), ptr, bytes); std::memcpy(ret.begin(), ptr, bytes);
return ret; return ret;
} }