LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

Acquire cs_main before ATMP call in block_assemble bench

Browse source 
Otherwise we fail an assert in sync.cpp:AssertLockHeldInternal.
This commit is contained in:
James O'Beirne 2018-07-30 11:33:05 -04:00
parent 63d73f5bc8
commit 6f53edb395
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/bench/block_assemble.cpp
View file

@ -97,10 +97,14 @@ static void AssembleBlock(benchmark::State& state)
if (NUM_BLOCKS - b >= COINBASE_MATURITY) if (NUM_BLOCKS - b >= COINBASE_MATURITY)
txs.at(b) = MakeTransactionRef(tx); txs.at(b) = MakeTransactionRef(tx);
} }
for (const auto& txr : txs) { {
CValidationState state; LOCK(::cs_main); // Required for ::AcceptToMemoryPool.
bool ret{::AcceptToMemoryPool(::mempool, state, txr, nullptr /* pfMissingInputs */, nullptr /* plTxnReplaced */, false /* bypass_limits */, /* nAbsurdFee */ 0)};
assert(ret); for (const auto& txr : txs) {
CValidationState state;
bool ret{::AcceptToMemoryPool(::mempool, state, txr, nullptr /* pfMissingInputs */, nullptr /* plTxnReplaced */, false /* bypass_limits */, /* nAbsurdFee */ 0)};
assert(ret);
}
} }
while (state.KeepRunning()) { while (state.KeepRunning()) {