[qa] Avoid 2 list comprehensions in sync_blocks

This commit is contained in:
Russell Yanofsky 2016-11-11 15:43:15 -05:00
parent 05e57ccd74
commit 7943b13ab3

View file

@ -134,9 +134,9 @@ def sync_blocks(rpc_connections, *, wait=1, timeout=60):
while cur_time <= start_time + timeout: while cur_time <= start_time + timeout:
tips = [r.waitforblockheight(maxheight, int(wait * 1000)) for r in rpc_connections] tips = [r.waitforblockheight(maxheight, int(wait * 1000)) for r in rpc_connections]
heights = [t["height"] for t in tips] heights = [t["height"] for t in tips]
if tips == [tips[0]] * len(tips): if all(t == tips[0] for t in tips):
return return
if heights == [heights[0]] * len(heights): if all(h == heights[0] for h in heights):
raise AssertionError("Block sync failed, mismatched block hashes:{}".format( raise AssertionError("Block sync failed, mismatched block hashes:{}".format(
"".join("\n {!r}".format(tip) for tip in tips))) "".join("\n {!r}".format(tip) for tip in tips)))
maxheight = max(heights) maxheight = max(heights)