LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

Merge #10501: remove some unused functions

Browse source 
f228b8e remove some unused functions (Marko Bencun)

Pull request description:

  Identified with `cppcheck --enable=unusedFunction .`.

   - GetSendBufferSize()'s last use removed in
     991955e
   - SetPort()'s last use removed in
     7e195e8
   - GetfLargeWorkInvalidChainFound() was introduced in
     e3ba0ef and never used

Tree-SHA512: ea8e5498bec981e42e1342c171c37723c2f5e575c7d6c1a524d9c6cd9b332bdd0d84fddf9e14ca011bb49fb82bd037386382c9afc546b3c2231ae548358bd4f4
This commit is contained in:
Wladimir J. van der Laan 2017-07-27 13:18:57 +02:00
commit 8a99fe053a
No known key found for this signature in database
GPG key ID: 1E4AED62986CD25D
6 changed files with 0 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/net.cpp
View file

@ -2694,7 +2694,6 @@ int CConnman::GetBestHeight() const
} }
unsigned int CConnman::GetReceiveFloodSize() const { return nReceiveFloodSize; } unsigned int CConnman::GetReceiveFloodSize() const { return nReceiveFloodSize; }
unsigned int CConnman::GetSendBufferSize() const{ return nSendBufferMaxSize; }
CNode::CNode(NodeId idIn, ServiceFlags nLocalServicesIn, int nMyStartingHeightIn, SOCKET hSocketIn, const CAddress& addrIn, uint64_t nKeyedNetGroupIn, uint64_t nLocalHostNonceIn, const CAddress &addrBindIn, const std::string& addrNameIn, bool fInboundIn) : CNode::CNode(NodeId idIn, ServiceFlags nLocalServicesIn, int nMyStartingHeightIn, SOCKET hSocketIn, const CAddress& addrIn, uint64_t nKeyedNetGroupIn, uint64_t nLocalHostNonceIn, const CAddress &addrBindIn, const std::string& addrNameIn, bool fInboundIn) :
nTimeConnected(GetSystemTimeInSeconds()), nTimeConnected(GetSystemTimeInSeconds()),

2
src/net.h
View file

@ -242,8 +242,6 @@ public:
bool DisconnectNode(const std::string& node); bool DisconnectNode(const std::string& node);
bool DisconnectNode(NodeId id); bool DisconnectNode(NodeId id);
unsigned int GetSendBufferSize() const;
ServiceFlags GetLocalServices() const; ServiceFlags GetLocalServices() const;
//!set the max outbound target in bytes //!set the max outbound target in bytes

5
src/netaddress.cpp
View file

@ -598,11 +598,6 @@ std::string CService::ToString() const
return ToStringIPPort(); return ToStringIPPort();
} }
void CService::SetPort(unsigned short portIn)
{
port = portIn;
}
CSubNet::CSubNet(): CSubNet::CSubNet():
valid(false) valid(false)
{ {

1
src/netaddress.h
View file

@ -148,7 +148,6 @@ class CService : public CNetAddr
CService(const struct in_addr& ipv4Addr, unsigned short port); CService(const struct in_addr& ipv4Addr, unsigned short port);
CService(const struct sockaddr_in& addr); CService(const struct sockaddr_in& addr);
void Init(); void Init();
void SetPort(unsigned short portIn);
unsigned short GetPort() const; unsigned short GetPort() const;
bool GetSockAddr(struct sockaddr* paddr, socklen_t *addrlen) const; bool GetSockAddr(struct sockaddr* paddr, socklen_t *addrlen) const;
bool SetSockAddr(const struct sockaddr* paddr); bool SetSockAddr(const struct sockaddr* paddr);

6
src/warnings.cpp
View file

@ -37,12 +37,6 @@ void SetfLargeWorkInvalidChainFound(bool flag)
fLargeWorkInvalidChainFound = flag; fLargeWorkInvalidChainFound = flag;
} }
bool GetfLargeWorkInvalidChainFound()
{
LOCK(cs_warnings);
return fLargeWorkInvalidChainFound;
}
std::string GetWarnings(const std::string& strFor) std::string GetWarnings(const std::string& strFor)
{ {
std::string strStatusBar; std::string strStatusBar;

1
src/warnings.h
View file

@ -13,7 +13,6 @@ void SetMiscWarning(const std::string& strWarning);
void SetfLargeWorkForkFound(bool flag); void SetfLargeWorkForkFound(bool flag);
bool GetfLargeWorkForkFound(); bool GetfLargeWorkForkFound();
void SetfLargeWorkInvalidChainFound(bool flag); void SetfLargeWorkInvalidChainFound(bool flag);
bool GetfLargeWorkInvalidChainFound();
/** Format a string that describes several potential problems detected by the core. /** Format a string that describes several potential problems detected by the core.
* strFor can have three values: * strFor can have three values:
* - "rpc": get critical warnings, which should put the client in safe mode if non-empty * - "rpc": get critical warnings, which should put the client in safe mode if non-empty