Merge #13916: qa: wait_for_verack by default
fa5587fe71
qa: wait_for_verack by default (MarcoFalke)
Pull request description:
This removes the need to do so manually every time a connection is added.
Tree-SHA512: a46c92cb4df41e30778b42b9fd3dcbd8d2d82aa7503d1213cb1c1165034f648d8caee01c292e2d87d05b0f71696996eef5be8a753f35ab49e5f66b0e3bf29f21
This commit is contained in:
commit
8ac7125d59
21 changed files with 11 additions and 56 deletions
test/functional
|
@ -130,12 +130,9 @@ class ExampleTest(BitcoinTestFramework):
|
|||
def run_test(self):
|
||||
"""Main test logic"""
|
||||
|
||||
# Create P2P connections to two of the nodes
|
||||
# Create P2P connections will wait for a verack to make sure the connection is fully up
|
||||
self.nodes[0].add_p2p_connection(BaseNode())
|
||||
|
||||
# wait_for_verack ensures that the P2P connection is fully up.
|
||||
self.nodes[0].p2p.wait_for_verack()
|
||||
|
||||
# Generating a block on one of the nodes will get us out of IBD
|
||||
blocks = [int(self.nodes[0].generate(nblocks=1)[0], 16)]
|
||||
self.sync_all([self.nodes[0:1]])
|
||||
|
@ -187,7 +184,6 @@ class ExampleTest(BitcoinTestFramework):
|
|||
self.nodes[0].disconnect_p2ps()
|
||||
|
||||
self.nodes[2].add_p2p_connection(BaseNode())
|
||||
self.nodes[2].p2p.wait_for_verack()
|
||||
|
||||
self.log.info("Wait for node2 reach current tip. Test that it has propagated all the blocks to us")
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue